find the last occurence of char in string WITHOUT the use of strrchr()

Hi, I am trying to write a function that locate the last occurence of a string without using string library. Also, i would like to use pointers but I am getting "Segmentation Fault" every time i run the program.

heres my function. Thanks in advance guys.

Code:

---

int str_char(char c, char *str)
{
    int i;
    int last = 0;
    char *strptr = str;
    while (*strptr != '\0') {
        if (strptr[i] == c)
            last = i;
    }
    return last;
}

---

You are not changing i (and you either shoud use i to index into strptr in both places, or change strptr forward and not use index).

--
Mats

Try to decrement strptr until it reaches the beginning or points to the desired char. Then somehow calculate the index of the character. Or use you own way and increment i. But I think it'd be better to search backward.

Quote:

---

Originally Posted by Brafil

Try to decrement strptr until it reaches the beginning or points to the desired char. Then somehow calculate the index of the character. Or use you own way and increment i. But I think it'd be better to search backward.

---

Actually makes fairly little difference. If the string is very long (hundreds of characters) then it may be of benefit to do strlen first - but strlen in itself has to read every character, so it's not MUCH benefit - the main benefit is that when you read from the back, you can stop immediately as you have found the target character.

--
Mats

Ooops, forgot this issue with strlen. And you have to check if strptr is smaller than str every time.

You probably also want to return something other than 0 if you don't find the character. 0 would be returned if the last instance of the character was at the start of the string as well and you don't have a way to tell them apart.

Just a hint: Since the result can only be positive, return a negative value on failure (-1).