if else statement ????

I`m trying to to use if statement but something going wrong.
statement must be 2 steps
IF There is still room in the array and
IF there is not an Appointmen on the same Date and Time!
Apointment will be accept......
im not getting any error or worning
but its not chaking second if statement and both else printing together

Code:

---

void addAppointmenRecords( )
{ 
        int number, i,k;
        system("cls");        //clear screen
                cout<<"\nHow many Appointmen you wish to add? ";
                cin>>number;                  //read number
                cin.get();            //read newline character left in the buffer

        if((number + currentSize ) <= listSize)        //There is still room in the array
        {
          for( i = 1; i<=number; i++ )
          {
                        cout<<"\nEnter Person name: ";
                        getline(cin, AppointmenList[currentSize].name);
                        cout<<"Enter Appointmen Descriptions: ";
                        getline(cin, AppointmenList[currentSize].description);
                        cout<<"Enter Appointmen date: ";
                        cin>>AppointmenList[currentSize].appdate.day;
                        cin>>AppointmenList[currentSize].appdate.mounth;
                        cin>>AppointmenList[currentSize].appdate.year;
                        cin.get();                                                        //read a character
                        cout<<"Enter Appointmen time: ";
                                                getline(cin, AppointmenList[currentSize].time);
                        cout<<endl;
                        currentSize += 1; //update CurrentSize
         
                       
                        for(k=0; k<currentSize; k++)  //chech if there an Appointmen on the same Date and Time!
                        if( AppointmenList[currentSize].appdate.day == AppointmenList[k].appdate.day &&
                                AppointmenList[currentSize].appdate.mounth == AppointmenList[k].appdate.mounth &&
                                AppointmenList[currentSize].appdate.year == AppointmenList[k].appdate.year &&
                                AppointmenList[currentSize].time == AppointmenList[k].time )
                        {
                        cout<<"\nGot a match\n";
                                cout<<"Appointmen Date and Time already filled"<<endl;
                                currentSize-=1;
                }
                        else
                        {
                                cout<<"Apointment accepted"<<endl;
                                currentSize+=1;
                        }
          }
        }
                        else
                        {
                                cout<<"Overflow!!!! Appointmen List is full"<<endl;
                                cout<<"\nPress any key to continue"<<endl;
                                cin.get();    //read a character
                        }
}

---

It's almost impossible to see where blocks begin and end due to the mismatched braces in there. The indentation must be improved! Clearly it is going haywire due to the mixed tabs and spaces in there. Stick to one or fix it if your editor is being a bastard.

Yeah, she're right. Clean up your code a bit, then post it again here! But, as i was looking through it, i saw you have 2 else statements the one next the other! Check this first.

Oh, sorry, NOW i saw it. Ahh, its such a mess in here. Forget what i said

sorry for my codes i tryed to clean a bit.
its not checking

Quote:

---

if there an Appointmen on the same Date and Time!

---

and printing

Quote:

---

"Apointment accepted"

---

and

Quote:

---

Got a match
Appointment Date and Time already filled

---

can anybody see mistakes now??????

Code:

---

void addAppointmenRecords( )
{ 
        int number, i,k;
        system("cls");      //clear screen
        cout<<"\nHow many Appointments do you wish to add? ";
        cin>>number;        //read number
        cin.get();            //read newline character left in the buffer

        if((number + currentSize ) <= listSize)//There is still room in the array
        {
                for( i = 1; i<=number; i++ )
                {
                        cout<<"\nEnter Person name: ";
                        getline(cin, AppointmenList[currentSize].name);
                        cout<<"Enter Appointment Descriptions: ";
                        getline(cin, AppointmenList[currentSize].description);
                        cout<<"Enter Appointment date: ";
                        cin>>AppointmenList[currentSize].appdate.day;
                        cin>>AppointmenList[currentSize].appdate.mounth;
                        cin>>AppointmenList[currentSize].appdate.year;
                        cin.get();//read a character
                        cout<<"Enter Appointment time: ";
                        getline(cin, AppointmenList[currentSize].time);
                        cout<<endl;
                        currentSize += 1; //update CurrentSize
                        for(k=0; k<currentSize; k++)  //check if there an Appointmen on the same Date and Time!
                        {
                                if(AppointmenList[currentSize].appdate.day == AppointmenList[k].appdate.day &&
                                AppointmenList[currentSize].appdate.mounth == AppointmenList[k].appdate.mounth &&
                                AppointmenList[currentSize].appdate.year == AppointmenList[k].appdate.year &&
                                AppointmenList[currentSize].time == AppointmenList[k].time )
                                {
                                        cout<<"\nGot a match\n";
                                        cout<<"Appointment Date and Time already filled"<<endl;
                                        currentSize-=1;
                                        break;
                                }
                                else
                                {
                                        cout<<"Apointment accepted"<<endl;
                                        currentSize+=1;
                                }
                        }
                }
        }
        else
        {
                cout<<"Overflow!!!! Appointment List is full"<<endl;
                cout<<"\nPress any key to continue"<<endl;
                cin.get();    //read a character
        }
}

---

Your second if statement is waaay big! Try encapsulating like this:

Code:

---

if ( )
{
  if ( )
  {
      if ( )
      {
        /*.....*/
        if ( )
        {
            /*Your code here*/ 
        }
          /*.....*/
      }
    }
}

---

Quote:

---

Your second if statement is waaay big!

---

You probably have some sort of date_time class or struct. What you could do is overload the == operator for it, and then go:

Code:

---

if(AppointmenList[currentSize].appdate == AppointmenList[k].appdate)

---

Perhaps your problem is incrementing currentSize twice per succesfully added appointment. Don't increment it before checking and only increment it in the "successfully added" branch. (In other words, the entered appointment is not what you are checking since you have changed currentSize in the meantime.

you right anon
i have date struct (day, mounth ,year) time is string i tried

Quote:

---

if(AppointmenList[currentSize].appdate == AppointmenList[k].appdate)

---

but didn`t work and incrementing currentSize once now

i couldnt figure out how im gonna use this

Code:

---

if ( )
{
  if ( )
  {
      if ( )
      {
        /*.....*/
        if ( )
        {
            /*Your code here*/ 
        }
          /*.....*/
      }
    }
}

---

here is my codes i still have problem with

Quote:

---

//check if there an Appointment on the same Date and Time!

---

i can add more then one record on the same date and time which is not supposed to happen

Code:

---

void addAppointmentRecords( )
{ 
        int number;
        system("cls");      //clear screen
        cout<<"\nHow many Appointments do you wish to add ";
        cin>>number;        //read number
        cin.get();        //read newline character left in the buffer

        if((number + currentSize ) <= listSize)//There is still room in the array
        {
                for(int i = 1; i<=number; i++)
                {
                        cout<<"\nEnter Person name: ";
                        getline(cin, AppointmentList[currentSize].name);
                        cout<<"Enter Appointment Descriptions: ";
                        getline(cin, AppointmentList[currentSize].description);
                        cout<<"Enter Appointment date: ";
                        cin>>AppointmentList[currentSize].appdate.day;
                        cin>>AppointmentList[currentSize].appdate.mounth;
                        cin>>AppointmentList[currentSize].appdate.year;
                        cin.get();            //read a character
                        cout<<"Enter Appointment time: ";
                        getline(cin, AppointmentList[currentSize].time);
                        cout<<endl;
                        currentSize += 1;    //update CurrentSize
                        for(int k=0; k<=currentSize; k++)
                        {                                        //check if there an Appointment on the same Date and Time!
                                if( AppointmentList[currentSize].appdate.day == AppointmentList[k].appdate.day &&
                                    AppointmentList[currentSize].appdate.mounth == AppointmentList[k].appdate.mounth &&
                                    AppointmentList[currentSize].appdate.year == AppointmentList[k].appdate.year &&
                                      AppointmentList[currentSize].time == AppointmentList[k].time )
                                {
                                        cout<<"\nGot a match\n";
                                        cout<<"Appointment Date and Time already filled"<<endl;
                                        currentSize -= 1; //update CurrentSize
                                        cin.get();
                                }
                                else
                                {
                                        cout<<"Apointment accepted"<<endl;
                                        cin.get();    //read a character
                                        break;
                                }
                        }
                }
        }
        else
        {
                cout<<"Overflow!!!! Appointment List is full"<<endl;
                cout<<"\nPress any key to continue"<<endl;
                cin.get();    //read a character
        }
}

---

I suggest you write a function called CompareAppointMents() that take two appointment items and compare them, then use that instead of the four lines of

Code:

---

                                    AppointmentList[currentSize].appdate.day == AppointmentList[k].appdate.day &&
                                    AppointmentList[currentSize].appdate.mounth == AppointmentList[k].appdate.mounth &&
                                    AppointmentList[currentSize].appdate.year == AppointmentList[k].appdate.year &&
                                      AppointmentList[currentSize].time == AppointmentList[k].time

---

--
Mats

Quote:

---

you right anon
i have date struct (day, mounth ,year) time is string i tried
...
but didn`t work and incrementing currentSize once now

---

You need to write code to make it work:

Code:

---

bool operator==(const date_time& a, const date_time& b)
{
    return a.year == b.year && a.month == b.month && a.day == b.day && a.time == b.time;
}

---

(Appointments probably take some time and shouldn't overlap, though. In which case you might need a bit more complicated function here, and might call it AppointmentsOverlap or something like that.)

As to incrementing currentSize, you shouldn't do it before checking. Your new appointment is at index currentSize and you want to check it against all appointments with index less than currentSize. If you increment it before checking, you will be comparing all appointments, including the new one, against an appointment that has no data yet.

thanks anon
i done

Quote:

---

if(AppointmenList[currentSize].appdate == AppointmenList[k].appdate)

---

but didnt solve my problem i even tried just

Quote:

---

if(AppointmentList[currentSize].time == AppointmentList[k].time)

---

but still same
so i dont think its a problem

Quote:

---

Your second if statement is waaay big!

---

Quote:

---

but didnt solve my problem i even tried just

---

This is a style issue (of breaking larger functions up into smaller and simpler functions) and not meant to solve the problem.

I think I've mentioned the possible cause why your program isn't working right a couple of times. It's not how you compare appointment times but which appointments you compare in the first place.