strange "syntax error" problem :S

hey again, I know I'm asking a load of questions, but I find this problem really strange :S
I use Visual C++ 2008 Express, and i get this error "error C2061: syntax error : identifier 'platform'" Yes I've tried google ;)

ok, so I got this function:

Code:

---

void character::stop(HGE* hge, character& c, platform& plat){
        float dt = hge->Timer_GetDelta();

        if(c.charRect.Intersect(&plat.rect)){
                if(dir == LEFT) x += speed * dt;
                if(dir == RIGHT) x -= speed * dt;
                if(dir == DOWN) y -= gravityPull;
                if(dir == UP) y += speed * dt;
        }
}

---

And one other that's kinda the same, just in a different class

Code:

---

void worldManager::chrIntersectPlat(character& c, platform& plat){
        c.stop(hge,c,plat);

}

---

See, those look kinda the same, just that the first one has also the 'HGE* hge' argument... But the first one gives the error :S
Both have 'platform.h' included, why does it then only work on one of them?
Thanks in advance!

Perhaps character isn't what you think it is.
If it's a macro, it could have turned your code into pudding before you know what's happened.

what's that supposed to mean? o.O

Make sure you haven't defined any macros that could be causing 'character' or 'c' to be preprocessed away.

what's a macro o.O?

Quote:

---

Originally Posted by Akkernight

what's a macro o.O?

---

Cynical answer: Something you almost certainly shouldn't be using in C++.

Real answer: Something defined using the #define preprocessor directive.

ohh... Well, I havn't used #define, except for the h files, like #define CHARACTER_H and such stuff xP
oh and I have one enum, but it doesn't have any name close to any of those :S

How is platform defined?

Code:

---

#define PLATFORM_H

---

This is very frusterating xP

That is clearly not a definition of the platform datatype.

huh o.O? That's what I'm having in the platform.h file...

Code:

---

#ifndef PLATFORM_H
#define PLATFORM_H

#include "hge.h"
#include "hgerect.h"
#include "character.h"

//platform.h

class platform {

private:
        hgeQuad platQuad;

public:
        platform();
        virtual ~platform();

        float z;
        float x, y;
        hgeRect rect;

        void updateQVert();
        void updateRect();
        void quadRender(HGE* hge);
        void quadTexture( HTEXTURE tex, DWORD col, int blend);
        void move(float x2, float y2);
};

#endif

---

Code:

---

#ifndef CHARACTER_H
#define CHARACTER_H

//character.h
#include "hge.h"
#include "hgerect.h"
#include "console.h"
#include "platform.h"

class character {
       
protected:
        void renderQuad(HGE* hge, hgeQuad* quad);
        void flipLeft(hgeQuad* quad);
        void flipRight(hgeQuad* quad);
        void updateQVert(hgeQuad* quad);

public:
        character();
        virtual ~character();

        enum direction {LEFT, RIGHT, DOWN, UP};
        direction dir;

        virtual void pullDown();
        virtual void stop(HGE* hge, character& c, platform& plat);

        float speed;
        float x, y;
        float z;
        float gravityPull;
        hgeRect charRect;
       
};
#endif

---

That might help?

So then, when someone asks for the definition of platform, you should give them the definition of platform:

Code:

---

class platform {

private:
        hgeQuad platQuad;

public:
        platform();
        virtual ~platform();

        float z;
        float x, y;
        hgeRect rect;

        void updateQVert();
        void updateRect();
        void quadRender(HGE* hge);
        void quadTexture( HTEXTURE tex, DWORD col, int blend);
        void move(float x2, float y2);
};

---

Notice how this is the code that defines platform as a new type, specifically a class, with all the appropriate members.

Both of these functions also need #include <character.h> as well, it looks like. (And just as a wild guess, you need to include the headers before you do the functions, but you've probably got that.) If you have both the headers, then you don't get any errors.

huh o.O? So I'm supposed to include 'platform.h' in platform.h and 'character.h' in character.h o.O?
Well, I tried that and it didn't work...
Or did you mean something else?

Not that this will solve your problem but:

Code:

---

void character::stop(HGE* hge, character& c, platform& plat){
        float dt = hge->Timer_GetDelta();

        if(c.charRect.Intersect(&plat.rect)){
                if(dir == LEFT) x += speed * dt;
                if(dir == RIGHT) x -= speed * dt;
                if(dir == DOWN) y -= gravityPull;
                if(dir == UP) y += speed * dt;
        }
}

---

Are you sure you mean "&plat.rect"? Since plat is passed as a reference "&plat" literally means "the address of plat"

yeah well, before I did that it gave me an compiler error :S

So, did I make the unsolvable error? Or is there some answer? I just really wanna get this fixed, so i can continue to code ;)
and feel free to ask to see more code if that's needed! :)

&plat.rect would actually be the address of plat.rect, so presumably Intersect takes a pointer to an hgeRect.

What I meant was, the file that has the function definitions you're trying to write (you know -- the one with the errors in it?) needs both header files included. You don't include a header file in itself.

You will have to provide more (any) details.

See, this is where some idea about the "design" of the program would come in, like who depends on what, and what services a class provides.

This "everything" includes everything else just ties you in knots of cyclic dependency with no way out.

well all Bazaar users can download my code easily by typing "bzr branch lp:mba" but I don't expect people to be that dedicated to help xP
https://code.launchpad.net/~ian.t.ja...loodshed_Arena That's the url to the project code launchpad site, and if someone uses some other SVN client than Bazaar, I guess it's possible to get the project, I just dunno how xP
But let me show you all the code that has something to do with this problem.

Code:

---

#include "character.h"
#include "platform.h"

character::character(){

}

character::~character(){
}


void character::renderQuad(HGE* hge, hgeQuad* quad){
        hge->Gfx_RenderQuad(quad);

}

void character::flipLeft(hgeQuad* quad){
        quad->v[0].tx = 1.0f; quad->v[0].ty = 0.0f;
        quad->v[1].tx = 0.0f; quad->v[1].ty = 0.0f;
        quad->v[2].tx = 0.0f; quad->v[2].ty = 1.0f;
        quad->v[3].tx = 1.0f; quad->v[3].ty = 1.0f;
}

void character::flipRight(hgeQuad* quad){
        quad->v[0].tx = 0.0f; quad->v[0].ty = 0.0f;
        quad->v[1].tx = 1.0f; quad->v[1].ty = 0.0f;
        quad->v[2].tx = 1.0f; quad->v[2].ty = 1.0f;
        quad->v[3].tx = 0.0f; quad->v[3].ty = 1.0f;
}

void character::updateQVert(hgeQuad* quad){
        quad->v[0].x = x - 16; quad->v[0].y = y - 32;
        quad->v[1].x = x + 16; quad->v[1].y = y - 32;
        quad->v[2].x = x + 16; quad->v[2].y = y + 32;
        quad->v[3].x = x - 16; quad->v[3].y = y + 32;

}

void character::pullDown(){
        y += gravityPull;
        dir = DOWN;
}

void character::stop(HGE* hge, character& c, platform& plat){
        float dt = hge->Timer_GetDelta();

        if(c.charRect.Intersect(&plat.rect)){
                if(dir == LEFT) x += speed * dt;
                if(dir == RIGHT) x -= speed * dt;
                if(dir == DOWN) y -= gravityPull;
                if(dir == UP) y += speed * dt;
        }
}

---

Code:

---

#include "worldManager.h"

worldManager::worldManager(HGE* h){
        hge = h;
}

worldManager::~worldManager(){
}

void worldManager::gravity(character& c){
        c.pullDown();
       
}

void worldManager::chrIntersectPlat(character& c, platform& plat){
        c.stop(hge,c,plat);

}

---

Code:

---

#ifndef WORLDMANAGER_H
#define WORLDMANAGER_H

//worldmanager.h
#include "character.h"
#include "platform.h"

class worldManager {
private:
        HGE* hge;

public:
        worldManager(HGE* h);
        ~worldManager();

        void chrIntersectPlat(character& c, platform& plat);
        void gravity(character& c);

};

---

Code:

---

#include "platform.h"

platform::platform(){

        updateQVert();
        updateRect();

        //class quad texture setup
        platQuad.v[0].tx = 0.0f; platQuad.v[0].ty = 0.0f;
        platQuad.v[1].tx = 1.0f; platQuad.v[1].ty = 0.0f;
        platQuad.v[2].tx = 1.0f; platQuad.v[2].ty = 1.0f;
        platQuad.v[3].tx = 0.0f; platQuad.v[3].ty = 1.0f;

}

platform::~platform(){
}

void platform::updateQVert(){
        platQuad.v[0].x = x; platQuad.v[0].y = y;
        platQuad.v[1].x = x + 32; platQuad.v[1].y = y;
        platQuad.v[2].x = x + 32; platQuad.v[2].y = y + 32;
        platQuad.v[3].x = x; platQuad.v[3].y = y + 32;
}

void platform::quadTexture( HTEXTURE tex, DWORD col, int blend){
        platQuad.tex = tex;
        platQuad.blend = blend;
        for(int i = 0; i < 4; i++){
                platQuad.v[i].col=col;
                platQuad.v[i].z=z;
        }
}

void platform::quadRender(HGE* hge){
        hge->Gfx_RenderQuad(&platQuad);
}

void platform::updateRect(){
        rect.x1 = x; rect.y1 = y;
        rect.x2 = x + 32; rect.y2 = y + 32;

}

void platform::move(float x2, float y2){
        x = x2;
        y = y2;
        updateRect();
        updateQVert();
}

---

That should be it...

Salem, what you talking about? xP
I know my code ain't professional and clean xP but most of it works ;)

Well, I cleaned the code up a load, and now it works ^^
I learnt something from it atleast ;) I must remember to try to keep the code as clean as possible ^^

Quote:

---

Originally Posted by Akkernight

Well, I cleaned the code up a load, and now it works ^^
I learnt something from it atleast ;) I must remember to try to keep the code as clean as possible ^^

---

That's the point of Salem's post: You should DESIGN your classes such that you understand what depends on what.

There are some different ways to come up with a design, many books and even more PhD thesis' have been written on the subject. But the basics of it is pretty simple:
1. Figure out what data and functions you need to have to solve a particular problem (or part of the problem).
2. Figure out how the different data items and functions interact.
3. Make up classes that contain data that belong together, and add functions that "make sense".

It is often best to try to be minimalist in class and function design - but of course, a class/function should add some value to the overall program - if it doesn't, then it's probably "too small".

[Of course, if you read a design class/book, you'll find that it takes 200-500 pages to describe the above, with many examples and a lot more detail - because you wouldn't be able to sell a book that is only half a page! ;) ].

--
Mats

Just hacking the code tops out at about 5K lines. Beyond that, adding new features takes more and more effort, and fixing bugs introduces bugs at an ever increasing rate (to the point every fix is a bug).

You've got the skill for the coding, but you need to develop other skills now to be able to build much larger programs.

Quote:

---

Originally Posted by BMJ

Are you sure you mean "&plat.rect"? Since plat is passed as a reference "&plat" literally means "the address of plat"

---

Actually, it means address of the element rect in plat, because . has higher order of precedence than & in this expression.

--
Mats