why isn't this working

why isn't my program working??

char ch;
int countspace=0;
cout << "Please enter a line of text, ";
cout << "followed by a return: ";
cout << endl;
cin.get(ch);
while (ch == '\n')
{
if (ch == ' ')
countspace++;
if(countspace > 0 && ch != ' ')

ch= toupper(ch);
cout <<ch;
countspace = 0;
}

Quote:

---

Originally posted by archie
why isn't my program working??

char ch;
int countspace=0;
cout << "Please enter a line of text, ";
cout << "followed by a return: ";
cout << endl;
cin.get(ch);
while (ch == '\n')
{
if (ch == ' ')
countspace++;
if(countspace > 0 && ch != ' ')

ch= toupper(ch);
cout <<ch;
countspace = 0;
}

---

You are only calling get() once...therefore it will work for 1 char....not a string......

Also, you would do better to identify the exact problem you have......."This doesnt work" is not very helpful

>>> char ch;

Hint, this statement declares a single character, not a string. You want an array of char.

Ooops, bit of concurrence!

We are not supposed to use arrays or strings only char.

Quote:

---

Originally posted by adrianxw
>>> char ch;

Hint, this statement declares a single character, not a string. You want an array of char.

---

Quote:

---

why isn't my program working??

char ch;
int countspace=0;
cout << "Please enter a line of text, ";
cout << "followed by a return: ";
cout << endl;
cin.get(ch);
while (ch == '\n')
{
if (ch == ' ')
countspace++;
if(countspace > 0 && ch != ' ')

ch= toupper(ch);
cout <<ch;
countspace = 0;
}

---

First, counting spaces isn't safe unless you know what the format of the input will be like, what if I entered a line with each word separated by two spaces? To be safe and simple here is what you do, ask the user to enter a series of words to start, they really should know what to do or the program won't be useful. Use cin.get to read the first character of the input and test if it's a vowel, if it is then change the case to upper.

Go into a loop to check for a newline and test for a space, if it's a space then print one space and loop until you don't have a space, test that for vowel and if it is change the case. If it isn't just print the character. If it's not a space at all, print the character and get a new one, at the end print a newline and you're done.

Code:

---

#include <iostream>
using namespace std;

static int isVowel ( char ch )
{
  ch = toupper ( ch );
  return ( ch=='A'||ch=='E'||ch=='I'||ch=='O'||ch=='U' ) ? 1 : 0;
}

int main ( void )
{
  char ch;
  cout<<"Enter a series of words"<<endl;
  cin.get( ch );
  if ( isVowel ( ch ) ) ch = toupper ( ch );
  while ( ch != '\n' ) {
    if ( isspace ( ch ) ) {
      cout<<" ";
      while ( isspace ( ch ) ) cin.get( ch );
      if ( isVowel ( ch ) ) {
        ch = toupper ( ch );
        cout<<ch;
      }
      else
        cout<<ch;
    }
    else
      cout<<ch;
    cin.get( ch );
  }
  cout<<endl;
  return EXIT_SUCCESS;
}

---

Just in case this is a homework question, you don't want to turn in my code. Teachers know if you didn't write it, so beware :)

-Prelude

Quote:

---

Originally posted by Prelude

First, counting spaces isn't safe unless you know what the format of the input will be like, what if I entered a line with each word separated by two spaces? To be safe and simple here is what you do, ask the user to enter a series of words to start, they really should know what to do or the program won't be useful. Use cin.get to read the first character of the input and test if it's a vowel, if it is then change the case to upper.

Go into a loop to check for a newline and test for a space, if it's a space then print one space and loop until you don't have a space, test that for vowel and if it is change the case. If it isn't just print the character. If it's not a space at all, print the character and get a new one, at the end print a newline and you're done.

Code:

---

#include <iostream>
using namespace std;

static int isVowel ( char ch )
{
  ch = toupper ( ch );
  return ( ch=='A'||ch=='E'||ch=='I'||ch=='O'||ch=='U' ) ? 1 : 0;
}

int main ( void )
{
  char ch;
  cout<<"Enter a series of words"<<endl;
  cin.get( ch );
  if ( isVowel ( ch ) ) ch = toupper ( ch );
  while ( ch != '\n' ) {
    if ( isspace ( ch ) ) {
      cout<<" ";
      while ( isspace ( ch ) ) cin.get( ch );
      if ( isVowel ( ch ) ) {
        ch = toupper ( ch );
        cout<<ch;
      }
      else
        cout<<ch;
    }
    else
      cout<<ch;
    cin.get( ch );
  }
  cout<<endl;
  return EXIT_SUCCESS;
}

---

Just in case this is a homework question, you don't want to turn in my code. Teachers know if you didn't write it, so beware :)

-Prelude

---

Hey Thanka aton,
Just one more question.Instead of using the function isvowel how can i find out if the first character enetered is a vowel??

if((toupper(ch) == 'A') || (toupper(ch) == 'E') || (toupper(ch) == 'I') || (toupper(ch) == 'O') || (toupper(ch) == 'U'))

which is bascially what prelude's function does anyways.