Need help with returning and element of a std::list

I need some help with the logic of a function I have. I simply am trying to return an element of a list...

Code:

---

std::list < Font > m_fontList;

Font &Graphics::GetFont( const std::string &fontName )
{
        std::list< Font >::iterator listIterator;
        // Find the font.
        for( listIterator = m_fontList.begin();
        listIterator != m_fontList.end();
        listIterator++ )
        {
                if( listIterator->GetFontName() == fontName )
                {
                        return *listIterator; //1 is this correct
                }
        }
        // 2 What would the default return value be if the element was not found
}

---

1) am I returning the element correctly via the iterator?

2) What would I do for the default return value?

Regards

Chad

Quote:

---

Originally Posted by chadsxe

1) am I returning the element correctly via the iterator?

2) What would I do for the default return value?

Regards

Chad

---

1) Yes
2)
Whatever you want. You could have a default font, in case it didn't exist. If you don't want it, you'll have to change the function definition to one of two things:
- Return a pointer, where a NULL pointer is returned if the font wasn't found.
- Pass the Font reference as argument and return true if it was found and false if not, eg:

Code:

---

bool Graphics::GetFont( const std::string &fontName, Font &ret )

---

You could also throw an exception if the font you want isn't in the list.