warning: array subscript has type `char'

Hi,

Im getting these warnings when gccing with -Wall

sample-.c: In function `ISls':
sample-.c:214: warning: array subscript has type `char'
sample-.c:218: warning: array subscript has type `char'
sample-.c:227: warning: array subscript has type `char'
sample-.c:229: warning: array subscript has type `char'
sample-.c:236: warning: array subscript has type `char'
sample-.c:255: warning: char format, DIR arg (arg 2)

I've marked the lines in the lode in the left hand side with a /**/

Just give me a pointer to my mistake.

Cheers.

Here,

Code:

---

if( sort[i] != '\0')

---

you are comparing sort[i] (an integer) with a character. Pick one datatype and stick with it.

Here,

Code:

---

if(get_info.st_mode & S_IFDIR) printf("%c[94;1m%s%c[0m", 27, sort [i], 27);

---

sort[i] is still an int, but you are calling it a string.

Your other errors are similar.

EDIT: Well, there exists the possibility that variable i has been defined as a char - but I can't tell for sure, since you must have declared it as a global. If you did declare i as a char, shame on you.

Here is the warning

Code:

---

char *sort[100], i;

---

i should be integer. If it's not the it is probably "casted"/translated to an int. Why you ask? Because inside the [] of the array pointer arithmetic is done. For example

Code:

---

char array[10];
int five = 5;
arr[five ];

---

The compiler will add five to the value of arr, thus *(arr+five ) in order to determine the element. Since arr is a pointer, thus the size of the int (always?) it needs an int.

Just cast it, like arr[(int)i] if you want it a char or ignore the warning, but it is better to cast

AHAA!! Thanks C_ntua - I missed that declaration. Yuk - multiple variable declarations on a single line... shame on you again.

It is best to avoid casts. And by that I mean design code that avoids casts in the first place, because casts usually shuts the compiler up, regardless if it's right or wrong.
So use the compiler to your help - if it warns or complains, think of another solution first, and if you know it is correct, be sure to be very sure, before you add a cast to silence a warning or error.

I think you must have tried to compile something that has already been compiled into something.