getc

Whats wrong with the following:

Code:

---

#include <stdio.h>

int main()
{
        int c, total;  /* declare a char array */
        FILE *file;  /* declare a FILE pointer  */

        file = fopen("test.c", "r");
       
        while((c = getc(file)) != EOF)
        {
                total += c;
        }
        printf("Total is %d\n", total);
}

---

Given test.c contains:

Code:

---

1 2 45

---

The answer i get is not correct.

What result do you expect?
I'd guess that you get 49+32+50+32+52+53 -> 268 - or thereabouts as there may be a space, newline or both at the end of the file.

Did you want to read those numbers as integers, so you get 1 + 2 + 45? If so, you need to use scanf() or some other function that reads the input and converts it to an integer. Right now, you are summing the individual characters with their ascii values, which is of course not the same as adding the numbers together.

--
Mats

total is never initialized to zero.

Quote:

---

Originally Posted by Dino

total is never initialized to zero.

---

Ah, good point, so the result may well be completely rubbish then... ;-)

-
Mats

Code:

---

while( fscanf(file, "%d", &n) != EOF) total += n;

---

This is another way you could do it.

Quote:

---

Originally Posted by blurx

Code:

---

while( fscanf(file, "%d", &n) != EOF) total += n;

---

This is another way you could do it.

---

Yes. However, letting the original poster LEARN by finding the answer him/herself is often a better approach than posting the correction directly - particularly for complete novices (which I assume the original poster is here).

--
Mats