BAH! expected `;' before 'else'

Hi im new, and I bring you my woes for you to comfort me and brighten my day!

The only errors I get when compiling my program are:
pgm4b.cpp: In function 'int main()':
pgm4b.cpp:43: error: expected primary-expression before 'else'
pgm4b.cpp:43: error: expected `;' before 'else'

And I know that the "expected ';' before 'else'" usually has to do with the ill-placement of an ';' after an if() condition before the commands, but nothing as such exists in my code, or atleast any I can find.

The program is supposed to take in user input variables for a hotel

What is the top floor?

then a loop is started and repeats this questions in correlation to the # of floors

how many rooms on that floor?
how many are occupied

Then the program should calculate
How many rooms the hotel has
how many are occupied
how many are empty
and the occupancy % of filled to empty rooms
and the program should skip processing of floor six as the hotel doesn't a floor six or something,
ALSO determine the heart Break floor which is the floor with the least amount of occupied rooms.

Code:

---

// pgm4b.cpp Kyle o'Brien cs201 1:30
#include <iostream>
#include <iomanip>
using namespace std;

int main()
                { // opening block for main

        int tFloor, fRooms, oRooms;
        int tfRooms = 0;
        int toRooms = 0;
        int heartBreakF = 0;
        int heartBreakO = 0;
        int floor = 1;
        int empty;
        double occRate;

        cout << "What is the top floor? " << endl;
        cin >> tFloor;

        if (tFloor >= 1)
                        { // validation
                while(floor <= tFloor)
                                { // floor is acting counter
                        if (floor == 6)  // skipping floor 6
                                floor++;
                        else // skipping floor 6
                cout << "How many rooms on floor " << floor << " ?";
                cout << endl;
                cin >> fRooms;
                cout << "How many of those are occupied? " << endl;
                cin >> oRooms;
                        if(oRooms < oRooms)
                                        { // HeartBreak Checker
                        heartBreakO = oRooms;
                        heartBreakF = floor;
                      }
                tfRooms = tfRooms + fRooms;
                toRooms = toRooms + oRooms;
                floor++;
                } // loop closing

        else    // validation else option

        cout << "Enter a higher value for top Floor" << endl;

        } // validation closing

        occRate = toRooms / tfRooms;
        empty = tfRooms - toRooms;
        cout << fixed;
        cout << "The hotel has a total of " << tfRooms << " rooms";
        cout << endl;
        cout << toRooms << " are occupied" << endl;
        cout << empty << " are empty" << endl;
cout << "The occupancy rate is " << setprecision(1) << occRate << "%" << endl;
cout << "The heartbreak floor is: " << heartBreakF << " with only ";
cout << heartBreakO << " occupied rooms." << endl;

return 0;
}

---

I've tried just removing the else at line 43, and it compiles fine, but when I run it my occRate and heartBreakF and heartBreakO return as 0.

Thanks again in advance!

I think your braces don't match (they didn't count up correclty for me).

I counted four opening and four closing, which one do you see out of place?

From the if(tFloor >=1) to the else, there are three opening and two closing (at least in what you posted).

Wow, thank you very much that took care of the compiling errors!
But unfortunately the occRate and heartBreakF and heartBreakO still return 0...

That's how good indentation helps :). I can tell you are trying to indent, but your way is certainly not common, and even worse, it's inconsistent.

Heh, I'm still relatively new to this "ORG-NIZA-TION" thing, its a wacky concept.

1. When is oRooms < oRooms ever true?
2. Integer division is not the same as floating-point division. If you need floating-point division, you can cast integers to float before dividing.

I'm not looking for division, its to check and see if each loop the users enters a var for oRooms and to see if it is less than the previous oRooms entered. And if it is, store that oRooms literal in a separate variable called heartBreakO and take the floor# the loop is on and store that in the heartBreakF variable. Thats what it is supposed to do anyway.

Quote:

---

occRate = toRooms / tfRooms;

---

So you don't think that's division, eh?

So if you want to compare oRooms with heartBreakO, then why are you comparing oRooms with oRooms?

Quote:

---

occRate = toRooms / tfRooms;

---

Ok! That is meant to divide I was confused. So you want me to take the int variables and change them to float variables?

And I'm comparing oRooms < oRooms to check and see if what the user entered in the previous loop is less than what they entered in this loop, and if true store the lowest oRooms value in heartBreakO and floor that the loop is on in heartBreakF.

Quote:

---

Originally Posted by Chef

Ok! That is meant to divide I was confused. So you want me to take the int variables and change them to float variables?

---

No, you need to cast them to floating-point before the division.

Quote:

---

And I'm comparing oRooms < oRooms to check and see if what the user entered in the previous loop is less than what they entered in this loop, and if true store the lowest oRooms value in heartBreakO and floor that the loop is on in heartBreakF.

---

1. If you want to store the lowest value, then comparing to the most recent value is just plain silly.
2. It is not possible for you to think that oRooms < oRooms would "see if what the user entered in the previous loop is less than what they entered in this loop", for oRooms must obviously mean the same thing on both sides of the < sign.

...ok... your right.... and I fixed that, thank you once again for your grand knowledge.

But I am still confused on floating-point, mainly because i've never dealt with it.
type cast those varaibles above the occRate as floating-point varaibles through the type cast command?

Sorry for the frustration I caused in my glorious void of knowledge and logic. But I did get it to run successfully with your help. Thank you

This is what I get when I properly indent your code...

Code:

---

// pgm4b.cpp Kyle o'Brien cs201 1:30
#include <iostream>
#include <iomanip>
using namespace std;

int main()
{ // opening block for main

        int tFloor, fRooms, oRooms;
        int tfRooms = 0;
        int toRooms = 0;
        int heartBreakF = 0;
        int heartBreakO = 0;
        int floor = 1;
        int empty;
        double occRate;

        cout << "What is the top floor? " << endl;
        cin >> tFloor;

        if (tFloor >= 1)
        { // validation
                while(floor <= tFloor)
                { // floor is acting counter
                        if (floor == 6)  // skipping floor 6
                                floor++;
                        else // skipping floor 6
                                cout << "How many rooms on floor " << floor << " ?";
                        cout << endl;
                        cin >> fRooms;
                        cout << "How many of those are occupied? " << endl;
                        cin >> oRooms;
                        if(oRooms < oRooms)
                        { // HeartBreak Checker
                                heartBreakO = oRooms;
                                heartBreakF = floor;
                        }
                        tfRooms = tfRooms + fRooms;
                        toRooms = toRooms + oRooms;
                        floor++;
                } // loop closing

        else    // validation else option // Oops! Out of place!

                cout << "Enter a higher value for top Floor" << endl;

        } // validation closing

        occRate = toRooms / tfRooms;
        empty = tfRooms - toRooms;
        cout << fixed;
        cout << "The hotel has a total of " << tfRooms << " rooms";
        cout << endl;
        cout << toRooms << " are occupied" << endl;
        cout << empty << " are empty" << endl;
        cout << "The occupancy rate is " << setprecision(1) << occRate << "%" << endl;
        cout << "The heartbreak floor is: " << heartBreakF << " with only ";
        cout << heartBreakO << " occupied rooms." << endl;

        return 0;
}

---

What IDE /editor do you use?

Most editors can automatically fix these things for you. I believe that is where Elysia is going with the last question. IDEs do help fix these things, no question about it, but there is no substitute for coherent indentation techniques being used to begin with.

My classes use puTTy to connect to a unix server, and we create our code in a program called pico. We never even touched on proper code format, first day we started with couts.

Crikey... editing C++ in pico eh? I am glad to not be you.

Quote:

---

Originally Posted by master5001

Crikey... editing C++ in pico eh? I am glad to not be you.

---

<Story to be ignored by anyone with any sense>
When I was a lad in school, our CS lab was linux machines. My programming 1 class (the morning class) was instructed to use emacs; the afternoon class was told to use vi. (They were given like five commands, [esc], i, r, dd, wq, and maybe a couple other things and that was it, and none of us had ever seen linux before.)

The moral of the story for the OP: after you putty in, use emacs. Really.

Edit: I suppose I should mention that emacs doesn't have the nice little command summary at the bottom. I don't remember how easy it is to access the menus from a tty.

I agree. Not that I am a fan of programming using emacs either, but I would take emacs over pico (or vi).