Wm_timer

I would like to call DrawPolygon (hwnd, hdc) in ID_TIMER2 but i dont know how.
I get uninitialized local variable 'hdc' error.

Code:

---

#include <windows.h>
#include <winuser.h>

#define ID_TIMER1    1
#define ID_TIMER2    2


LRESULT CALLBACK WndProc (HWND, UINT, WPARAM, LPARAM) ;

void DrawRectangle (HWND) ;
void DrawEllipse (HWND,HDC) ;
void DrawPolygon (HWND hwnd,HDC hdc) ;
int cxClient, cyClient ;

int WINAPI WinMain (HINSTANCE hInstance, HINSTANCE hPrevInstance,
                    PSTR szCmdLine, int iCmdShow)
{
    static TCHAR szAppName[] = TEXT ("Screensaver") ;
    HWND        hwnd ;
    MSG          msg ;
    WNDCLASS    wndclass ;
   
    wndclass.style        = CS_HREDRAW | CS_VREDRAW ;
    wndclass.lpfnWndProc  = WndProc ;
    wndclass.cbClsExtra    = 0 ;
    wndclass.cbWndExtra    = 0 ;
    wndclass.hInstance    = hInstance ;
    wndclass.hIcon        = LoadIcon (NULL, IDI_APPLICATION) ;
    wndclass.hCursor      = LoadCursor (NULL, IDC_ARROW) ;
    wndclass.hbrBackground = (HBRUSH) GetStockObject (WHITE_BRUSH) ;
    wndclass.lpszMenuName  = NULL ;
    wndclass.lpszClassName = szAppName ;
   
    if (!RegisterClass (&wndclass))
    {
          MessageBox (NULL, TEXT ("Program requires Windows NT!"),
                      szAppName, MB_ICONERROR) ;
          return 0 ;
    }
   
    hwnd = CreateWindow (szAppName, TEXT ("Beeper1 Timer Demo"),
                          WS_OVERLAPPEDWINDOW,
                          CW_USEDEFAULT, CW_USEDEFAULT,
                          CW_USEDEFAULT, CW_USEDEFAULT,
                          NULL, NULL, hInstance, NULL) ;
         
    ShowWindow (hwnd, iCmdShow) ;
    UpdateWindow (hwnd) ;
         
    while (GetMessage (&msg, NULL, 0, 0))
    {
          TranslateMessage (&msg) ;
          DispatchMessage (&msg) ;
    }
    return msg.wParam ;
}

LRESULT CALLBACK WndProc (HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
{
    HBRUSH      hBrush ;
    static BOOL fFlipFlop = FALSE ;
    HDC        hdc ;
    PAINTSTRUCT ps ;
    RECT        rc ;
   
   
    switch (message)
    {
    case WM_SIZE:
          cxClient = LOWORD (lParam) ;
          cyClient = HIWORD (lParam) ;
          return 0 ;
   
    case WM_CREATE:
          SetTimer (hwnd, ID_TIMER1, 2000, NULL) ;
          SetTimer (hwnd, ID_TIMER2, 1000, NULL) ;
          return 0 ;

    case WM_TIMER :
          switch (wParam)
          {
          case ID_TIMER1:
                  fFlipFlop = !fFlipFlop ;
                    InvalidateRect (hwnd, NULL, FALSE) ;
                  break ;
          case ID_TIMER2: 
                  DrawPolygon (hwnd, hdc);
                  break ;
          }
          return 0 ;

    case WM_PAINT :
          hdc = BeginPaint (hwnd, &ps) ;
         
          GetClientRect (hwnd, &rc) ;
          hBrush = CreateSolidBrush (RGB(0,0,0)) ;
          FillRect (hdc, &rc, hBrush) ;
          DrawPolygon (hwnd, hdc);
          fFlipFlop ? DrawRectangle (hwnd) : DrawEllipse (hwnd,hdc) ;
       
          EndPaint (hwnd, &ps) ;
          DeleteObject (hBrush) ;
          return 0 ;
         
    case WM_DESTROY :
          KillTimer (hwnd, 1) ;
          KillTimer (hwnd, 2) ;
          PostQuitMessage (0) ;
          return 0 ;
    }
    return DefWindowProc (hwnd, message, wParam, lParam) ;
}

void DrawRectangle (HWND hwnd)
{
    HBRUSH hBrush ;
    HDC    hdc ;
    RECT  rect ;
   
    if (cxClient == 0 || cyClient == 0)
          return ;
   
    SetRect (&rect, rand () % cxClient, rand () % cyClient, rand () % cxClient, rand () % cyClient) ;
   
    hBrush = CreateSolidBrush ( RGB (rand () % 256, rand () % 256, rand () % 256)) ;
    hdc = GetDC (hwnd) ;
   
    FillRect (hdc, &rect, hBrush) ;
    ReleaseDC (hwnd, hdc) ;
    DeleteObject (hBrush) ;
}   

void DrawEllipse (HWND hwnd,HDC hdc)
{
    HBRUSH hbr = CreateSolidBrush (RGB (rand () % 256, rand () % 256, rand () % 256)) ;
    HBRUSH hOld = (HBRUSH) SelectObject (hdc,hbr);
    Ellipse (hdc, rand () % cxClient, rand () % cyClient, rand () % cxClient, rand () % cyClient) ;
    SelectObject (hdc,hOld) ;
    DeleteObject (hbr) ;
}
void DrawPolygon (HWND hwnd, HDC hdc)
{
    static    POINT points[7] = {{20, 50},{180, 50},{180, 20},{230, 70},
                              {180, 120},{180, 90},{20, 90}};
   
    HBRUSH hbr = CreateSolidBrush (RGB (rand () % 256, rand () % 256, rand () % 256)) ;
    HBRUSH hOld = (HBRUSH) SelectObject (hdc,hbr);
   
    Polygon(hdc, points, 7);
   
    SelectObject (hdc,hOld) ;
    DeleteObject (hbr) ;
}

---

You probably don't want to draw the polygon in the WM_TIMER code itself, but in the WM_PAINT that comes from a InvalidateRect call. Alternatively, you could use a double buffering technique to draw the data off-screen, and then just use the VM_PAINT to copy your off-screen data onto the screen.

The compiler is indeed correct, hdc is in this case not initilalized - you declare it at the top of the function, and the only time it is assigned is in WM_PAINT, when you do BeginPaint. Remember that local variables "disappear" when you leave the function, and are created anew when the function is called next time. WndProc is called when a message is received by your application - it is not "there all the time".

--
Mats

Declare hdc as static.

Code:

---

LRESULT CALLBACK WndProc (HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
{
    HBRUSH      hBrush ;
    static BOOL fFlipFlop = FALSE ;
    static HDC        hdc ;
    PAINTSTRUCT ps ;
    RECT        rc ;

---

Things to consider....

Timer events fire every time period, not once. So you have one timer every second and another firing every 2 secs. (or very similar times)

EndPaint() cleans up the HDC from BeginPaint. It may not be valid to draw to it later. Look at GetDC(NULL) and ReleaseDC.

You are not clearing the background (FillRect() or similar)

I would set the drawing flags in the timer and call for a paint (which would choose the correct shape to draw).

Quote:

---

Originally Posted by BobS0327

Declare hdc as static.

Code:

---

LRESULT CALLBACK WndProc (HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
{
    HBRUSH      hBrush ;
    static BOOL fFlipFlop = FALSE ;
    static HDC        hdc ;
    PAINTSTRUCT ps ;
    RECT        rc ;

---

---

But if you call EndPaint(hdc), the hdc will still not be valid next time around. Nor will it be valid BEFORE the first WM_PAINT [assuming no other changes to the previously posted code].

--
Mats

Thanks for the help everybody!

Quote:

---

I would set the drawing flags in the timer and call for a paint (which would choose the correct shape to draw).

---

I dont know how to do it so i'm trying to look into the double buffering technique instead.

I found this tutorial already http://www.codeproject.com/KB/cpp/DoubleBuffering.aspx

PS How could this be possible that the program compiles with 0 error 0 warning but won't execute.
VC++ 2008

Quote:

---

Originally Posted by Ducky

PS How could this be possible that the program compiles with 0 error 0 warning but won't execute.
VC++ 2008

---

Well, there are plenty of examples of code that compiles well but doesn't do what you wanted - unfortunately, the compiler can't know what you want the code to achieve - if you really want to write to random addresses in memory, divide by zero or some such, then that is your choice. The compiler will give errors for things that it KNOWS is impossible to achieve, but that is not a complete list of all that can go wrong.

--
Mats

Makes sense, thanks Matsp!

I will try to understand the code.

Well what i see in this program is that he calls functions in WM_TIMER and not in WM_PAINT. And you told me above not to call drawing function in WM_TIMER.

He also put a TODO in WM_PAINT, so maybe i should put some code there?

Code:

---

case WM_TIMER:
                {
                  //controls growth of the ellipse
                  if (growth > 50 || growth < 0)
                          addition *= -1;
                  growth += addition;

                if(double_buffer == true)
                        Draw_With_Buffering();
                else
                        Draw_Without_Buffering(hWnd);
                }
        break;

        case WM_PAINT:
                hdc = BeginPaint(hWnd, &ps);
                // TODO: F&#252;gen Sie hier den Zeichnungscode hinzu...
                EndPaint(hWnd, &ps);
                break;

---

http://www.turboupload.com/files/get...ource-code.zip

Quote:

---

Originally Posted by Ducky

Thanks for the help everybody!


I dont know how to do it so i'm trying to look into the double buffering technique instead.

I found this tutorial already http://www.codeproject.com/KB/cpp/DoubleBuffering.aspx

PS How could this be possible that the program compiles with 0 error 0 warning but won't execute.
VC++ 2008

---

The project is missing a resource file which is causing the above issue. I recreated the resource file based upon my interpretation of the author's code. The author's code along with the resource file is at this link. The download has a comp.bat batch file that I used to compile the project with a MS compiler.

Thanks a million Bob, im very grateful for this.

I managed to compile it with VC++ 6.0 but not with VC++ 2008 free version.
It must have some limitations resource files i guess.

Now i can play around with the program. Its much easier to learn that way for me.

The thing to know is that you have to do things in a slightly roundabout way. When you get your WM_TIMER messaege you don't just paint. Instead you ask the system to tell you to paint, via InvalidateRect for example.

I would like to make this http://www.turboupload.com/files/get...dbuffering.zip (same as above) double buffering program to be displayed in full screen.

I guess i should call GetClientRect (hWnd, &rect) ;.
But the program is first being loaded in the buffer you dont have a client area.

So i thought about to put GetClientRect (hWnd, &rect) ; in the
void Bitmap_Operations::Copy_to_Screen(int which) function.

But its not working either.

Quote:

---

Originally Posted by Ducky

I would like to make this http://www.turboupload.com/files/get...dbuffering.zip (same as above) double buffering program to be displayed in full screen.

I guess i should call GetClientRect (hWnd, &rect) ;.
But the program is first being loaded in the buffer you dont have a client area.

So i thought about to put GetClientRect (hWnd, &rect) ; in the
void Bitmap_Operations::Copy_to_Screen(int which) function.

But its not working either.

---

Unfortunately, this would require a update to the author's code because he calls Initialize_Buffers in WM_CREATE which stores the windows RECT coordinates. So, even if you maximized the client window, the double buffering would only take place in the original window RECT coordinates. Thus, when you resized or maximized the client window, you'll also have to somehow reinitialize the RECT coordinates in dc_rect to the new client window RECT coordinates. A starting point would be to add another function to the class called ReInitialize_Buffers which would update dc_rect to the new client RECT coordinates.

EDIT: I've updated the code to handle resizing, mazimizing of the window. I don't want to do all your work for you. So, you'll have to figure out how to adjust the buffering to keep the ellipse totally in the client window. The new link

Thank you Bob, highly appreciated.

I put myself to it...

Ok first, to do all this i saw that you had to create and add the

Code:

---

ClientResize(hWnd, rect.right, rect.bottom)

---

function.
I never would have found it out by myself and i never thought it would be that complicated to resize a program. Ive learned a big deal thanks to you!

Secondly to adjust the buffering to keep the ellipse totally in the client window i just adjusted the ellipse coordinates by the growth value checked in WM_TIMER

Code:

---

if (growth > 50 || growth < 0)

---

I hope this is what you meant.

Code:

---

Ellipse(biop->Get_DC_Buffer(0), (left/2) + growth, ((top/2)+50) - growth, right - growth, (bottom-50) + growth);

---

I was thinking more along the lines of:

Code:

---

case WM_SIZE:
          GetClientRect(hWnd,&rect);
         
        biop->ReInitialize_BufferRECT(hWnd,1);
        biop->Free_Buffer(0);
        biop->Create_Buffer(0);//(B)
        left = rect.left;
        top = rect.top + 50;       
        right = rect.right ;
        bottom = rect.bottom - 50 ;       
        ClientResize(hWnd, rect.right,  rect.bottom);
        break;

---

as opposed to:

Code:

---

Ellipse(biop->Get_DC_Buffer(0), (left/2) + growth, ((top/2)+50) - growth, right - growth, (bottom-50) + growth);

---

True, its much easier that way.

I didnt think that we could change the RECT values in WM_SIZE too.

Ok now i understand how double buffering is working but i dont see how could this help me to
solve my original problem. That is to call 2 SetTimer functions with 2 different intervales.

Even using double buffering wont change the fact that it will invalidate the whole client area everytime the functions are called.

What i would need is a function to invalidate and repaint only a certain space in the client area.

I dont know if its possible in GDI or maybe i need DirectX for this?

Quote:

---

Originally Posted by Ducky

What i would need is a function to invalidate and repaint only a certain space in the client area.

---

See InvalidateRect, second parameter (lpRect)
http://msdn.microsoft.com/en-us/library/ms534893.aspx

Cool, thanks manuell!

Follow the InvalidateRect() with an UpdateWindow(), is faster.