Fix Please

Okay i can't fix it with the limited knowledge i have... please someone help

Code:

---

#include <iostream>

using namespace std;

int main()
{
    int number;
    cout<<"Wecome to the attempted C++ \n Press enter to continue.";
    cin.get();
   
    cout<<"Choose a number from 1 to 10 and \n you will be rewarded if you guess correctly.";
    cin>> number;
    cin.ignore();
   
    if (number)!(1&&2); { cout<<"Try again!";
    }
   
    else if (number<2); {cout<< "You win ....";
    cin.get();
    cout<<"Nothing.";}
    cin.get();
}

---

errors
E:\Programs\Programing\Programs\Guessing Game.cpp: In function `int main()':
E:\Programs\Programing\Programs\Guessing Game.cpp:18: error: expected primary-expression before "else"
E:\Programs\Programing\Programs\Guessing Game.cpp:18: error: expected `;' before "else"

Execution terminated

>> if (number)!(1&&2);
This line has a syntactic error and a semantic error. Lookup how to use && in your book/tutorial and pay attention to the difference between the example and your code. Then lookup the syntax for the if /else if statements.

Daved, that not the error that the compiler found but i fixed what you said,

what do i do with the "else if" cause i can't understand what i'm missing

Code:

---

#include <iostream>

using namespace std;

int main()
{
    int number;
    cout<<"Wecome to the attempted C++ \n Press enter to continue.";
    cin.get();
   
    cout<<"Choose a number from 1 to 10 and \n you will be rewarded if you guess correctly.";
    cin>> number;
    cin.ignore();
   
    if (number)!(1||2); { cout<<"Try again!";
    }
   
    else if(0<number<2); {cout<< "You win ....";
    cin.get();
    cout<<"Nothing.";}
   
    else {cout<<"Between 1 and 10 please"; }
    cin.get();
}

---

This entire snippet is wrong (not to mention confusing):

Code:

---

    if (number)!(1||2); { cout<<"Try again!";
    }
   
    else if(0<number<2); {cout<< "You win ....";
    cin.get();
    cout<<"Nothing.";}
   
    else {cout<<"Between 1 and 10 please"; }

---

Look up ifs. You are doing them wrong, wrong, wrong, wrong.

hehe wow you're great, you will be a great parent!
:)

I don't know if that's supposed to be a compliment or a sarcastic response... :confused:

Code:

---

if( condition )
{ // these are optional if only one statement follows.
    dosomething;
}
else if( condition )
    dosomething;
else
    dosomething;

---

in your case :

Code:

---

if (number)!(1||2);

---

This doesn't conform to the above. Your if condition must be contained in ( )'s. There should NOT be a ';' after the if statement.

While we're at it, this will only cause readability problems:

Code:

---

    else if(0<number<2) {cout<< "You win ....";
    cin.get();
    cout<<"Nothing.";}

---

Better version:

Code:

---

else if(0<number<2)
{
    cout<< "You win ....";
    cin.get();
    cout<<"Nothing.";
}

---

Or:

Code:

---

else if(0<number<2) {
    cout<< "You win ....";
    cin.get();
    cout<<"Nothing.";
}

---

I solved it :) YES!!!!!!!!!!! Thanks Elysia, can you by anychance add me on msn? ([email protected])

Try out this sick game.
I could sell this on the Black market :O :) :P

Code:

---

#include <iostream>

using namespace std;

int main()
{
    int number;
    cout<<"Wecome to the attempted C++ \n Press enter to continue.";
    cin.get();
   
    cout<<"Choose a number from 1 to 10 and \n you will be rewarded if you guess correctly.";
    cin>> number;
    cin.ignore();
   
    if (!(1||2)) { cout<<"Try again!";
    }
   
    else if(number>0 && number<2) {cout<< "You win ....\n...Nothing";}
   
    else {
        cout<<"Between 1 and 10 please"; }
    cin.get();
}

---

I'm not sure this one is correct:
if (!(1||2))
And I'm not sure your logic for the entire if is correct either...
Should it not be something along the lines of:

if number < 1 or number > 10 Error
if number == 1 you win
Otherwise you lose.

?

if (!(1||2))
This is always false. Use the equality operator and actually make a comparison with your number.

if (number>0 && number<2)
While not as straight forward, it's right. The only number more than zero and less than two is one. It's also lame, because the game cheats. Use random numbers from a generator, Nestor.

Care to explain a few things?

What is the condition !(1 || 2) supposed to check? (Or, do you think it is meaningful to write code that will never be executed?)

How exactly do you know in the final else part that the input was not between 1 and 10? Or is this program annoying on purpose?

Okay let me explain to you my logic, when you play a game the better the ods the more you want to play it, that basically it, but you are right, it should be one number only.

You catch all mistakes :P

anon i swear i burst out laughing when i read what you wrote haha "is this program supposed to be annoying" HAHAHAHHAHAHAHA!
good one

Quote:

---

Originally Posted by citizen

if (!(1||2))
This is always false. Use the equality operator and actually make a comparison with your number.

if (number>0 && number<2)
While not as straight forward, it's right. The only number more than zero and less than two is one. It's also lame, because the game cheats. Use random numbers from a generator, Nestor.

---

Listem men, i started programing yesterday....well today 1 am, i havn't gotten as far as a random numbers generator:P but if you are bored you can explain how it can be a random number generator if the computer can't think for itself?

Usually, it means you give the computer a start number, then it applies an algorithm on that number to produce "random" numbers.
Of course, there are "random" generators and not-so-random generators (not-so-random generators may produce the exact same sequence of numbers from the same seed).

Well actually, you can get a pseudorandom number algorithmically by multiplying a seed with a constant and taking the mod of another constant. I'll show you one:

Code:

---

int seed=1;

void LCGseed (unsigned int _seed)
{
  int i, h=1;
  unsigned char *p=&_seed;
  for (i=0; i < sizeof _seed; h++) {
      h = h>>24 * h<<4 ^ p[i];
  }
  seed=h;
}

int LCGrand (void)
{
  return seed*=16807UL &#37; 2147483647UL;
}

---

The algorithm, when called several times, naturally produces a series called a period. Large periods are good, but more important is the factor of unpredictability. We shouldn't rely on the default seed because that would make the generator more predictable and the result very deterministic. The seed is actually the last number the generator returned. If you're using the generator for the first time, it would be a good idea to set the seed somewhere in the period to start off from other than the default value, using a unique source, like the time.

The example is actually a great deal similar to the rand/srand generator provided by C++, and that's not a very good one. But it's a place to start. You can learn more about PRNGs on the web.

Quote:

---

Originally Posted by Nestor

Listem men, i started programing yesterday....well today 1 am, i havn't gotten as far as a random numbers generator:P but if you are bored you can explain how it can be a random number generator if the computer can't think for itself?

---

since you asked...

http://cboard.cprogramming.com/showthread.php?t=103889

for through understanding, read till the last page. :D

That link doesn't work :(

It's got an extra http// in it by mistake. Delete that in the address bar and you can follow it.

Go back to tutorials. In my opinion Cprogramming tutorials suck so find a better online tutorial, buy a book, or just stop posting such stupid threads

And you'd better learn to control that attitude of yours, because frankly, it sucks.

Me? Was that to me?

No, to lruc.
Nothing wrong with you, Nestor. Don't worry.