If else problem

I am using a book called "C++: A Dialogue" in order to learn the language. I am stuck on the following code:

Code:

---

#include <iostream>
using namespace std;
int main()
{
short balance;
cout << "Please enter your bank balance: ";
cin >> balance;
if (balance < 10000)
cout << "Please remit $20 service charge." << endl;
else
cout << "Have a nice day!" << endl;
return 0;
}

---

I cannot get the compiled program to go beyond input after it says "please enter your bank balance". After I imput a number and press enter, the program simply closes. Can anyone tell me what I am doing wrong?

It works for me with MinGW/GCC 3.4.5. What compiler are you using?

I am using Bloodshed Dev-C++ 4.9.9.2.

http://faq.cprogramming.com/cgi-bin/...&id=1043284385

I tried using

Code:

---

cin.get();

---

in order to keep it open, but it still did not work for me.

Quote:

---

Originally Posted by darkfaust

I tried using

Code:

---

cin.get();

---

in order to keep it open, but it still did not work for me.

---

Put in a second one. After you type enter after entering the balance, the newline character is left in the input stream. The first cin.get() will read that one and the program will then keep going... which means it still ends. So, put in a second one right after the first and that one will block/wait for input.

Thanks hk_mp5kpdw, that solved the problem. Thanks to everyone for the help.

You could try indenting a bit better, you know... Surely, the book's code itself must be indented.

another way

Code:

---

std::cin.get();
std::cin.ignore();

---

:)

Quote:

---

another way

---

Actually, those statements should be swapped.

Actually, the FAQ might show more "correct" ways: there is no guarantee that only one character is left in cin (e.g user might type "102 lalalalala").

Or simply make it a habit to run the program from a command window (where such code to keep the window "open" only becomes an annoyance).

Or set a breakpoint at the end of the program and run in debug mode or use a special run such as Visual Studio's Ctrl+F5.
There are many ways... Running from the command line is not what everyone might like or understand.

But otherwise, the STL has functions to eat whitespace. So eating all whitespace and then doing cin.get() should cause the prompt to pause.

I always prefer my writing my own pausing mechanism like:

Code:

---

std::cout << "Press [Enter] to continue...";
std::cin.ignore( 256, '\n' );

---

Though due to the stream buffer you might have to hit enter twice, but it's better than system("open the gates of h3ll!");

aaaahhh people, just work with Linux! no disappearing output screens, no breakpoints, no ignores or whatsoever, just a nice, fail proof, wysiRwyg*, terminal....

* what you see is REALLY what you get

Quote:

---

Originally Posted by MarkZWEERS

aaaahhh people, just work with Linux! no disappearing output screens, no breakpoints, no ignores or whatsoever, just a nice, fail proof, wysiRwyg*, terminal....

* what you see is REALLY what you get

---

Actually, if you run a console program from an IDE in Linux, I'm pretty sure it disappears too [assuming the IDE doesn't perform some "magic" to prevent that]. Which turns your argument into "just use command line" - which is far enough except modern programmers don't know how... ;-)

--
Mats

Quote:

---

Originally Posted by MarkZWEERS

aaaahhh people, just work with Linux! no disappearing output screens, no breakpoints, no ignores or whatsoever, just a nice, fail proof, wysiRwyg*, terminal....

* what you see is REALLY what you get

---

You will face criticism on that ;)

Quote:

---

Originally Posted by MarkZWEERS

aaaahhh people, just work with Linux! no disappearing output screens, no breakpoints, no ignores or whatsoever, just a nice, fail proof, wysiRwyg*, terminal....

* what you see is REALLY what you get

---

An even better way: get rid of the console altogether along with the command prompt. Then you won't have to worry about disappearing windows.

Quote:

---

Originally Posted by abh!shek

You will face criticism on that ;)

---

You said it XD

The real problem here is Dev-C++. Use Code::Blocks or Visual Studio Express instead. Their developers are not so beset by terminal stupidity that they managed to miss a bug every single newbie ever has encountered for the entire lifespan of the application.

Quote:

---

Originally Posted by Elysia

An even better way: get rid of the console altogether along with the command prompt. Then you won't have to worry about disappearing windows.

---

No, you would still have an output window, whether it is the console or not, and that would have to be closed at program end. Besides, getting rid of the console just because it gets out of your way when it's finished is just stupid, IMO, assuming you're talking about getting rid of it in the system.

Quote:

---

Originally Posted by robwhit

No, you would still have an output window, whether it is the console or not, and that would have to be closed at program end.

---

But aside from console windows, though, pretty much every windows programmer knows that they must run a message loop or the window will be frozen. So I classify it as quite different from a console window. Don't know if anyone agrees, but oh well.

Quote:

---

Besides, getting rid of the console just because it gets out of your way when it's finished is just stupid, IMO, assuming you're talking about getting rid of it in the system.

---

Nah, no. It has its uses. But not using the prompt for running the applications is what I mean!

I think the best solution would be something like what CornedBee was talking about: have an option in the IDE to keep the console open, and have that default to yes.