comma at end of intialization list

If we have a piece of code like this:

Code:

---

int arr[] =
{
  1,
  2,
#if SOMETHING
  3,
#endif
#if SOMEOTHER
  4
#endif
};

---

there is a dangling comma after 2 if SOMETHING and SOMEOTHER is false, or after 3 if SOMETHING is true, but SOMEOTHER is false.

Is this valid in the current standard of C++?

[The compilers I've used accepts it - so it's more a question of "are we allowed to do this".]

--
Mats

Yes, it is permitted by the C++ Standard.

I think your example case, and the case of auto-generated code are the reason why this sort of code is allowed. Sadly, 99% of my code almost always has it there just in case I need to add or subtract from an array on the fly.

Actually, in my particular case I was trying to fix a bug where the code wouldn't compile with this:

Code:

---

  1,
  2,
#if SOMETHING
  3
#endif
#if SOMEOTHER
  ,
  4
#endif

---

when "SOMETHING" wasn't true, and I don't really want to break the code by introducing something that won't compile when using a "strict standard" compiler - and I didn't want to introduce an #else branch.

--
Mats

I always use an "extra" comma at the end of such lists, but in case you absolutely want a minimal amount of commas you could try something like this:

Code:

---

int arr[] =
{
  1
  ,2
#if SOMETHING
  ,3
#endif
#if SOMEOTHER
  ,4
#endif
};

---

A bit odd, but hey - the choice is yours :)

Quote:

---

Originally Posted by Magos

Code:

---

int arr[] =
{
  1
  ,2
#if SOMETHING
  ,3
#endif
#if SOMEOTHER
  ,4
#endif
};

---

---

For reasons of which I am no longer aware, I have always done it this way.

Quote:

---

Originally Posted by matsp

If we have a piece of code like this:

Code:

---

int arr[] =
{
  1,
  2,
#if SOMETHING
  3,
#endif
#if SOMEOTHER
  4
#endif
};

---

there is a dangling comma after 2 if SOMETHING and SOMEOTHER is false, or after 3 if SOMETHING is true, but SOMEOTHER is false.

Is this valid in the current standard of C++?

[The compilers I've used accepts it - so it's more a question of "are we allowed to do this".]

--
Mats

---

Yep, it's perfectly allowable, though often rather unexpectedly to many people. I always use the extra comma. It makes a few things easier. E.g. when you add another line to it then because you don't need to add a comma to the previous line then the change shows up as only an addition of one line in differencing programs like WinMerge.
Then when it comes to constructor initialisation lists, doing the same thing is not allowed. Some times you gotta love the inconsistencies of C++.