Polymorphism Help

I have a base class tree. Using this class, I have to create two derived classes, oak and pine.

Here is the base class tree:

Code:

---

#ifndef TREE_H
#define TREE_H

//Tree class declaration

#include<iostream>
using namespace std;

#define dead 0
#define live 1
#define burning 2
#define newt 3

class tree
{
  protected:
    string type;
    double probCatch;
    int status;
    double wetness;
    int burnTime;

  public:
    tree();  //default constructor
    tree(string t, double prob, int stat, double wet, int burn); //constructor
    double getProbCatch() const; //accessor
    void setProbCatch(double prob); //mutator
    int getStatus() const;
    void setStatus(int stat);
    double getWetness() const;
    void setWetness(double wet);
    int getBurnTime() const;
    void setBurnTime(int burn);
    ostream& showSymbol(ostream& out);

  friend ostream& operator<<(ostream& out, tree&  a);
};
#endif //TREE_H

---

Code:

---

#include <iostream>
#include <iomanip>
#include <string>
#include <cstdlib>
#include "tree.h"
#include "oak.h"
#include "pine.h"
using namespace std;


//-------------------------------------------------------------------------
//Default Tree Constructor
//-------------------------------------------------------------------------

tree::tree(): type("not_a_tree"), probCatch(0), status(dead), wetness(1), burnTime(1)
{
  //empty body; initialization
}

//-------------------------------------------------------------------------
//Tree Constructor
//-------------------------------------------------------------------------

tree::tree(string t, double prob, int stat, double wet, int burn): type(t), probCatch(prob), status(stat), wetness(wet), burnTime(burn)
{
  //empty body; intialization
}

//-------------------------------------------------------------------------
//Fetching Probability
//-------------------------------------------------------------------------

double tree::getProbCatch() const
{
  return probCatch;
}

//-------------------------------------------------------------------------
//Setting Probability
//-------------------------------------------------------------------------

void tree::setProbCatch(double prob)
{
  probCatch=prob;
}

//-------------------------------------------------------------------------
//Fetching Status
//-------------------------------------------------------------------------

int tree::getStatus() const
{
  return status;
}

//-------------------------------------------------------------------------
//Setting Status
//-------------------------------------------------------------------------

void tree::setStatus(int stat)
{
  status=stat;
}

//-------------------------------------------------------------------------
//Fetching Wetness
//-------------------------------------------------------------------------

double tree::getWetness() const
{
  return wetness;
}

//-------------------------------------------------------------------------
//Setting Wetness
//-------------------------------------------------------------------------

void tree::setWetness(double wet)
{
  wetness=wet;
}

//-------------------------------------------------------------------------
//Fetching Burn Time
//-------------------------------------------------------------------------

int tree::getBurnTime() const
{
  return burnTime;
}

//-------------------------------------------------------------------------
//Setting Burn Time
//-------------------------------------------------------------------------

void tree::setBurnTime(int burn)
{
  burnTime=burn;
}

//-------------------------------------------------------------------------
//Overloading Output <<
//-------------------------------------------------------------------------

ostream& operator<<(ostream& out, tree&  a)
{
  out << "Species: "<< a.type <<endl;
  out << "Probability: "<< a.probCatch <<endl;
  out << "Status: "<< a.status <<endl;
  out << "Wetness: "<< a.wetness <<endl;
  out << "Burn time: "<< a.burnTime <<endl;

  return out;
}

//-------------------------------------------------------------------------
//Show Symbols
//-------------------------------------------------------------------------

ostream& tree::showSymbol(ostream& out)
{
  out<<"\033[32;40m!"<<endl;
 
 return out;
}

---

Here is the oak class:

Code:

---

//Oak class declaration

#include "tree.h"
#include<iostream>
using namespace std;

#define dead 0
#define live 1
#define burning 2
#define newt 3

class oak : public tree
{
  public:
    oak();  //default constructor
    oak(string t, double prob, int stat, double wet, int burn); //constructor
    ostream& showSymbol(ostream& out);

  friend ostream& operator<<(ostream& out, tree&  a);
};

---

Code:

---

#include <string>
#include <cstdlib>
#include "oak.h"
#include "tree.h"
using namespace std;


//-------------------------------------------------------------------------
//Default Tree Constructor
//-------------------------------------------------------------------------

oak::oak(): type("not_a_tree"), probCatch(0), status(dead), wetness(1), burnTime(1)
{
  //empty body; initialization
}

//-------------------------------------------------------------------------
//Tree Constructor
//-------------------------------------------------------------------------

oak::oak(string t, double prob, int stat, double wet, int burn): type(t), probCatch(prob), status(stat), wetness(wet), burnTime(burn)
{
  //empty body; intialization
}

//-------------------------------------------------------------------------
//Show Symbols
//-------------------------------------------------------------------------

ostream& oak::showSymbol(ostream& out)
{
  out<<"\033[32;40m@"<<endl;
 
 return out;
}

---

The pine class is the same as the oak class except for the symbol.

I'm getting the following errors when it compiles:

Code:

---

oak.cpp: In constructor ‘oak::oak()’:
oak.cpp:14: error: class ‘oak’ does not have any field named ‘type’
oak.cpp:14: error: class ‘oak’ does not have any field named ‘probCatch’
oak.cpp:14: error: class ‘oak’ does not have any field named ‘status’
oak.cpp:14: error: class ‘oak’ does not have any field named ‘wetness’
oak.cpp:14: error: class ‘oak’ does not have any field named ‘burnTime’
oak.cpp: In constructor ‘oak::oak(std::string, double, int, double, int)’:
oak.cpp:23: error: class ‘oak’ does not have any field named ‘type’
oak.cpp:23: error: class ‘oak’ does not have any field named ‘probCatch’
oak.cpp:23: error: class ‘oak’ does not have any field named ‘status’
oak.cpp:23: error: class ‘oak’ does not have any field named ‘wetness’
oak.cpp:23: error: class ‘oak’ does not have any field named ‘burnTime’
pine.cpp: In constructor ‘pine::pine()’:
pine.cpp:13: error: class ‘pine’ does not have any field named ‘type’
pine.cpp:13: error: class ‘pine’ does not have any field named ‘probCatch’
pine.cpp:13: error: class ‘pine’ does not have any field named ‘status’
pine.cpp:13: error: class ‘pine’ does not have any field named ‘wetness’
pine.cpp:13: error: class ‘pine’ does not have any field named ‘burnTime’
pine.cpp: In constructor ‘pine::pine(std::string, double, int, double, int)’:
pine.cpp:22: error: class ‘pine’ does not have any field named ‘type’
pine.cpp:22: error: class ‘pine’ does not have any field named ‘probCatch’
pine.cpp:22: error: class ‘pine’ does not have any field named ‘status’
pine.cpp:22: error: class ‘pine’ does not have any field named ‘wetness’
pine.cpp:22: error: class ‘pine’ does not have any field named ‘burnTime’

---

This is my first time doing polymorhpism and I'm not sure how to do it. I'm making some mistakes that are messing up the program and I can't catch them. Please help me if you can.

Ok, according to the instructions, I have to create a base class pointer named treePtr that points to a tree object. Then that in turn will assign the address of each object to treePtr and call showSymbol() using:

Code:

---

(*treePtr).showSymbol(cout);

---

or

Code:

---

treePtr->showSymbol(cout);

---

I haven't done pointers before either. Can someone help me with creating one or give me links to sites that may help.

Thanks a bunch!
Ryan

What book are you using? I didn't read very much of the post, just the title and the fact that your base class doesn't have any virtual functions.

I think you need a good C++ book.

The problem is not with an attempt to use polymorphism per se. The problem is that type, probCatch, status, wetness and burnTime are member variables from the base class (tree), so they cannot be initialised in the derived class (oak). You can assign to them in the body of the constructor since they are declared protected, but it would be more efficient to invoke the base class constructor from the initialisation list of the derived class constructor:

Code:

---

oak::oak(): tree("not_a_tree", 0, dead, 1.0, 1)
{
  //empty body; initialization
}

---

This would still work even if those member variables were private (and I find it better to make them private).

However, you do have an issue where polymorphism is concerned: namely, your base class has no virtual member functions (in particular, its destructor is not virtual), thus tree is not a polymorphic base class to begin with.

Thank you laserlight! That definitely helps.

That would take care of the default constructor for the classes, but how would I go about adding a constructor with parameters in the oak and pine class?


The whole project I'm working on right now uses both polymorphism and inheritance. Right now I'm just working with the tree and derived tree classes. After this I have to add them to my forest class and create a forest destructor.

Quote:

---

That would take care of the default constructor for the classes, but how would I go about adding a constructor with parameters in the oak and pine class?

---

The same way, of course. You just use the arguments instead.

Quote:

---

The whole project I'm working on right now uses both polymorphism and inheritance. Right now I'm just working with the tree and derived tree classes.

---

We're saying that you are using inheritance without the possibility of polymorphism. If your tree class is to be a proper polymorphic base class, it must have at least one virtual member function, and its destructor should be virtual.

Ok, I needed to call the original tree constructor with parameters. It works now.

I should have reworded my last statement. Right now I'm only working on the Inheritance part, but when apply these new classes in the forest class, I will have to use polymorphism.

However, I still don't know how to create a base class pointer, which I mentioned in an earlier post.

Thanks a bunch!
Ryan

Quote:

---

I should have reworded my last statement. Right now I'm only working on the Inheritance part, but when apply these new classes in the forest class, I will have to use polymorphism.

---

Before you even involve the forest class, you should already decide on what member functions should be virtual. In other words, you need to ask yourself: what kind of behaviour do all trees have? Of these kinds of behaviour, what should be fixed for all trees (i.e., they should be non-virtual member functions), and what should be allowed to vary for specific types of trees (i.e., they should be virtual member functions)?

Quote:

---

However, I still don't know how to create a base class pointer, which I mentioned in an earlier post.

---

The base class is named tree. A pointer to an object of type T is itself of type T*. Therefore, you would create a base class pointer with:

Code:

---

tree* tree_ptr;

---

I created the tree pointer like so:

Code:

---

tree *treePtr;

treePtr=&a;

(*treePtr).showSymbol(cout);

b.showSymbol(cout);

c.showSymbol(cout);

---

However, I now have to go to my forest class and change the grid[21][21] to a grid of tree pointers. I don't feel that my tree pointer is right for what I need to do.

Quote:

---

However, I now have to go to my forest class and change the grid[21][21] to a grid of tree pointers. I don't feel that my tree pointer is right for what I need to do.

---

That's the correct thing to do. In C++, polymorphism works through pointers and references.

Incidentally,

Code:

---

(*treePtr).showSymbol(cout);

---

may be replaced with this syntactic sugar:

Code:

---

treePtr->showSymbol(cout);

---

Your header files have using namespace std; in them which should be avoided (explicitly qualify all std objects with std::).

The headers also lack a #include <string> statement for the string objects declared within. Right now, your code (may) compile because you just so happen to #include <string> in your source files before you happen to include the relevant header but if for some reason you switch around the order of the #include statements and put #include <tree.h> before #include <string> for example you might find yourself scratching your head at why things suddenly don't compile like they used to.

This is an intro c++ course and they explicitly tell us to use "using namespace std".

Ok, everything is going well, but I'm having trouble with my destructor for my forest class:

Code:

---

//-------------------------------------------------------------------------
//Default Forest Constructor
//-------------------------------------------------------------------------

forest::forest()
{
tree notree("not_a_tree", 0.0, dead, 1.0, 1);
tree a("maple", 0.8, live, 1.0, 1);
tree burnt("burnt", 0, burning, 1.0, 1);
 
  for(int i=0; i<21; i++){
      for(int j=0; j<21; j++){

            if ( i == 0 || i == 20 || j == 0 || j == 20 ) {
           
              (*grid[i][j]) = notree ;
            }
            else {
              (*grid[i][j]) = a;
            }
        }
  }
}

//-------------------------------------------------------------------------
//Default Forest Destructor
//-------------------------------------------------------------------------

forest::~forest();
{
  for(int i=0; i<21; i++){
      for(int j=0; j<21; j++){
     
        if(grid[i][j]){

            delete grid[i][j];
            grid[i][j]=NULL;
        }
      }
  }
}

---

However, this isn't working.
Here is the compiler error:

Code:

---

forest.cpp:39: error: declaration of ‘forest::~forest()’ outside of class is not definition
forest.cpp:40: error: expected unqualified-id before ‘{’ token

---

Thanks a bunch!
Ryan

Ok, everything is going well, but I'm having trouble with my destructor for my forest class:

Code:

---

//-------------------------------------------------------------------------
//Default Forest Constructor
//-------------------------------------------------------------------------

forest::forest()
{
tree notree("not_a_tree", 0.0, dead, 1.0, 1);
tree a("maple", 0.8, live, 1.0, 1);
tree burnt("burnt", 0, burning, 1.0, 1);
 
  for(int i=0; i<21; i++){
      for(int j=0; j<21; j++){

            if ( i == 0 || i == 20 || j == 0 || j == 20 ) {
           
              (*grid[i][j]) = notree ;
            }
            else {
              (*grid[i][j]) = a;
            }
        }
  }
}

//-------------------------------------------------------------------------
//Default Forest Destructor
//-------------------------------------------------------------------------

forest::~forest();
{
  for(int i=0; i<21; i++){
      for(int j=0; j<21; j++){
     
        if(grid[i][j]){

            delete grid[i][j];
            grid[i][j]=NULL;
        }
      }
  }
}

---

However, this isn't working.

The error sounds like it is coming because you didn't declare the destructor in the header file.

I'm curious about your delete in the destructor. Is it really necessary? I don't see where you ever use new.

The error is due to the semi-colon after forest(). It is declared in the header file, but adding the semi-colon is redeclaring it in the implementation.

Ok, I'm nearly finished. I'm trying to create the forest using the array of tree pointers.

Code:

---

//-------------------------------------------------------------------------
//Default Forest Constructor
//-------------------------------------------------------------------------

forest::forest()
{
 
  for(int i=0; i<21; i++){
      for(int j=0; j<21; j++){

          int x=i&#37;2;
          int y=j%2;

            if ( i == 0 || i == 20 || j == 0 || j == 20 ) {
           
              grid[i][j] = new tree;
            }
            else if( x==0 || y==0 ){

              grid[i][j] = new pine;
            }
            else{

              grid[i][j] = new oak;
            }
        }
  }
}

---

Here is the compiler error:

Code:

---

forest.cpp: In constructor ‘forest::forest()’:
forest.cpp:30: error: expected type-specifier before ‘pine’
forest.cpp:30: error: cannot convert ‘int*’ to ‘tree*’ in assignment
forest.cpp:30: error: expected `;' before ‘pine’
forest.cpp:34: error: expected type-specifier before ‘oak’
forest.cpp:34: error: cannot convert ‘int*’ to ‘tree*’ in assignment
forest.cpp:34: error: expected `;' before ‘oak’

---

Did you #include Oak.h and Pine.h in the forest.cpp file?

Nope, I forgot to include them.

Now I have the following error:

Code:

---

/home/ryan/Desktop/C++_Lab/Final_Project/Part K/forest.cpp:32: undefined reference to `pine::pine()'
/home/ryan/Desktop/C++_Lab/Final_Project/Part K/forest.cpp:36: undefined reference to `oak::oak()'
/home/ryan/Desktop/C++_Lab/Final_Project/Part K/forest.cpp:32: undefined reference to `pine::pine()'
/home/ryan/Desktop/C++_Lab/Final_Project/Part K/forest.cpp:36: undefined reference to `oak::oak()'

---

Did you add Pine.cpp and Oak.cpp to your project (or makefile or command line or whatever you are using to build)?

I'm stunned that one of the first things they taught in the course was not how to compile, link, and run a program.

Quote:

---

Originally Posted by medievalelks

I'm stunned that one of the first things they taught in the course was not how to compile, link, and run a program.

---

Sounds like the course isn't the greatest in the world. It's supposed to be an Intro to C++ course, but they're trying to teach polymorphism and inheritance without teaching the STL properly (by the look of it - they're just bringing the entire STL into the global namespace) or any basic C/C++ fundimentals (includes, compiling, linking)...

Nope, I also left them out of the make.

Program runs fine now.

I'm finished!

Thanks everyone for the help!
Ryan