beginner: dynamic array of strings

salutations,

we are beginners.
we are trying to create a dynamic array of strings. we tried it in C, but, searching in the internet, we perceived that most people agreed that using std::vector in C++ is much better than relying on malloc and realloc in C to do a dynamic char**.
so, we are beginners in C++.
basically, what we want to do is to be able to, inside a for, add as many strings as we want into an array, without previously knowing how many elements we will have to add in each iteration of the for, and what the number of elements of the array will be.
note: this is not a homework problem.
thanks in advance.

Create your vector before the for loop. In the loop, add each string to the vector using the push_back function. When the loop is done, the vector will hold however many strings you added.

If you're having problems implementing that, post your code and the problems you're having.

Quote:

---

Originally Posted by pc2-brazil

so, we are beginners in C++.

---

Start here:

http://www.mindview.net/Books/TICPP/...ngInCPP2e.html

Quote:

---

Originally Posted by Daved

Create your vector before the for loop. In the loop, add each string to the vector using the push_back function. When the loop is done, the vector will hold however many strings you added.

If you're having problems implementing that, post your code and the problems you're having.

---

we were in doubt about whether we should post this code in the first post, but here it is:

Code:

---

#include<vector>
#include<cstdio>
#include<cstring>
using namespace std;

int main(int argc, char *argv[])
{
        vector<string> array;
        array.push_back("item1");
        array.push_back("item2");

        for (int a=0; a<array.size(); a++){
                printf("%s\n",array[a]);
        }
        return 0;
}

---

the idea is that the items are added, and then accessed in a for from 0 to the total number of items - 1. array.push_back seems to work, but array[a] crashes.
this seems very simple; it is based on an on-line tutorial. we should be able to make this work.
thank you in advance.

you need to use the c_str() member to get a C-string instead of a class std::string.

Code:

---

printf("%s\n",array[a].c_str());

---

Alternatively, you could use std::cout instead:

Code:

---

std::cout << array[a] << '\n';

---

You would have to #include <iosteam> for std::cout.

You also forgot to #include <string>
and from the code you posted, there is no need to #include <cstring> since you aren't using any old C string functions.

Here is your example cleaned up a bit, showing the use of iterators.

Code:

---

#include <iostream>
#include <vector>
#include <string>

using namespace std;

int main(int argc, char *argv[])
{
        vector<string> array;
        vector<string>::iterator iter ;
        array.push_back("item1");
        array.push_back("item2");

        for (iter = array.begin() ; iter != array.end() ; iter++){
                cout << *iter << endl ;
        }
        return 0;
}

---

thank you for the responses, it was very helpful.
the iterator example worked.
but when we try to use printf, including c_str, like this:

Code:

---

#include<string>
#include<vector>
using namespace std;

int main(int argc, char *argv[])
{
        vector<string> array;
        array.push_back("item1");
        array.push_back("item2");

        for (int a=0; a<array.size(); a++){
        printf("%s\n",array[a].c_str);
        }
        return 0;
}

---

it doesn't crash, but it gives a strange output:

Code:

---

ÚÝ♣
ÚÝ♣
Press any key to continue

---

thank you in advance.

You're missing the parentheses after c_str. It's a function.

Note that this is a good reason to use cout instead of printf- the compiler would have caught that error.

You forgot to use the parentheses.

of course, the parentheses. this was a beginner mistake.
thank you for the responses.