what is wrong with my if statement

i cant execute this query, and i would like some help

Code:

---

#include<stdio.h>
#include<conio.h>
#include<stdlib.h>

main()
{
      char user,pass,run;
      scanf("%c",&user);
      scanf("&c",&pass);
      if(user=="joker" && pass=="t");
      (
      printf("right input")
      )     
      else
      (
      printf("incorrect password");
      )

}

---

Code:

---

if(user=="joker" && pass=="t");

---

This code shouldn't even compile!
You're trying to compare a single character to a string (which wouldn't even work, even if user was a string), then you compare pass with "t" which should use single-quotes 't' since it's comparing just one character.

This is part of your problem.

Code:

---

if(user=="joker" && pass=="t");

---

Code:

---

#include<stdio.h>
#include<conio.h>
#include<stdlib.h>

main()
{
      char user,pass,run;
      scanf("%c",&user);
      scanf("&c",&pass);
      if(user=="joker" && pass=="t");
      (
      printf("right input")
      )     
      else
      (
      printf("incorrect password");
      )

}

---

You didn't change anything there, so no wonder it still doesn't work. Also note that "&c" is not a valid format string for scanf -- or rather, it is, but it doesn't do anything except look for a literal ampersand a literal letter c.

And as previously mentioned, user=="joker" compares things of different types, as does pass=="t", and since the if statement is empty ";" the else doesn't match with anything.

Edit: Wait, that wasn't the original poster. Oh ... kay. Anyway, all of the above is still true at least.

Someone has studying to do.
Lesson 1) Strings are char arrays. String is NOT one char. You can't read strings into one char. That's mega buffer overrun. http://cpwiki.sf.net/Buffer_overrun
Lesson 2) You can't compare strings with == in C, because it will just compare two pointers, due to how arrays work. Use strcmp.
Lesson 3) ALL lines MUST end with a semicolon ;
Lesson 4) If statements or other "block statements" such as functions that has { and }, should NOT end with a semicolon ( ; ).

Quote:

---

Originally Posted by joker_tony

i cant execute this query, and i would like some help

Code:

---

#include<stdio.h>
#include<conio.h>
#include<stdlib.h>

main()
{
      char user,pass,run;
      scanf("%c",&user);
      scanf("&c",&pass);
      if(user=="joker" && pass=="t");
      (
      printf("right input")
      )     
      else
      (
      printf("incorrect password");
      )

}

---

---

Hai
String comparision method is wrong...strings can be compared only using standard
library function strcmp(string1, string2)