smiley faces ????

Hello,
I am trying to make my program read a file thats on my desktop.
When I run the code all I get is smiley faces.
What is the problem with my code?

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <stddef.h>

int main (){
        char c;
        char inputText[500];

        FILE* inputFile;

        inputFile=fopen("C:\\Documents and Settings\\User\\My Documents\\GPA.txt","r");

        if (inputFile==NULL){
                printf("Failed to open");
                exit(-1);
        }

        fgets(inputText, 500, inputFile);

        while ((c=getc(inputFile)!=EOF)){
        printf("%c",c);
        }
        fclose(inputFile);
        system("Pause");
}

---

You could be trying to read in int's, not char's. Try changing c to an int, and print it with %d, instead of %c.

If that doesn't work, paste up a bit of the input file so we can see what's going on (in code tabs, of course).

First off, Adak is right in that c needs to be an int, not a char (even though you're reading characters!). Note however that you needn't use %d; if you're printing out characters, %c is correct, even though c is an int.

Next, take a look at this:

Code:

---

while ((c=getc(inputFile)!=EOF)){

---

Notice how you surround the whole expression with two sets of parentheses? One set is redundant. The result is code that always assigns either 0 or 1 to c; hence the smiley faces. You meant to do:

Code:

---

while( (c = getc(inputFile)) != EOF )

---

Otherwise, it's parsed as:

Code:

---

while(c = (getc(inputFile) != EOF))

---

So you see how the result of the != operator (which yields 0 or 1) is stored into c.

Code:

---

fgets(inputText, 500, inputFile);

---

Is there a specific reason why you're skipping the first 500 bytes of the file? If that really is your intention, fseek( inputFile, 500, SEEK_SET ); might be more appropriate.

good catch, cas!

I just found it funny; this thread, I don't know why. I can just imagine someone's face as they run the program and they have ASCII faces staring at them. 'What on earth?'

Quote:

---

Originally Posted by cpjust

Code:

---

fgets(inputText, 500, inputFile);

---

Is there a specific reason why you're skipping the first 500 bytes of the file? If that really is your intention, fseek( inputFile, 500, SEEK_SET ); might be more appropriate.

---

And more impossible, if the inputFile happens to be a pipe.

and of course it will result in different output if the first line is shorter than 500 chars