can't figure out what's with this code

hey guys, i'm new at coding, and this is a relatively simple thing, i just can't figure out whats wrong

i think that it might be that i'm using char

Code:

---

#include <iostream>

using namespace std;

int main()
{
    char music;
   
    cout<<"hey kat, do you like this new band i found, 'circle takes the square': ";
    cin>> music;
    cin.ignore();
    if (music = y) {
              cout<<"good choice\n";
    }
   
    if (music = n) {
      cout<<" aw you're going to make me cry!\n";
      }
      cin.get();
}

---

Code:

---

music = y ;

---

if y were defined, would be an assignment. You want to use the compare operator. Same with the other condition. And you want to compare to a character constant.

In other words:

Code:

---

if(music == 'y')

---

ok so i changed that, and added an 'else' to the no part, but when the user puts in a 'n' it says the same thing as 'y', any clue why?

btw thanks you two guys

Code:

---

#include <iostream>

using namespace std;

int main()
{
    char music;
   
    cout<<"hey kat, do you like this new band i found, 'circle takes the square': ";
    cin>> music;
    cin.ignore();
    if (music = 'y') {
              cout<<"good choice\n";
    }
   
    else if (music = 'n') {
      cout<<" aw you're going to make me cry!\n";
      }
      cin.get();
}

---

You are still using assignment. = and == are completely different operators.

ok, thanks anon, todd, and dwks

Btw, if the warning levels are high enough, some compilers will warn about assignment like that inside if statements. A typical example is Visual Studio.

why not make such warnings etc. the default behave?
and experienced users can turn them off, if they wish, but newbies will be saved from buggy situations :)

on gcc it will issue a warning with -Wall.