This is my Homework

Problem Statement:

Quote:

---

Define a class to represent a bank account. Include the following members:

1. Name of the depositor
2. Account Number
3. Type of account
4. Balance amount in the account

Member Functions

1. To assign initial values
2. To deposit an amount
3. To withdraw an account after checking the balance
4. To display name and balance

Write a main() function to test your program

---

What I did:

Code:

---

#include<iostream>

class account
{
      private:
                  string name;
                  int acnum;
                  bool type;  //0 for savings, 1 for current account
                  int balance;
        public:
                  account()
                  {
                        cout<<"\nName of customer";
                        cin>>name;
                        cout<<"\nAccount Number";
                        cin>>acnum;
                        cout<<"\nType--->0/1";
                        cin>>type;
                        cout<<"\nInitial balance";
                        cin>>balance;
                    }
                 
                      void deposit()
                    {
                          cout<<"\nDeposit Amount:";
                          cin>>int amount;
                          balance+=amount;
                          cout<<"\nDone";
                    }

                    void withdraw()
                  {
                        cout<<"\nWithdraw Amount";
                        cin>>int amount;
                        if(amount<=balance)
                      {
                            balance-=amount;
                            cout<<"\nDone";
                        }
                      else
                      {
                            cout<<"\nGet lost @#$&#37;^&*";
                      }
                }

              void display()
            {
                  cout<<endl<<name;
                  cout<<endl<<balance;
            }

---

Now I have no idea how to write the main function :confused:

Thank you for any help

You'll need to create an account (instantiate an "account"), then use the member functions to call your methods.

Sort of like this (not syntax checked):

Code:

---


int main() {

myaccount = new account() ;

myaccount.deposit() ;

myaccount.withdraw() ;
}

---

For deposit(), you want it to accept a positive value.

For withdraw, you'll want it to withdraw a positive value.

In C++, you will usually want to cause a newline by appending "endl" to the end of the cout expression.

But how do I know how many customers the bank will have?:confused:

Code:

---

account customer1, customer2 ......//how many?

---

You can keep track of all instances you've created within your class, or within main - either one.

Each time you create a new instance, your constructor will be called. Perhaps you can create another variable to keep a count?

Quote:

---

Originally Posted by Todd Burch

Code:

---


int main() {
myaccount = new account() ;
myaccount.deposit() ;
myaccount.withdraw() ;
}

---

---

But Todd, that essentially creates it on the heap, which in itself is useless, plus it makes the rest of the syntax wrong. It has to be -> in that case.
Better would just be
account myaccount;

And abk - I see your class all wrong - the class should not ask for the data, not at all. The class is the object - you don't see a bank account asking for how much you want to deposit, do you? The software should do that - your code in main!
You need to pass the correct data to these functions, not let them ask for it. That is not how object-oriented works.

Quote:

---

(not syntax checked):

---

As I said.... ;)

Pretty big error :p

Yes.

Quote:

---

Originally Posted by Elysia

And abk - I see your class all wrong - the class should not ask for the data, not at all. The class is the object - you don't see a bank account asking for how much you want to deposit, do you? The software should do that - your code in main!
You need to pass the correct data to these functions, not let them ask for it. That is not how object-oriented works.

---

I was using constructor account() to initialise the values. What is the other alternative to do this?

New Code:

Code:

---

#include<iostream>
using namespace std;
int menu();
class account
{
      private:
                  string name;
                  int acnum;
                  bool type;  //0 for savings, 1 for current account
                  int balance;
        public:
                  account()
                  {
                        cout<<"\nName of customer";
                        cin>>name;
                        cout<<"\nAccount Number";
                        cin>>acnum;
                        cout<<"\nType--->0/1";
                        cin>>type;
                        cout<<"\nInitial balance";
                        cin>>balance;
                       
                    }
                 
                      void deposit()
                    {
                          int amount;
                          cout<<"\nDeposit Amount:";
                          cin>>amount;
                          balance+=amount;
                          cout<<"\nDone";
                    }

                    void withdraw()
                  {
                        int amount;
                        cout<<"\nWithdraw Amount";
                        cin>>amount; 
                        if(amount<=balance)
                          {
                                balance-=amount;
                                cout<<"\nDone";
                            }
                        else
                          {
                                cout<<"\nGet lost @#$&#37;^&*";
                            }
                  }

              void display()
            {
                  cout<<endl<<name;
                  cout<<endl<<balance;
            }
};



int main()
{
        account customer1;
        int flag=menu();
        if(flag==1)
                customer1.deposit();
        if(flag==2)
                customer1.withdraw();
        if(flag==3)
        customer1.display();
        return 0;
}


int menu()
{
        int flag;
        /*PRINT THE MENU*/
        cout<<"\nEnter your choice";
        cin>>flag;
        return flag;
}

---

But this is only for one customer :(

A class does not output anything to screen and it does not read anything from the screen either. A bank account cannot talk and it cannot read. It's an object, not human.
All the cout and cin does not belong in the class.

Code:

---

#include<iostream>
using namespace std;
int menu();
class account
{
      private:
                  string name;
                  int acnum;
                  bool type;  //0 for savings, 1 for current account
                  int balance;
        public:
                  account()
                  {
                       
                      //commented out. Rest of the code unchanged.
                          /* cout<<"\nName of customer";
                        cin>>name;
                        cout<<"\nAccount Number";
                        cin>>acnum;
                        cout<<"\nType--->0/1";
                        cin>>type;
                        cout<<"\nInitial balance";
                        cin>>balance;*/
                       
                    }
                 
                      void deposit()
                    {
                          int amount;
                          cout<<"\nDeposit Amount:";
                          cin>>amount;
                          balance+=amount;
                          cout<<"\nDone";
                    }

                    void withdraw()
                  {
                        int amount;
                        cout<<"\nWithdraw Amount";
                        cin>>amount; 
                        if(amount<=balance)
                          {
                                balance-=amount;
                                cout<<"\nDone";
                            }
                        else
                          {
                                cout<<"\nGet lost @#$&#37;^&*";
                            }
                  }

              void display()
            {
                  cout<<endl<<name;
                  cout<<endl<<balance;
            }
};



int main()
{
        account customer1;
        int flag=menu();
        if(flag==1)
                customer1.deposit();
        if(flag==2)
                customer1.withdraw();
        if(flag==3)
        customer1.display();
        return 0;
}


int menu()
{
        int flag;
        /*PRINT THE MENU*/
        cout<<"\nEnter your choice";
        cin>>flag;
        return flag;
}

---

Now how do I initialize the values?

How would they do it on a bank? The class is the actual bank account or the computer to it.
You need something to act as the one inputting things into the computer and you need the computer to accept these inputs and store them somewhere.
Now there's your task.

This applies to all functions in your class, not just the constructor.

It is telling me that name, type, acnum and balance are private, so something is wrong. Dunno what.

Code:

---

#include<iostream>
using namespace std;
int menu();
class account
{
      private:
                  string name;
                  int acnum;
                  bool type;  //0 for savings, 1 for current account
                  int balance;
        public:
                  account()
                  {
                        /* cout<<"\nName of customer";
                        cin>>name;
                        cout<<"\nAccount Number";
                        cin>>acnum;
                        cout<<"\nType--->0/1";
                        cin>>type;
                        cout<<"\nInitial balance";
                        cin>>balance;*/
                                               
                       
                       
                    }
                 
                      void deposit(int amountzzz)
                    {
                          /*int amount;
                          cout<<"\nDeposit Amount:";
                          cin>>amount;
                              balance+=amount;
                          cout<<"\nDone";*/
                          balance+=amountzzz;
                    }

                    void withdraw(int amountzzz)
                  {
                        /*int amount;
                        cout<<"\nWithdraw Amount";
                        cin>>amount; 
                        if(amount<=balance)
                          {
                                balance-=amount;
                                cout<<"\nDone";
                            }
                        else
                          {
                                cout<<"\nGet lost @#$&#37;^&*";
                            }*/
                           
                        balance-=amountzzz; 
                  }

              void display()  //??
            {
                  cout<<endl<<name;
                  cout<<endl<<balance;
            }
};



int main()
{
        int amountzzz;
        account customer1;
        cout<<"\nName of customer";
    cin>>customer1.name;
    cout<<"\nAccount Number";
    cin>>customer1.acnum;
    cout<<"\nType--->0/1";
    cin>>customer1.type;
    cout<<"\nInitial balance";
    cin>>customer1.balance;
       
        int flag=menu();
       
        if(flag==1)
                {
                        cout<<"\nDeposit Amount:";
                        cin>>amountzzz;               
                        customer1.deposit(amountzzz);
                }
                       
        if(flag==2)
                {
                        cout<<"\nWithdraw Amount";
                        cin>>amountzzz;
                    if(amountzzz<=balance)
                        customer1.withdraw(amountzzz);
                    else
                        cout<<"\nGet lost @#$%^&*";
                           
                }
        if(flag==3)
            customer1.display();
        return 0;
}


int menu()
{
        int flag;
        /*PRINT THE MENU*/
        cout<<"\nEnter your choice";
        cin>>flag;
        return flag;
}

---

The member variables are placed under the private keyword, which means that anything outside the class can't access them.
You must read into local variables inside main and pass to the class functions.

Is this OK

Code:

---

#include<iostream>
using namespace std;
int menu();
class account
{
      private:
                  string name;
                  int acnum;
                  bool type;  //0 for savings, 1 for current account
                  int balance;
        public:
                  account(string namezzz, int acnumzzz, bool typezzz,int balancezzz)
                  {
                        /* cout<<"\nName of customer";
                        cin>>name;
                        cout<<"\nAccount Number";
                        cin>>acnum;
                        cout<<"\nType--->0/1";
                        cin>>type;
                        cout<<"\nInitial balance";
                        cin>>balance;*/
                        name=namezzz;
                        acnum=acnumzzz;
                        type=typezzz;
                        balance=balancezzz;
                                               
                       
                       
                    }
                 
                      void deposit(int amountzzz)
                    {
                          /*int amount;
                          cout<<"\nDeposit Amount:";
                          cin>>amount;
                              balance+=amount;
                          cout<<"\nDone";*/
                          balance+=amountzzz;
                    }

                    void withdraw(int amountzzz)
                  {
                        /*int amount;
                        cout<<"\nWithdraw Amount";
                        cin>>amount; 
                        if(amount<=balance)
                          {
                                balance-=amount;
                                cout<<"\nDone";
                            }
                        else
                          {
                                cout<<"\nGet lost @#$&#37;^&*";
                            }*/
                           
                        balance-=amountzzz; 
                  }

              void display()  //??
            {
                  cout<<endl<<name;
                  cout<<endl<<balance;
            }
           
            int getbalance()
            {
                    return balance;
            }
};



int main()
{
        int amountzzz,acnumzzz,balancezzz; //LOCAL VARIABLES
        string namezzz; //LOCAL
        bool typezzz; //LOCAL
        cout<<"\nName of customer";
        cin>>namezzz;
        cout<<"\nAccount Number";
        cin>>acnumzzz;
        cout<<"\nType--->0/1";
        cin>>typezzz;
        cout<<"\nInitial balance";
        cin>>balancezzz;
        account customer1(namezzz,acnumzzz,typezzz,balancezzz);       
        int flag=menu();
       
        if(flag==1)
                {
                        cout<<"\nDeposit Amount:";
                        cin>>amountzzz;               
                        customer1.deposit(amountzzz);
                }
                       
        if(flag==2)
                {
                        cout<<"\nWithdraw Amount";
                        cin>>amountzzz;
                    if(amountzzz<=customer1.getbalance())
                        customer1.withdraw(amountzzz);
                    else
                        cout<<"\nGet lost @#$%^&*";
                           
                }
        if(flag==3)
            customer1.display();
        return 0;
}


int menu()
{
        int flag;
        /*PRINT THE MENU*/
        cout<<"\nEnter your choice";
        cin>>flag;
        return flag;
}

---

Its working but only for one customer.

Get rid of the "display" member function (a bank account should not display anything on the screen unless for debugging purposes). You can show the contents in main instead.
Otherwise it's acceptable.
And... do you want it to be able to create more accounts for more customers? Is this what you want to accomplish?

Quote:

---

Originally Posted by Elysia

Get rid of the "display" member function (a bank account should not display anything on the screen unless for debugging purposes). You can show the contents in main instead.

---

Then how will main() access private data members without a member function?

Quote:

---

And... do you want it to be able to create more accounts for more customers? Is this what you want to accomplish?

---

Yes.

Quote:

---

Originally Posted by abk

Then how will main() access private data members without a member function?

---

You can make new ones to return the data you need. In a safe way.

Quote:

---

Yes.

---

Then you simply need an array. Std::vector is perfect for it.

Thanks Elysia and Todd.

Another couple tips.

For balance, a double would be a better choice than an int. If I deposit 50 cents, how would you track that?

Also, when an account is "opened" (when your constructor is called), it would be a good idea to set an initial balance of zero.

Finally, class names typically would have a capital first letter, so "Account" vs "account".

Todd

>> For balance, a double would be a better choice than an int. If I deposit 50 cents, how would you track that?

double isn't actually how real financial software keeps track of money. It's usually just a big integer that's denominated in cents. Because it's always precise and you don't get some of the issues that you would using a floating-point, like the "hole" towards zero, or rounding errors. But for this assignment, you could go with either representation.