A little problem with filing in C

I'm writing an SJF scheduling algo and I'm having a little problem with filing. I'm to read data from a file. I've read the entire data in a single array/pointer but now I want to read every line in a separate array/pointer/string. I'm not able to do so. Ay help would be highly appreciated.

Here's the code so far:

Code:

---

int main ()
{
FILE *fptr;
int i;
printf ("Output from the file");
char s[500];
int count = 0;
fptr = fopen ("file.txt","r");
if (!f)
{
return 1;
}
while (fgets(s,1000,fptr) != NULL)
printf ("%s",s);
fclose(fptr);
return 0;
}

---

How can I read each line in a separate array/string/pointer?

Thanks.

First you have to make an array of arrays like so:

Code:

---

const int MAX_ARRAY_LEN = 100;

int nr_arrays = 5;

char *array[MAX_ARRAY_LEN];

/* you have just declared a pointer to an array of length MAX_ARRAY_LEN */

/* allocate memory for an array of arrays of length MAX_ARRAY_LEN using malloc()

array = malloc((sizeof(char) * MAX_ARRAY_LEN) * nr_arrays);

/* now use array[i] to store whatever you wish */

---

Quote:

---

Originally Posted by TheUmer

Here's the code so far:

---

I notice that you declare s with a size of 500, but in the fgets() call you use it as if it has a size of at least 1000.

If it is reasonable for you to use an array of size 1000 to store each line, then a more correct version of what claudiu suggests would be:

Code:

---

#define LINE_MAX_SIZE 1000

/* ... */

char (*lines)[LINE_MAX_SIZE];
size_t lines_size = 0;    /* number of lines stored */
size_t lines_capacity = 4; /* realloc when lines_size would exceed lines_capacity */

lines = malloc(sizeof(*lines) * lines_capacity);

/* Now, fgets() in a loop with lines[i] and LINE_MAX_SIZE */

---

Remember to use free() when you are done with lines.

Alright. I'm still having a few problems. I tried to get each line in a separate pointer but it's getting crazy. Here's the code:

Code:

---

int main ()
{
FILE *fptr;
int i;
printf ("Output from the file");
char s[500];
int count = 0;
fptr = fopen ("file.txt","r");
if (!fptr)
{
return 1;
}
while (fgets(s,1000,fptr) != NULL)
{
if (s[i] == 'P' && s[i+1] == '1')
{
while (s[i] != '\n')
{
count++;
i++;
}
}
for (for i=0; i<count; i++)
{
p1= malloc (sizeof (char)*count);
//printf ("%d", count);
p[i] = s[i];
}
printf ("%s",s);
}
for (i=0 i<count; i++)
{
printf ("%c", p1[i]);
}
fclose(fptr);
return 0;
}

---

PROBLEM:

The value of the counter in the loop is 4 (4 elements in the first row), and it indeed gies the value of the counter 4 when I printf the counter. But in the following loop:

Code:

---

for (for i=0; i<count; i++)
{
p1= malloc (sizeof (char)*count);
//printf ("%d", count);
p[i] = s[i];
}

---

It outputs the counter 40 times. What's going on?

I don't think that can compile, with a for on the outside and a for on the inside of the parentheses.

Would you kindly elaborate a bit more?

Quote:

---

Originally Posted by TheUmer

Would you kindly elaborate a bit more?

---

Not really, no. The code you posted has a syntax error and cannot compile. Therefore that is not the code you are using. I can't help much more than say "that's not the code you're using".

????

Look at this line:

Code:

---

for (for i=0; i<count; i++)

---

Furthermore, you need to indent your code properly.

Sorry that was a typo error. I'm compiling it on another PC and I don't have net on it.

Quote:

---

Originally Posted by TheUmer

Sorry that was a typo error. I'm compiling it on another PC and I don't have net on it.

---

Well, that's fine and all, but we can't actually tell you what's going on with the code unless we can see the actual code.

What do you mean by 'actual' code?

Here's a bit modification:

Code:

---

while (fgets(s,1000,fptr) != NULL)
{
    if (s[i] == 'P' && s[i+1] == '1')
    {
      while (s[i] != '\n')
      {
            count++;
            p1=malloc (sizeof(char)*count);
            p1[count-1]=s[i];
            //printf ("%c", p1[i]);
            i++;
            }
        }
        for (i=0 i<count; i++)
        {
            printf ("%c", p1[i]);
        }
        fclose(fptr);
        return 0;
}

---

Now the counter is running fine and it's putting values in p1, but problem is in the last loop all p1 outputs in 0 four times.

One way is to copy and paste verbatim, though that would be a little difficult considering that it is from a different computer. Perhaps use a thumb drive to transfer the files, and then copy and paste from that.

Quote:

---

Originally Posted by TheUmer

Here's a bit modification:

Code:

---

while (fgets(s,1000,fptr) != NULL)
{
    if (s[i] == 'P' && s[i+1] == '1')
    {
      while (s[i] != '\n')
      {
            count++;
            p1=malloc (sizeof(char)*count);
            p1[count-1]=s[i];
            //printf ("%c", p1[i]);
            i++;
            }
        }
        for (i=0 i<count; i++)
        {
            printf ("%c", p1[i]);
        }
        fclose(fptr);
        return 0;
}

---

Now the counter is running fine and it's putting values in p1, but problem is in the last loop all p1 outputs in 0 four times.

---

The actual code is just that, the actual code that you are running, not what you remember about your code some time later.

As to this code, it is horrific. You leak heaven knows how much memory; you keep allocating more and more space for p1 (destroying the previous values each time), and then putting just one character in the new array. Most of your p1 array will end up being --- well, not blank exactly, but containing who-knows-what.

(Of course, this analysis is only valid insofar as what you've posted matches what you've actually got -- again, there is a typo that would make this impossible to compile.)

Okay. I think using pointers would be a bad idea. Here the new code using only arrays:

Code:

---

int main ()
{
    FILE *fptr;
    arr[20];
    int i;
    printf ("Output from the file");
    char s[500];
    int count = 0;
    fptr = fopen ("file.txt","r");
    if (!fptr)
    {
        return 1;
    }
    while (fgets(s,1000,fptr) != NULL)
    {
        if (s[i] == 'P' && s[i+1] == '1')
        {
            while (s[i] != '\n')
            {
                count++;
                arr[count]=s[i];
                i++;
            }
        }
    }
    for (i=0 i<count; i++)
    {
        printf ("%c", arr[i]);
    }
fclose(fptr);
return 0;
}

---

PROBLEM:

Only question: Why is the counter only 4 in the following loop?

Code:

---

while (s[i] != '\n')
            {
                count++;
                arr[count]=s[i];
                i++;
            }

---

File format is:

P1 0 (this is the first line. As the counter increments to only first, the array outputs in the final loop only P1 and not 0)

Quote:

---

Originally Posted by TheUmer

Only question: Why is the counter only 4 in the following loop?

---

As opposed to what? counter appears to count the number of characters on the line. The line you give has four characters in it. Four would therefore seem to be the number that you want.

It's actually:

P1 (a tab) 0

So how do I include the number of spaces and tabs?

Code:

---

char s[500];
    int count = 0;
    fptr = fopen ("file.txt","r");
    if (!fptr)
    {
        return 1;
    }
    while (fgets(s,1000,fptr) != NULL)

---

What are you doing?


Quzah.

Quote:

---

Originally Posted by TheUmer

It's actually:

P1 (a tab) 0

So how do I include the number of spaces and tabs?

---

Is that not still four characters? 'P', '1', '\t', and '0'.

Also as a note, since arrays start at 0, you need to put your letter into s[count] before incrementing count in your loop.