Can someone please help me with my program? I am new to C programming.

Hello,
I was wondering if someone can help me with file input and output.
I basically have golf.txt document that contains data from 8 golfers' scores while playing a game of golf. I used the data in the golf.txt document to create a program that read values from the .txt document and calculates the total score of each golfer. However, now i need to take it a step further and create a program that compares each golfers score to the par score and outputs a value for hole by hole.


The program should output 18 different values for each golfer, where each value will contain (the number of tries- par score= score for that hole) and there are 18 holes in a game of golf so it make sense:)


Each letter represents each golfers score on each hole. (A for hole 1, B for hole 2..... R for hole 18)

It should look something like this for each golfer:
Golfer #1’s score: A B C D E F G.....R
Golfer #2.................
Golfer #3..................




This should not be too hard because I have it all the data I need in my golf.txt file:

8 // This is the number of golfers
4 4 3 5 4 3 4 5 6 5 4 4 4 5 5 4 3 3 // these are the par scores
4 4 3 6 7 4 4 5 4 5 3 5 3 5 7 5 3 2 // for here down is each of the eight golfers score
4 5 3 4 6 5 5 6 3 5 4 6 3 3 5 4 5 3
3 4 5 6 4 4 4 5 5 5 4 5 4 3 3 5 4 3
2 5 5 6 7 6 5 5 4 6 4 5 6 7 5 5 5 5
4 5 6 3 3 5 4 4 3 3 2 5 6 6 5 5 3 3
2 5 3 5 5 5 6 5 4 3 4 5 5 4 4 6 5 5
6 5 4 5 5 3 5 6 5 4 6 5 6 4 4 6 5 4
4 4 5 5 3 3 6 5 4 3 3 5 6 5 3 6 5 4




MY QUESTIONS:

1) Would arrays be the best way to go about completing this program?
2) Would I need a 1d or 2d array to complete this program?
3) If so, I am completely new to arrays! can anyone help me understand how I would set it up? I know that the basic format is something like int numbers [rows][columns]
4) How would I add/ subtract array's positions from each other (for example row 2 column 3 + row 2 column 4) ?


Thank You,
Matt H.

1. Arrays would definitely be useful.
2. I would use a 1d array for the par scores and either a 2d array or an array of structs for the golfer scores. Since you're new to this, I would go with the 2d array for golfer scores.
3. I'd make it an int[# golfers][18]
4. You would use a loop to iterate through each element and add the elements just like any other variable. For example, part of your program might look like this:

Code:

---

for (i=0; i<18; ++i)
{
    score[n][i] = tries[n][i] - par[i];
}

---

Thank you for the response,

For some reason my array program is not even compiling correctly...
I am not even sure if I am on the right track... Can someone help me out and take a look?

This is what i got so far:

Code:

---

#include <stdio.h>


int main() {

  FILE *ifp;
  int ttl_golfers, counter, totalscore, ok, j, i, z, n;
  int tries [9][18];
  int score [9][18];
  int parscore[18];

  ifp = fopen("golf.txt","rt");
 
  fscanf(ifp, "%d", &ttl_golfers);
  printf("\n%d golfers played on this golf course:\n", ttl_golfers);

 
  for (z=0; z < 18; z++)  {
    fscanf(ifp, "%d", &parscore);
    parscore[18] = parscore[z];
    }
                                       
  for(i = 0; i < 18; i++) {
    fscanf(ifp, "%d", &score);
    score[n][i] = tries[n][i]- parscore[i];
    }
  for(counter=0; counter < ttl_golfers; counter++) {
    }

  printf("\nGolfer #%d's Score: %d\n", counter, score-parscore);
 

}

  fclose(ifp);
 
 
  system("PAUSE");
  return 0;

}

---

Code:

---

fscanf(ifp, "%d", &parscore);

---

you are missing [z] after parscore

This is my new code and it is still not compiling our outputting any values:/

Any ideas?

Code:

---

#include <stdio.h>


int main() {

  FILE *ifp;
  int ttl_golfers, counter, totalscore, ok, j, i, z, n, p, o;
  int tries [9][18];
  int score [9][18];
  int parscore[18];

  ifp = fopen("golf.txt","rt");
 
  fscanf(ifp, "%d", &ttl_golfers);
  printf("\n%d golfers played on this golf course:\n", ttl_golfers);

 
  for (z=0; z < 18; z++)  {
    fscanf(ifp, "%d", &parscore[z]);
    parscore[z] = parscore[z];
    }
                                       
  for(i = 0; i < 18; i++) {
    fscanf(ifp, "%d", &score[n][i]);
    score[n][i] = tries[n][i]- parscore[z];
    }
  for(counter=0; counter < ttl_golfers; counter++) {
    }

  printf("\nGolfer #%d's Score: %d\n", counter, score[n][i]-parscore[z]);
 

}

  fclose(ifp);
 
 
  system("PAUSE");
  return 0;

}

---

Code:

---

for(i = 0; i < 18; i++) {
    fscanf(ifp, "%d", &score[n][i]);
    score[n][i] = tries[n][i]- parscore[z];
    }

---

where n is initialized?

Hm... Im not sure what u meant by "Where n is initialized?" but I guess u mean that I forgot to include n=0? right? Sorry, im not very good with programming yet, im working on it:)

This is my new code (which I am still not able to compile:

Code:

---

#include <stdio.h>


int main() {

  FILE *ifp;
  int ttl_golfers, counter, totalscore, ok, j, i, z, n=0, p, o;
  int tries [9][18];
  int score [9][18];
  int parscore[18];

  ifp = fopen("golf.txt","rt");
 
  fscanf(ifp, "%d", &ttl_golfers);
  printf("\n%d golfers played on this golf course:\n", ttl_golfers);

 
  for (z=0; z < 18; z++)  {
    fscanf(ifp, "%d", &parscore[z]);
    parscore[z] = parscore[z];
    }
                                       
  for(i = 0; i < 18; i++) {
    fscanf(ifp, "%d", &score[n][i]);
    score[n][i] = tries[n][i]- parscore[z];
    }
  for(counter=0; counter < ttl_golfers; counter++) {
    }

  printf("\nGolfer #%d's Score: %d\n", counter, score[n][i]-parscore[z]);
 

}

  fclose(ifp);
 
 
  system("PAUSE");
  return 0;

}

---

Code:

---

}

  fclose(ifp);
 
 
  system("PAUSE");
  return 0;

}

---

this is in its own stament block and is all messed up, delete the topmost } in this code snippet above^^

Code:

---

  for(i = 0; i < 18; i++) {
    fscanf(ifp, "%d", &score[n][i]);
    score[n][i] = tries[n][i]- parscore[z];
    }
  for(counter=0; counter < ttl_golfers; counter++) {
    }

  printf("\nGolfer #%d's Score: %d\n", counter, score[n][i]-parscore[z]);

---

the bolded code above should be inside the for loop above (its an empty for loop) at this point if you fix that, it does in fact compile....however it segfaults immediately upon running, ill leave that up to you to find out why

Thank you! My program is finally compiling:)

I am unsure what u meant by "the bolded code" because it did not show up in bold lettering. I might of misunderstood you:/

My program is now compiling correctly, however it is running completely wrong...

Any ideas or advice? .... I think my logic for my loops are incorrect but it makes sense to me

Code:

---

#include <stdio.h>


int main() {

  FILE *ifp;
  int ttl_golfers, counter, totalscore, ok, j, i, z, n=0, p, o;
  int tries [9][18];
  int score [9][18];
  int parscore[18];

  ifp = fopen("golf.txt","rt");
 
  fscanf(ifp, "%d", &ttl_golfers);
  printf("\n%d golfers played on this golf course:\n", ttl_golfers);


  for (z=0; z < 18; z++)  {
    fscanf(ifp, "%d", &parscore[z]);
    parscore[z] = parscore[z];
    }


 for(counter=0; counter < ttl_golfers; counter++) {
      for(i = 0; i < 18; i++) {
    for(n = 0; n < 8; n++)
    fscanf(ifp, "%d", &tries[n][i]);
    score[n][i] = tries[n][i]- parscore[z];
    printf("\nGolfer #%d's Score: %d\n", counter, tries[n][i]-parscore[z]);

    }
    }


  fclose(ifp);
 
 
  system("PAUSE");
  return 0;


}

---

Code:

---

  for(counter=0; counter < ttl_golfers; counter++) {
    }

  printf("\nGolfer #%d's Score: %d\n", parscore[z]);

---

As I said prior the printf above sould go into the for loop just above it, right now that for loop does absolutely nothing.

Beyond that however your problems are mainly due to excessive looping and using an inferior method of reading in your records.

Whenever reading data from a file (a flat text file, not binary) you should be using fgets and an appropriate buffer and you should verify the line was read in correctly before attempting to use it or split it up into scores/arrays

Can you please view my "newer" code because I adjusted my code after the advice you gave me.

Look at post #11 (two responses up)



Thank you for your help

Quote:

---

Originally Posted by nonpuz

Beyond that however your problems are mainly due to excessive looping and using an inferior method of reading in your records.

Whenever reading data from a file (a flat text file, not binary) you should be using fgets and an appropriate buffer and you should verify the line was read in correctly before attempting to use it or split it up into scores/arrays

---

refer to this ^^

Oh okay...

What exactly is a buffer?

See I tried to make sure that my code is getting read in correctly but it is not, which is not surprising, but why is this? Even when it is as simple as reading in the first value in the document its reading it as 46 instead of 8

You would want to use a structure like this:

Code:

---

#include <stdio.h>
#define MAX_LINE BUFSIZ
....
....
char buf[MAX_LINE+1];
FILE * somefile = NULL;
int players = 0;
...
if (!(somefile = fopen("myfile.txt","r"))
  return 0;
...
fgets(buf,MAX_LINE,somefile);
if (!feof(somefile)) {
  sscanf(buf,"%d",&players);
  printf("number of players %d\n",players);
  while (fgets(buf,MAX_LINE,somefile) && !ferror(somefile)) {
    /* process buf here, ie convert it to a number */
    /* ie, read in each of the score lines, and then split them into the scores and do whatever */
  }
}

fclose(somefile);

---

Point is you want to make sure you read in the entire line up to the \n (and including it) so the next call to fgets() starts exactly at the start of the next line that is the problem with fscanf, unless you do something like "%d\n" for your format string

So even with fgets, if the line is longer then the size you pass it it will not read in the entire line and the next fgets call will start where the last one left off.

I think it's fine for him to use scanf for now. I think he should focus on fixing his program logic before going for this kind of robustness.

Thank you for the response, I was trying to understand how your code works but I am I think it is above my level, I think it is C+ or C++.... I am only falmiliar with C.

I tried copying the code and editing my code into it but I was unable too...

Thanks anyways though

Quote:

---

Originally Posted by NeonBlack

I think it's fine for him to use scanf for now. I think he should focus on fixing his program logic before going for this kind of robustness.

---

I have been working on my code for hours now, do you have any suggestions about how to fix the logic? I tried so many different things I am running out of ideas.

Is this a correct code for reading the first line from the golf.txt document? I know it is not, but I have no clue why I tried to mess around with it...


golf.txt document:

8
3 3 4 5 5 4 3 3 3 4 4 5 4 3 3 5 4 3
3 3 2 4 5 4 4 4 4 5 3 5 3 5 1 4 3 2
4 5 3 4 4 3 5 3 3 3 4 2 3 3 4 4 5 3
3 4 5 6 4 4 4 4 3 5 4 5 4 3 3 5 4 3
2 4 5 5 5 5 5 3 3 5 4 4 2 4 4 5 5 4
4 5 6 3 3 5 4 4 3 3 2 4 5 4 5 5 3 3
2 5 3 5 5 5 3 4 3 4 4 4 3 4 4 5 5 5
3 4 4 5 4 3 4 4 3 4 5 5 4 3 4 4 5 4
4 2 4 3 5 3 3 4 5 2 3 3 5 5 5 3 5 5

Code:

---

for (z=0; z < 18; z++)  {
    fscanf(ifp, "%d", &parscore[z]);
    parscore[z] = parscore[z];
    }

---

Delete the parscore[z] = parscore[z]. That tells you that you are now, you - rubbish.

Nonpuz's idea of a struct is good, but overkill.

I'll look at your code when I return from an errand - about an hour. You just want the "true" score by comparing the par score with the score they made, on each hole, correct?

Here is your code, working and cleaned up, minus extra logic/variables etc:

Code:

---

#include <stdio.h>

int main() {
    FILE *ifp;
    int ttl_golfers, totalscore, ok, j, i, z, n, p, o;
    int tries [8][18];
    int score [8][18];
    int parscore[18];

    ifp = fopen("golf.txt","r");

    fscanf(ifp, "%d\n", &ttl_golfers);
    printf("%d golfers played on this golf course:\n", ttl_golfers);

    for (z=0; z < 18; z++)  {
        fscanf(ifp, "%d ", &parscore[z]);
        parscore[z] = parscore[z];
    }
    fscanf(ifp,"\n");

    for(n=0; n < ttl_golfers; n++) {
        for(i = 0; i < 18; i++) {
            fscanf(ifp, "%d", &tries[n][i]);
            score[n][i] = tries[n][i]- parscore[i];
            printf("Golfer #%d's Score: %d\n", n, score[n][i]);
        }
        fscanf(ifp,"\n");
    }

    fclose(ifp);
    return 0;
}

---

Please note that this code will ONLY work (and will likely crash) if it is not given a golf.txt file in its current directory that is PERFECTLY formatted, meaning exactly like this:

Code:

---

8
4 4 3 5 4 3 4 5 6 5 4 4 4 5 5 4 3 3
4 4 3 6 7 4 4 5 4 5 3 5 3 5 7 5 3 2
4 5 3 4 6 5 5 6 3 5 4 6 3 3 5 4 5 3
3 4 5 6 4 4 4 5 5 5 4 5 4 3 3 5 4 3
2 5 5 6 7 6 5 5 4 6 4 5 6 7 5 5 5 5
4 5 6 3 3 5 4 4 3 3 2 5 6 6 5 5 3 3
2 5 3 5 5 5 6 5 4 3 4 5 5 4 4 6 5 5
6 5 4 5 5 3 5 6 5 4 6 5 6 4 4 6 5 4
4 4 5 5 3 3 6 5 4 3 3 5 6 5 3 6 5 4

---

Note that after each of the lines with 18 digist (not the first line with only one digit) there is a single TRAILING space, this is REQUIRED for it be read correctly.

The slightest mistake, such as 2 extra spaces at the end will result in a file that will not be parsed correctly with the code above.

That is why I mentioned the fgets method as its much more flexible with how the file appears, you could put all kinds of stuff to ignroe comments, extra spacing, etc...with fscanf it is a pain

Quote:

---

Originally Posted by Adak

Delete the parscore[z] = parscore[z]. That tells you that you are now, you - rubbish.

Nonpuz's idea of a struct is good, but overkill.

I'll look at your code when I return from an errand - about an hour. You just want the "true" score by comparing the par score with the score they made, on each hole, correct?

---

Right, so the program should output 18 different values that compare the par score to the actual score for each golfer. Thank you Adak.

Quote:

---

Originally Posted by nonpuz

Here is your code, working and cleaned up, minus extra logic/variables etc:


Please note that this code will ONLY work (and will likely crash) if it is not given a golf.txt file in its current directory that is PERFECTLY formatted, meaning exactly like this:


Note that after each of the lines with 18 digist (not the first line with only one digit) there is a single TRAILING space, this is REQUIRED for it be read correctly.

The slightest mistake, such as 2 extra spaces at the end will result in a file that will not be parsed correctly with the code above.

That is why I mentioned the fgets method as its much more flexible with how the file appears, you could put all kinds of stuff to ignroe comments, extra spacing, etc...with fscanf it is a pain

---

THANK YOU~! I will try to look at it for a while to understand what I did wrong.... I would like to get a better understanding on how fgets works because I really don't like scanf. Ill look into when I get a chance... if you have any urls that you would recommend I would definitely read them:)

Thank you for your help.

The code does not run correctly..I am trying to figure out why.... non-puz

is your golf.txt formatted exactly as I said? each line with 18 digits should have an EXTRA space at the END of the line, ie after the last digit

and there should be no comments or anything in there...works for me

Spaces should be no problem, using either fscanf() or sscanf(). When you fscanf() for a number, whitespace (spaces, newlines, etc.), are passed over, with no problem.

Nonpuz - why keep the parscores[z] = parscores[z]; line?

Matt, what kind of output do you want, (that is, how do you want it arranged?). I know what you want, but not how you want it to look. If you can show me, I'll match it up.

Works great! thank you,
it was my fault, I forgot to refresh my golf.txt document so it was getting the wrong values.


The way it is outputting should be like GOLFER1: -1 2 5 4 3 3 5 4.........(18times for each golfer)

but instead it is outputting like:

Golfer1: -1
Golfer1: 2
Golfer 1:5
...
...
Upto (18times for each golfer)


Any ideas?

Sure - print the golfer number, then in a for loop, print the real scores, and leave off the newline between the scores.

Just one newline between golfer numbers, only.

Code:

---

#include <stdio.h>

int main() {
    FILE *ifp;
    int ttl_golfers, totalscore, ok, j, i, z, n, p, o;
    int tries [8][18];
    int score [8][18];
    int parscore[18];

    ifp = fopen("golf.txt","r");

    fscanf(ifp, "%d", &ttl_golfers);
    printf("%d golfers played on this golf course:\n", ttl_golfers);

    for (z=0; z < 18; z++)  {
        fscanf(ifp, "%d", &parscore[z]);
        parscore[z] = parscore[z];
    }

    for(n=0; n < ttl_golfers; n++) {
        printf("Golfer #%d Scores:\n", n+1);
        printf("\t1\t2\t3\t4\t5\t6\t7\t8\t9\n\t");
        for(i = 0; i < 9; i++) {
            fscanf(ifp, "%d", &tries[n][i]);
            score[n][i] = tries[n][i] - parscore[i];
            printf("%d\t", score[n][i]);
        }
        printf("\n\n\t10\t11\t12\t13\t14\t15\t16\t17\t18\n\t");
        for(i = 9; i < 18; i++) {
            fscanf(ifp, "%d", &tries[n][i]);
            score[n][i] = tries[n][i] - parscore[i];
            printf("%d\t", score[n][i]);
        }
        printf("\n");
    }

    fclose(ifp);
    return 0;
}

---

Adak is right you dont need the \n stuff in the scanf, just use fscanf(%d and it will look over any whitespace/newlines...

but you have to make sure there is no comments in there and no extra numbers or anything...

the code above displays the results a little nicer and removed the excessive fscanf calls

okay

Adak any ideas?

I tried changing my code a bit....This is as close as I got but i am still far from where I need to be:(

Code:

---

for(n=1; n <= ttl_golfers; n++){
    for(i = 0; i < 18; i++) {
      fscanf(ifp, "%d", &tries[n][i]);
      score[n][i] = tries[n][i]- parscore[i];
    }
    printf("Golfer#%d's score:%d\n\n", n, score[n][j]);
    }

---

Please someone help, I am completely all out of ideas....

Can someone just help me understand how to make the output of my program output like this:

Golfer #1: 1 1 3 4 2 3 4 2 5 -2 1 -2 -3(upto 18 holes)
Golfer #2:.......................... (upto 18 holes)
...

This is my code up until now:

Code:

---

#include <stdio.h>

int main() {
    FILE *ifp;
    int ttl_golfers, totalscore, ok, j, i, z, n, p, o;
    int tries [9][18];
    int score [9][18];
    int parscore[18];

    ifp = fopen("golf.txt","r");

    fscanf(ifp, "%d\n", &ttl_golfers);
    printf("%d golfers played on this golf course:\n\n", ttl_golfers);

    for (z=0; z < 18; z++)  {
        fscanf(ifp, "%d ", &parscore[z]);
    }

    for(n=1; n <= ttl_golfers; n++){
    for(i = 0; i < 18; i++) {
      fscanf(ifp, "%d", &tries[n][i]);
      score[n][i] = tries[n][i]- parscore[i];
    }
    printf("Golfer#%d's score:%d\n\n", n, score[n][i]);
    }

    fclose(ifp);

system("PAUSE");
return 0;

}

---

I'm touching it up, now.

This is a substantial touch up, so be sure and copy it completely!

I did not check the scores for accuracy.

Code:

---

/*

Please someone help, I am completely all out of ideas....

Can someone just help me understand how to make the output of my program output like this:

Golfer #1: 1 1 3 4 2 3 4 2 5 -2 1 -2 -3(upto 18 holes)
Golfer #2:.......................... (upto 18 holes)
...

*/
#include <stdio.h>

int main() {
    FILE *ifp;
    int ttl_golfers, totalscore, i, n;
    int tries [9][18];
    int score [9][18];
    int parscore[18];

    ifp = fopen("golf.txt","rt");

    fscanf(ifp, "%d\n", &ttl_golfers);
    printf("%d golfers played on this golf course:\n\n", ttl_golfers);

    printf("\n\n\nPar is: ");
    for (i=0; i < 18; i++)  {
        fscanf(ifp, "%d ", &parscore[i]);
        printf("%d ", parscore[i]);
    }
    printf("\n\n              Scores Compared with Par\n");
    for(i = 0; i < 80; i++)
      putchar(196);
    printf(" Player  Hole: ");
    printf("1  2  3  4  5  6  7  8  9 10 11 12 13 14 15 16 17 18\n");
    for(i = 0; i < 80; i++)
      putchar(196);
    for(n=0; n < ttl_golfers; n++){
      if(n) putchar('\n');
      printf("Golfer#%d's:  ", n+1);
      for(i = 0; i < 18; i++) {
        fscanf(ifp, "%d", &tries[n][i]);
        score[n][i] = tries[n][i]- parscore[i];
        printf("%3d",  score[n][i]);
      }
    }
    putchar('\n');

    fclose(ifp);

    system("PAUSE");
   
    return 0;

}

---

awesome, thank you.

You're welcome, Matt. Don't expect it so easy next time. I will require more productive work from *you*, and please, no more double posting, on the same exact problem. That will cause most of us to ignore you, and if it continues, the mod will close the thread.

Char 196 is an ascii char that is usually used to draw horizontal lines (like the top or bottom of a box or window border). It makes the output look much better than it would with just hyphens, instead

Adak, THANK YOU! That was wayyy more than I needed, thank you~! your really great.

But, I really was not looking for an easy solution, I was working on this program since this morning, I was trying different loops for hoursss! I was just looking for advice and help with segments of my code. Thank you adak:)


Also, I double posted because it is similar than the last problem but the code is completely different, so I thought maybe it made sense to start on new thread, but I guess not..

I didn't mean to double post.

Take care!
Thank You:)

This is the "simple" version of my new code. It works perfectly and prints perfectly for 8 golfers. The problem is I need it to work for up to 100 golfers and whenever I change the data in my golf.txt file to have more golfers it does not work correctly, why is this? The logic is set up in a way to where it should work no matter what....

Code:

---

#include <stdio.h>

int main() {
    FILE *ifp;
    int ttl_golfers, totalscore, i, n;
    int tries [9][18];
    int score [9][18];
    int parscore[18];

    ifp = fopen("golf.txt","r");

    fscanf(ifp, "%d\n", &ttl_golfers);
    printf("\n%d golfers played on this golf course:\n-------------------------------------\n", ttl_golfers);

    printf("\n\nPar is: ");
    for (i=0; i < 18; i++)  {
        fscanf(ifp, "%d ", &parscore[i]);
        printf("%d ", parscore[i]);
    }
    printf("\n\n");
    for(n=0; n < ttl_golfers; n++){
      if(n) putchar('\n');
      printf("\nGolfer #%d's:  ", n+1);
      for(i = 0; i < 18; i++) {
        fscanf(ifp, "%d", &tries[n][i]);
        score[n][i] = tries[n][i]- parscore[i];
        printf("%3d",  score[n][i]);
      }
    }

    fclose(ifp);

    getch();
    system("PAUSE");
    return 0;

}

---

The arrays tries and scores don't have enough rows for more golfers. For right now, I'd just make these two arrays with 125 rows: tries[125][18], etc.

Later, you'll want to learn to malloc the number of rows that you need, by reading the file data first, and THEN setting up the number of rows, to match that number.

Quote:

---

Originally Posted by matthayzon89

What exactly is a buffer?

---

I do not think anyone has actually answered this directly, but you can check the FOLDOC entry for buffer. With respect to nonpuz's statement, it just means "an array of characters".

For an alternative definition, see buffer ;)

Thank you everyone, you guys are very helpful.

I was wondering, I talked to one of my friends and they said i would be able to use two 1d arrays for this problem if i want to, is that really possible? and is my method probably the best way to go? why? I would just like to understand when it is smart to use 1d vs. 2d arrays [coming from people who have experiences with them]

Matt, You could use a 1-d array of structs (though each struct would have an array inside).
Or I guess you could use a 1-d array of length 18xN (This is really what a 2-d array is, but the compiler simplifies the syntax for you).

The array of structs is probably the best route to go. Structs help to keep your data organized and reduce the possibility of making mistakes such as transposing the array indices (eg writing [j][i] instead of [i][j]).

Quote:

---

Originally Posted by matthayzon89

I was wondering, I talked to one of my friends and they said i would be able to use two 1d arrays for this problem if i want to, is that really possible? and is my method probably the best way to go? why? I would just like to understand when it is smart to use 1d vs. 2d arrays [coming from people who have experiences with them]

---

For what you've done so far (and no more), you could get by with just one 1D array of 18 elements, for the par scores. Everything else can be generated just as it's needed. The problem with that "minimal" type of program design, is that you're stuffed if you ever want to do anything more with the data. Like go back and correct a score - that would be a major pita, with this kind of design.

Moving up, you could use just one 2D array and have the rows organized:

row 1 is for the par scores,
row 2 for the tries of each golfer
row 3 is the 'real' scores of each golfer

In choosing your data structures, use the one that fits best, that makes it really clear what you're doing and, of course, is also efficient. In your case, the design is very clear, and obviously efficient.

In the case of interleaving rows I mention just above, the efficiency is good, but the clarity takes a step backward. If you wanted to look at the scores for golfer #7, would you know right off the bat, what row to look at?

If you said "14", right away, then it might be good for you to use it. If not, I wouldn't use it. The run time of this program is very short, and most of that, depends on the time it takes to read data from the file. So any change in data structure for better efficiency, is going to be a waste of time. If you want a very slight increase in speed, then get a faster hard drive.

The keyboarder entering the data - there's the real bottleneck. :)