Thread: Need help with internet socket program

Likely the data won't fit in a single packet, and your should probably be calling recv() in a loop. (It would be helpful to see some code to know exactly what's happening.) The most common error is ignoring the return value of recv() - recv() returns how many bytes it has but into your buffer. (Which may not equal how many you told it to.) Something like:

Code:

while(1)
{
   ret = recv(my_socket, buffer, buffer_size, 0);
   if(ret == 0) break; // All done.
   if(ret < 0) break; // Error.
   // Otherwise, process. buffer contains ret bytes of data.
   // (If you want to printf() buffer, do a buffer[ret] = 0
   //  (And be sure buffer is at least buffer_size + 1 bytes, if you do.)
}

Also, not to deter you from your exploration of socket programming, but notice how your above example mentions chunked encoding. It's not the only encoding out there, and if you don't decode the data, you'll get weird things. (Like broken Jpegs, in my case - frustrated me for quite a while.) If you're going to do a lot with just HTTP, look into libcurl - it'll keep you from reinventing wheels.

Thanks for the tip. I've tried that already, but what happens is I get an endless loop. I guess it's time you better look at my code, so here it is:

Code:

#include <sys/types.h>
#include <sys/socket.h>
#include <netinet/in.h>
#include <arpa/inet.h>
#include <netdb.h>
#include <fcntl.h>
#include <unistd.h>

#include <iostream>
using std::cin;
using std::cout;
using std::string;
using std::endl;

#define DEST_IP		"74.52.33.82"
#define DEST_ADDR   "google.com"
#define DEST_PORT	80

#define BUFFER_SIZE 4000

char *lookup_host(string name);
int open_socket();
int close_socket(int sockfd);
int send_packet(int sockfd, string data);
int recieve_packet(int sockfd, string &data);

char *lookup_host(char *name) {

	struct hostent *host;
	string ip;
	
	if ((host=gethostbyname(name)) == NULL) {
		cout << "Could not look up host.\n";
		exit(1);
	}
	
	ip = inet_ntoa(*((struct in_addr*) host->h_addr));
	return (char *)ip.c_str();
}

int open_socket() {

	int sockfd;
	struct sockaddr_in dest_addr;

	sockfd = socket(PF_INET, SOCK_STREAM, 0);			// sock file descriptor
	
	dest_addr.sin_family = AF_INET;						// host byte order
	dest_addr.sin_port = htons(DEST_PORT);				// convert destination port to host byte order
	dest_addr.sin_addr.s_addr = inet_addr(lookup_host(DEST_ADDR));		// convert IP address to long type
	memset(&(dest_addr.sin_zero), '\0', 8);				// clear out junk in rest of struct

	// connect to host
	if (connect(sockfd, (struct sockaddr *) &dest_addr, sizeof(struct sockaddr)) == -1) {
	
		cout << "Could not connect to host (" << DEST_IP << ", port " << DEST_PORT << ").\n";
		exit(1);
	}
	
	return sockfd;
}

int close_socket(int sockfd) {

	return close(sockfd);
}

int send_packet(int sockfd, string data) {
	
	int total=0;
	int length = data.length();
	int bytesleft = data.length();
	int n;
	
	while (total < length) {
		
		n = send(sockfd, data.c_str()+total, bytesleft, 0);
		if (n == -1) break;
		total += n;
		bytesleft -= n;
	}
	
	if (n == -1) {
		cout << "Connection closed by host.\n";
		exit(1);
	}

	return 0;
}

int recieve_packet(int sockfd, string &data) {

	int bytes_recieved;
	char buf[BUFFER_SIZE] = {'\0'};
	data=buf;
	
	while (1) {
		bytes_recieved = recv(sockfd, buf, BUFFER_SIZE, 0);
		if (bytes_recieved == 0) break;
		if (bytes_recieved < 0) break;
		data+=buf;
	}
		
	return 0;
}

int main() {

	string request = "GET / HTTP/1.1\nHost: www.google.ca\n\n";
	string response;
	char buffer[BUFFER_SIZE] = {'\0'};
	int bytes_recieved;
	
	int sockfd = open_socket();	// create new sending socket
	send_packet(sockfd, request);
	recieve_packet(sockfd, response);
	close_socket(sockfd);
	
	cout << "Data recieved:\n";
	cout << response << endl;
	
	return 0;
}

I also liked your suggestion about using libcurl, however I somehow couldn't get curl functions to resolve when I compiled it. The only libraries produced when compiling libcurl on Mac OS X were libcurl.3.dylib and libcurl.3.la, and adding these to the Xcode project didn't seem to resolve it. So I'm still trying this method, although it would be nice if I could get libcurl working.

Thanks.

Ah.
First: HTTP headers are separated by return and a newline: "\r\n" in C. (or C++) (Although google seems to respond either way.)
Second: HTTP 1.1 is by default a persistant ("Keep-Alive") connection. You could send another request after you're done, so google won't immediately close the connection. (Though I would have thought that if you waited long enough, google would eventually terminate it for you, and your original would, at that point, dump the results. (But it could be a several minute wait... nothing desired.))
You can either interpret the data as it comes, de-encoding it to see when you've got it all or you can specify "Connection: Close" as a header, which will (should) cause the responder to close the connection after the response. So, the only change you should need:

Code:

string request = "GET / HTTP/1.1\r\nHost: www.google.ca\r\nConnection: Close\r\n\r\n";

Sorry to hear you're having trouble with libcurl - I know nothing about Macs myself. Good luck! (I use libcurl whenever HTTP and C come together in my mind...)

(If you're interested: HTTP's RFC, and relevant sections: General message format and Persistant connectsion)