Trying to get an IP address from "www.facebook.com"

[HelpfulPerson]

I'm using Beej's tutorial as Salem suggested, and although painful, I finally got it linked up properly with the Windows library.

While I don't get any compiler errors or warnings from this program, I get the following remark from the system with the WSAddressToString function :

WSAAddressToString failed with : 10014,
System remark : The system detected an invalid pointer address in attempting to use a pointer argument in a call.

Or at least that's what my program outputs. I'm not sure which parameter it thinks is invalid, as far as I'm concerned I used all the right ones.

#include <stdio.h>
#include <stdlib.h>


#define _WIN32_WINNT 0x0501


#include <winsock2.h>
#include <Ws2tcpip.h>


int main ( )
{
    WSADATA wsaData;


    if ( WSAStartup(MAKEWORD(2,2), &wsaData ) )
    {
        fprintf(stderr, "WSAStartup failed with : %d,\nSystem remark : %s", WSAGetLastError(), gai_strerror(WSAGetLastError()));
        return 1;
    }
    else
        printf("WSAStartup initialized!\n\n");


    int status = 0;


    DWORD strlen = 0;


    struct addrinfo hints, * res = NULL, * temp = NULL;


    struct sockaddr_in * ipv4 = NULL;
    struct sockaddr_in6 * ipv6 = NULL;


    char * ipver = malloc(10);


    if ( !ipver )
    {
        perror("Malloc");
        WSACleanup();
        return 1;
    }


    memset(ipver, 0, 10);
    char ipstr[INET6_ADDRSTRLEN];


    memset( &hints, 0, sizeof(hints) );
    hints.ai_family = AF_UNSPEC;
    hints.ai_socktype = SOCK_STREAM;
    hints.ai_flags = AI_PASSIVE;


    if ( (status = getaddrinfo("www.facebook.com", NULL, &hints, &res )) )
    {
        fprintf(stderr, "getaddrinfo failed with : %s", gai_strerror(status));
        free(ipver);
        WSACleanup();
        return 1;
    }


    for ( temp = res; temp; temp = temp->ai_next, strlen = 0 )
    {
        if ( temp->ai_family == AF_INET )
        {
            ipv4 = ( struct sockaddr_in * )temp->ai_addr;
            ipver = strcpy(ipver, "IPv4");


            if ( WSAAddressToString( (LPSOCKADDR)ipv4, sizeof(*ipv4), NULL, ipstr, &strlen ) )
            {
                fprintf(stderr, "WSAAddressToString failed with : %d,\nSystem remark : %s", WSAGetLastError(), gai_strerror(WSAGetLastError()));
                free(ipver);
                WSACleanup();
                return 1;
            }
        }
        else
        {
            ipv6 = ( struct sockaddr_in6 * )temp->ai_addr;
            ipver = strcpy(ipver, "IPv6");


            if ( WSAAddressToString( (LPSOCKADDR)ipv6, sizeof(*ipv6), NULL, ipstr, &strlen ) )
            {
                fprintf(stderr, "WSAAddressToString failed with : %d,\nSystem remark : %s", WSAGetLastError(), gai_strerror(WSAGetLastError()));
                free(ipver);
                WSACleanup();
                return 1;
            }
        }


        printf("The IP address for \"www.facebook.com\" is...\n\n");


        printf("\n%s : %s\n", ipver, ipstr);
        memset(ipver, 0, 10);
    }


    freeaddrinfo( res );
    free(ipver);


    if ( !WSACleanup() )
        printf("Clean up was sucessful, program exited normally!");
    else
    {
        fprintf(stderr, "WSACleanup failed with : %d,\nSystem Remark : %s", WSAGetLastError(), gai_strerror(WSAGetLastError()));
        return 1;
    }


    return 0;
}

Any help is appreciated.

[oogabooga]

Check out WSAStartup function (Windows)
Note what WSAStartup returns on success.
So there is no error and therefore the error string is meaningless.

[HelpfulPerson]

Check out WSAStartup function (Windows)
Note what WSAStartup returns on success.
So there is no error and therefore the error string is meaningless.

I already knew WSAStartup returns 0, that's why if it returns as true, I displayed an error message. Is there something that I'm not seeing in that? It was the WSAAdressToString function giving me problems...

[vart]

I already knew WSAStartup returns 0, that's why if it returns as true, I displayed an error message. Is there something that I'm not seeing in that? It was the WSAAdressToString function giving me problems...

It does not return true.. It returns error code you are ignoring

You are missing in the function description:

WSAGetLastError function is not needed and should not be used.

[oogabooga]

I already knew WSAStartup returns 0, that's why if it returns as true, I displayed an error message. Is there something that I'm not seeing in that? It was the WSAAdressToString function giving me problems...

Sorry about that. Don't know what I was thinking.

strlen is the name of a C library function, so it's a bad variable name.
But that's probably not the error.
I'll think about it ....

EDIT: Hmmm, it does say that "On input, this parameter specifies the length of the buffer pointed to by the lpszAddressStringparameter."
And of course on output it will be the length of the returned string (including the null terminator, apparently.)
Could be the problem. Could you test that?

[vart]

I have run your code using VS2012... After fixing buffer length - it works ok

WSAAddressToString function (Windows)

lpdwAddressStringLength [in, out]

On input, this parameter specifies the length of the buffer pointed to by the lpszAddressString parameter. The length is represented in bytes for ANSI strings, and in WCHARs for Unicode strings. On output, this parameter returns the length of the string including the NULL terminator actually copied into the buffer pointed to by the lpszAddressString parameter. If the specified buffer is not large enough, the function fails with a specific error of WSAEFAULT and this parameter is updated with the required size.

PS. You are passing as input 0 - so the function fails since it thinks there is not enough space in the buffer

[HelpfulPerson]

It does not return true.. It returns error code you are ignoring

You are missing in the function description:

If it returns non zero on error, I consider that true. You are correct though, in that case I should've set status to the return value and turned that value into a string. Also, the input value is the length of the string and the output value is the length of the actual string? Ugh, that's the error I missed then.