Thread: using free()

Are you sure you are freeing the correct element? You have to free the deleted nodes because you want to claim the memory allocated to them. If you don't free the deleted elements, you will leak out the memory.

If you post your code, we will help you more. I think your problem is in somewhere else and probably you are deleting the wrong node.

(Also known as SPEKTRUM)

Heres my code:

Code:

void close_connection(CONNECTION_DATA *con)
{
	if (con->ch) {
		kill_ch(con->ch);
	}
	
	UNLINK(con,first_con,last_con,next,prev);
	close(con->sd);
	log_to_file(LOG_NORMAL,"Connection closed on socket #%d",con->sd);
	free(con);
	con = NULL;
}

and heres the function kill_ch:

Code:

void kill_ch(CHAR_DATA *ch)
{
	UNLINK(ch,first_ch,last_ch,next,prev);
	log_to_file(LOG_NORMAL,"Character %s(%s) on socket #%d was removed.",
		ch->name, ch->con->ip_addr, ch->con->sd);
	free(ch);
}

When I free(ch), it frees ch just fine. but when I free(con) it crashes the program. any help? Thanks.

have you used a debugger? That would be the way i would go. you'd find the bug with one...i think gdb and ddd are pretty standard with the major linux distros...