copying files from a directory into another one

[smoking81]

Hello there!
I tried to make an exercise in which i had to COPY *regular* files which have *execution* rights from a source directory into a new one (to be created if it doesn't exist). The 2 directories have are passed in the command line.
My solution seems to work, although I think the most elegant think would be to set the rights for the copy in the same way they're set for the original... I tried to do this with this line:

   if ( (fdDest=open(path_copia,O_CREAT|O_TRUNC|O_WRONLY,(statbuff.st_mode &S_IRWXU)|(statbuff.st_mode &S_IRWXG)|(statbuff.st_mode &S_IRWXO) ) ) <0 )

but it seems to have problem for the group rights which are not copied identically in the new file.. What is wrong in your opinion?
many thanks! Bye

#include <sys/stat.h>
#include <sys/types.h>
#include <dirent.h>
#include <fcntl.h>
#include <unistd.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int main (int argc, char *argv[])
{
   if (argc!=3)
   {
      printf("USAGE: programname source destination\n");
      return 1;
   }

   DIR *srcPtr;
   
   if (mkdir(argv[2],0777)<0)
   {
      printf("Unable to create directory %s (probably it already exists)\n",argv[2]);
   }
   srcPtr=opendir(argv[1]);
   if (srcPtr==NULL)
   {
      printf("BAD OPENDIR %s\n",argv[1]);
      return 1;
   }
   
   struct dirent *dirPtr;
   struct stat statbuff;
   int fdSrc,fdDest;
   char *path_copia;
   unsigned int len_path_copia;
   unsigned char c;

   chdir(argv[1]);
   while ((dirPtr=readdir(srcPtr))!=NULL)
   {
      if (lstat(dirPtr->d_name,&statbuff)<0)
      {
         printf("BAD LSTAT\n");
         return 1;
      }
      if (S_ISREG(statbuff.st_mode) &&
         (statbuff.st_mode & S_IXUSR )) //IT's A REGULAR FILE WITH EXECUTION rights for the owner
      {
         //COPY----
         len_path_copia=strlen(argv[2]);
         len_path_copia+=1+strlen(dirPtr->d_name);
         path_copia=(char *)malloc(len_path_copia*sizeof(char));
         
         strcpy(path_copia,argv[2]);
         strcat(path_copia,dirPtr->d_name);
         printf("Copying %s in %s\n",dirPtr->d_name,path_copia);
         if ( (fdDest=open(path_copia,O_CREAT|O_TRUNC|O_WRONLY,(statbuff.st_mode &S_IRWXU)|(statbuff.st_mode &S_IRWXG)|(statbuff.st_mode &S_IRWXO) ) ) <0 )
         {
            printf("BAD OPEN %s\n",path_copia);
            return 1;
         }
         if ( (fdSrc=open(dirPtr->d_name,O_RDONLY))<0 )
         {
            printf("BAD OPEN %s\n",dirPtr->d_name);
            return 1;
         }
         while (read(fdSrc,&c,1)==1)
         {
            write(fdDest,&c,1);
         }
         close(fdSrc);
         close(fdDest);
         free(path_copia);
      }
      
   }
   chdir("..");
   closedir (srcPtr);
   return 0;
}

[matsp]

(statbuff.st_mode &S_IRWXU)|(statbuff.st_mode &S_IRWXG)|(statbuff.st_mode &S_IRWXO)

The commutative rules of & and | states that this is the same thing, but much shorter and easier to read:

(statbuff.st_mode & S_IRWXU | S_IRWXG | S_IRWXO)

I'm not sure why your file would have differnet rules than what you open it as - but perhaps your umask is affecting the mode?

--
Mats

[Salem]

If the file is read-only, you won't be able to write to it.
Write the file, close it, then set the required permissions.

Also check the http://www.research.att.com/~gsf/man/man1/umask.html

[Valery Reznic]

umask setting affected permission bits of the created files.
You can either:
umask(0);
somewhere near start of your program,
or, after file was created
fchmod(filedes, permissions)

[smoking81]

If the file is read-only, you won't be able to write to it.
Write the file, close it, then set the required permissions.

Also check the http://www.research.att.com/~gsf/man/man1/umask.html

yes it's true i forgot to add

umask (0);

at the beginning of the program...
thanks!

[brewbuck]

yes it's true i forgot to add

umask (0);

at the beginning of the program...
thanks!

That is not the best solution. The umask is designed to give the user a certain amount of control over the default permissions of files. Unless you have a very good reason, and this isn't one, you should not override the umask provided by the user's environment. The better solution is to explicitly chmod() the file to the proper mode.

[Byakuya]

Can't you give me pls an example of a program that copies even the files from a subdirectory ...
I tryed to figure it out and somebody told me that i most do it recursivly and i don't know how to do it
Pls help me!

[matsp]

Aside from the fact that you are waking an old thread whichis against the forum rules, so I should not reply to this thread and make it worse, what is wrong with the posted code at the beginning of the thread?

Edit: Ah sorry: The above program doesn't recurse through subdirectories. There is, however, a FAQ entry for "how to list files in a directory" which should help you solve that problem.

--
Mats