Carl Cash! My new game!

Okay, it's not a game yet it's just a concpet with 2 rooms and the ability to move around... this is like my 3rd game, my first being Tic-tac-toe and my second being Yahtzee... this is like a text based adventure game... enjoy!

I need lots of feedback and advice, such as how can I have the player use the arrow keys instead of w,a,s and d... also is there an easier way to make sure people don't go through walls? Thanks in advance!

Code:

switch (userinput)
{
    case 8:
            code for north;
            break;
    case 6:
            code for east;
            break;

................

}

the other two are 2 (south) and 4 (west)....also u can use virtual keys. this example is crued and uses a custom header file (attached):

Code:

if (input == K_UP)
	{
		User_Location_Y = User_Location_Y++;
	}

	if (input == K_DOWN)
	{
		User_Location_Y = User_Location_Y--;
	}

	if (input == K_LEFT)
	{
		User_Location_X = User_Location_X--;
	}

	if (input == K_RIGHT)
	{
		User_Location_X = User_Location_X++;
	}

i forgot to post this, a crude way of making "walls"

Code:

/* Check user position.*/
	if (User_Location_Y == 25)
	{
		cout <<"You cannot continue in this direction\n";
		User_Location_Y--;
		getch();
	}

	else if (User_Location_Y == -25)
	{
		cout <<"You cannot continue in this direction\n";
		User_Location_Y++;
		getch();
	}

	else if (User_Location_X == 25)
	{
		cout <<"You cannot continue in this direction\n";
		User_Location_X--;
		getch();
	}

	else if (User_Location_X == -25)
	{
		cout <<"You cannot continue in this direction\n";
		User_Location_X++;
	}

Originally posted by RoD

User_Location_Y = User_Location_Y++;
User_Location_Y = User_Location_Y--;
User_Location_X = User_Location_X--;
User_Location_X = User_Location_X++;

RoD, this code should not be used. It's behavior is undefined. In C++, the same variable cannot be modified twice in the same statement (without the use of a comma).

User_Location++ would suffice.

i'm jus giving him an idea. This program was written in my first week of c++, and i dont suggest it be directly used, but it gives an idea.

You might just want to adjust it then before advising to use
it while it might be infested with beginner mistakes.

im thinking rod should update that one program he keeps showing noobs

1) i never told him to use it. its newbie code i used as an example .

2) im involved in too much other crap to update it. it was never written to be good, it was written to help me learn a little. there is, somewhere, a version written in november that is de-newb and well done, but i havent been able to find the source.

Its a crued example, nothing more.

Originally posted by RoD
1) i never told him to use it. its newbie code i used as an example .

Yeah, Well if it's bad code then simply don't post it, That's like
offering people drugs knowing it's bad for them
Erhm...oke that example sucked, anyway.......

such as how can I have the player use the arrow keys instead of w,a,s and d... also is there an easier way to make sure people don't go through walls?

I showed him how he could do it, i never said to do it. Look i said it was newb code, i said it could be made better, and thats the bottom line. Dont like the example? Then dont use it, i didnt give him code to use, i gave him an idea. Use the idea or not, i dont honestly care.

Originally posted by RoD
i gave him an idea. Use the idea or not, i dont honestly care.

Well you should, As beginners probably would love to follow
a forum's veteran's advice. That's what i think at least.

I care if his program works out, not if he uses or goes off my particular example. I'm not going to argue over the quality of the example when i myself said its only an idea, dont use it.

Originally posted by RoD
I showed him how he could do it, i never said to do it.

Why post code if you don't mean them to use it???

to give him an idea or a direction...

Thank you RoD but if you looked at my code you could understand that I'm not retarded and I'm not an udder n00b, the problem was how do I read input from the arrow keys(or the virtual keys I guess). I mean like getch() or cin or what?