Trouble running a program Visual Studio

Hi,

I'm learning FOR loops and have made this code:-

Code:

using namespace std;

int main()
{
int array1[2];
int i = 0;
int total = 0;
int semitotal =0;

for(i=0;i<3;i++)
	{
		cout << "Enter a number " << endl;
		cin >> array1[i];
	}
	cout << "outside 1st FOR loop" << endl;

for(i=0;i<2;i++)
	{
		cout << "number was" << array1[i] << endl;
	}
	cout << "outside 2nd FOR loop" << endl;
	
for(i=0;1<3;i++)
	{
                 array1[i] = semitotal;
                 semitotal += total = total;
	}
	cout << "outside 3rd FOR loop" << endl;
	cout << "array total is" << total << endl;

	//cin.get();
	system("pause");
	
	return 0;

}

When I build it in Visual Studio it always says the following:-

The following breakpoint cannot be set:

At int loopcount;

Unable to parsethe function:int loopcount;

So I installed Dev C++ and it runs the program, but the console window won't remain open despite trying both cin.get(); and system("pause"); .

Could anyone offer me out with either these two issues?

Many thanks.

umm, for one your loops go out of bounds. As for the breakpoint, im guessing that is what it is referring to.

for(i=0;1<3;i++)

is that a typo or do you really want 1<3 as the condition?

Originally Posted by Swerve

int loopcount;

Well as a compiler I think I'd also find it hard setting a breakpoint on a line of code that doesn't exist, at least not in what you posted.

Thank You to everyone for their advice, it is extremely appreciated!

I have cleaned up my code:-

Code:

#include <iostream>

using namespace std;

int main()
{
int array1[2];
int i = 0;
int total = 0;
int subtotal = 0;

for(i=0;i<3;i++)
	{
		cout << "Enter a number " << endl;
		cin >> array1[i];
	}
	cout << "outside 1st FOR loop" << endl;

for(i=0;i<3;i++)
	{
		cout << "number was" << array1[i] << endl;
	}
	cout << "outside 2nd FOR loop" << endl;
	
for(i=0;i<3;i++)
	{
		subtotal += array1[i];
	}
	cout << "outside 3rd FOR loop" << endl;
	cout << "array total is" << subtotal << endl;

	//cin.get();
	system("pause");
	
	return 0;

}

When the terminal window is closed, it says:-

Run-Time Check Failure #2 - Stack around the variable 'array1' was corrupted.

If anyone can offer me advice on the matter, I'd be very grateful.

Thanks!

You still have the problem Raigne pointed out. You are looping outside your array's boundary. You have a 2 element array, but you are looping through : 0,1,2.

Also :

Code:

for(i=0;i<3;i++)
	{
		array1[i] = subtotal;
                subtotal += total = total;
	}

you don't need the variable subtotal. And subtotal += total = total isn't doing want you want.

Try

Code:

total += array[i];

Now try changing your for loop : i<2;

Try selecting your code and pressing Alt+F8 to let Visual Studio indent for you. Simple as can be.

Thank you to you both!

I thought that array[2] created an array of 3 segments (0,1 and 2), but now I know the '2' includes the 0 element.

For loop fixed (assignment is right to left!).

Many thanks


EDIT - Elysia, that's a great tip. never knew you could do that.