compiler error C2064

hey
can anyone help me about this error.
The error is in bold.

Code:

---

#include <iostream>
#include <conio.h>
using namespace std;

char        const BLANK = ' ';        //constant: symbols used for the drawing (some could be local)
char        const LEAF = '#';
char        const WOOD = '|';
char    const EOL = '\n';       
int        height;                                        //height of the tree
int                branchLines;

int main()
{
        void drawATrunk();
        void drawBranches();
        cout << "\nEnter the height of tree: ";
        cin >>height;
        if (height > 4)
        {
                drawBranches();
        }
       
        while(!_kbhit());
        return 0;
}

void drawBranches()
{
        void drawABranch();
        for (branchLines(1); branchLines <= height-2; ++branchLines)
        {       
                drawABranch();
        }
}

void drawABranch()
{
        for (int spaces(1); spaces <= (height-2)-branchLines; ++spaces)
        {
                cout << BLANK;
        }
        for (int leaves(1); leaves <= (branchLines*2)-1; ++leaves)
        {
                cout << LEAF;
        }
}

void drawATrunk()
{
        int trunkLine;
        trunkLine = 1;
        while ( trunkLine <= 2) // for each line in the truck
        {
                for ( int spaces(1); spaces <= (height - 3); ++spaces)        //draw the spaces on the left
                {
                        cout << BLANK;
            }
                cout << WOOD;                        //draw the truck
                cout << EOL        ;                //go to next line
                ++trunkLine ;
        }
}

---

Not sure what C2064 says, but you cannot initialize an already-declared variable, you must assign to it; make it branchLines = 1.

thanks. I didn't mention it.

Quote:

---

term does not evaluate to a function taking 'number' arguments

---

In other words, it thinks it's a function. I'd avoid () with built-in types and just use =.
Also, function prototypes goes into the header or at the start of the source file, not inside your functions.
It's typically easier to read "const char" rather than "char const" - just a suggestion.
And avoid global variables - make them local and pass them as arguments if need be.

Quote:

---

Originally Posted by Elysia

In other words, it thinks it's a function. I'd avoid () with built-in types and just use =.
Also, function prototypes goes into the header or at the start of the source file, not inside your functions.
It's typically easier to read "const char" rather than "char const" - just a suggestion.
And avoid global variables - make them local and pass them as arguments if need be.

---

Good suggestions, except -- function prototypes don't have to be global. Most of the time they are made global, but I can think of at least one book which used local function prototypes as a matter of course.

I might also add that conio.h is non-standard and you should avoid it if possible.

Code:

---

char    const EOL = '\n';

---

You probably don't need that constant . . . '\n' is generally accepted for printing newlines . . . .

> function prototypes don't have to be global. Most of the time they are made global, but I can think of at least one
> book which used local function prototypes as a matter of course.

Just out of curiosity, since local functions (functions defined inside other functions) currently aren't allowed in C/C++, what would be the advantage of local prototypes?

scoping, I guess.

After reading this

http://www.dcs.bbk.ac.uk/~roger/cpp/week5.htm

I realized that a function could be defined in one source file, and then prototyped, locally, in another, which would be useful in limiting the scope in the second file. That's good to know.

But how would that be used in a real program? You'd have header files and stuff.

Quote:

---

Originally Posted by robatino

After reading this

http://www.dcs.bbk.ac.uk/~roger/cpp/week5.htm

I realized that a function could be defined in one source file, and then prototyped, locally, in another, which would be useful in limiting the scope in the second file. That's good to know.

---

In most cases - if you want to make function local to some source file - you implemt it in this source file as static.

If you start adding function prototypes to 2-3 source file to make it visible only in these files - you are asking for troubles - when function prototype is changed and you forgot to update all the prototypes arond the code

>> In most cases - if you want to make function local to some source file - you implemt it in this source file as static.

Just an FYI: Use an unnamed namespace instead of static. That use of static has been deprecated.

Using global variables for just loops is bad, really bad.

branchlines should be a local variable, and height should be passed as a parameter.

Quote:

---

Originally Posted by dwks

Good suggestions, except -- function prototypes don't have to be global. Most of the time they are made global, but I can think of at least one book which used local function prototypes as a matter of course.

---

But then we'll start to question if local prototypes are really a good idea.
As was mentioned, all functions are global in nature, and to limit them from being extern, you can use static to limit it to internal linkage. Prototypes should, regardless, be stored in header files.

I just mentioned local prototypes because Elysia's post made it sound like you had to use global prototypes. (In which case the OP might have been wondering why it even compiled . . . .) All of Elysia's other points had "avoid" or "typically", except for the prototype one.

Quote:

---

In other words, it thinks it's a function. I'd avoid () with built-in types and just use =.
Also, function prototypes goes into the header or at the start of the source file, not inside your functions.
It's typically easier to read "const char" rather than "char const" - just a suggestion.
And avoid global variables - make them local and pass them as arguments if need be.

---