Thread: Kill me for asking this (STL issues)

Got this small code which results in "windows has encountered a problem with this and has to close it down etc etc " error
It happens at user input

Code:

#include<iostream>
#include<list>
#include<string>

using namespace std ;

struct Movie
{
	string MovieName;
	string MovieDirector;
	string MovieActor;
	string MovieActress;
	string MovieGenre;
	int MovieRating;

};

int main()
{
	string MName;
	string name;
	
	list<Movie> Movie_List;
	list<Movie>::iterator ListIterator;

	cin>>name;

	ListIterator = Movie_List.begin();
	ListIterator->MovieName = name ;
	ListIterator = Movie_List.begin();
	cout<<ListIterator->MovieName;
	return 0 ;


}

Can you please post the actual error?

--
Mats

Originally Posted by matsp

Can you please post the actual error?

--
Mats

error C2679: binary '<<' : no operator defined which takes a right-hand operand of type 'class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char>

my newbie brain cant make anything of this error...

googled the error for about an hour but to no avail...

*tears in my eyes *

Perhaps you forgot to include a header, or perhaps something else. Try posting a small program that demonstrates the error.

damn my noobish negligence....i had forgotten to include string header

now it compiles fine ...it even links fine...but when i enter a movie name (which is read by cin>>name;

the program crashes saying

"windows has encountered a problem with this and must be closed etc etc"

edited my original post which now contains the entire code that i am trying to run

should i commit suicide ?

You forgot to include <string>; you only have <iostream>. Which, on MS, unfortunately is enough for the string class, but not for its I/O routines.

Furthermore: dereferencing the begin iterator of an empty list is undefined! Use push_back() to actually get the movies into the list:

Code:

Move A_Movie;
std::cin >> A_Movie.MovieName;
Movie_List.push_back(A_Movie);

Indeed...it works now...many thanks to all...( and dont rejoice...it wont be long before i come up with more annoying questions)

thanks