Thread: wifstream crashes the program

> 2. This will not fail because there is a statement len++ for the '\0';
Except by doing so, you step off the end of the memory you allocated, write a \0 into someone else's memory, then get abnormal program termination.

You need to allocate len+1 slots if you want to read len items, then append a \0.

read() and write() are for dealing in binary data, or bulk characters. But since you're casting, you don't have characters ready in the proper form, so it must be binary data.

> What do you mean that I am writing outside my memory.

Code:

int len = 10;
char *array = new char[len];
read( array, len );  // reads len chars, the array is full, no room for a \0
len++;
array[len] = '\0';  // oops, you lose, but maybe not immediately...

You might seem to get lucky on a few attempts, but sooner or later, this kind of code will cause a crash.

Well if you allocated len+1, then read len, that might be a start.

Originally Posted by Wicket

And how must I fix it, or is there a easier way to write and read wstrings and strings to a file?

Must I use operator<< and operator>>?

I already told you a solution, and so did CornedBee:

Originally Posted by CornedBee

Writing binary data using the wide streams is simply wrong, end of story. Use the narrow streams if you want to deal in binary data.

And operators << and >> are strictly for text and not for binary.
But also try to fix the len problem as Salem mentions.