Why does this keep happening?

OK so I made a program where the user can pick what to do. I created a simple 'if' statement to handle what he types and what he gets.

Here it is:

Code:

---

if ((answer = 'R') || (answer = 'r'))
        {
        path1();
        }
       
        if ((answer = 'S') || (answer = 's'))
        {
        path2();
        }

---

But for some reason, it always goes to Path1..... I think its because it's said first. I don't know how to fix this. Even if i type in s, it goes to path1. Help!

A misstake you will continue to make over time, and it will frustrate you just as much every time because later you wont see it even though you know about it.

a = 1 makes the value of a, 1
a == 1 , checks to see if a is equal to 1

Bump up the warning level of your compiler, to tell you when you might be making a mess of it.
http://cboard.cprogramming.com/showp...80&postcount=3

If you're using dev-c++ or code::blocks as your IDE (you didn't mention), then you can set the same flags as well.

And learn how to indent. Stupid indenting will cause you to miss obvious issues.

Quote:

---

Originally Posted by Wraithan

A misstake you will continue to make over time, and it will frustrate you just as much every time because later you wont see it even though you know about it.

a = 1 makes the value of a, 1
a == 1 , checks to see if a is equal to 1

---

Indeed. One little habit that can be helpful, if you intend a comparison with a constant value, to put the constant on the left hand side of the expression;

Code:

---

if( 1 == a) something();

if ('R' == answer) something_else();

---

This will trigger a compiler error should you do assignment (one = sign) rather than comparison.

It doesn't stop problems if the code is comparing two variables (as either assignment will often be acceptable to the compiler). But being in the habit of asking yourself what goes on the left hand side will often have a side effect of making you think about what you're typing.....

Quote:

---

Originally Posted by Wraithan

A misstake you will continue to make over time, and it will frustrate you just as much every time because later you wont see it even though you know about it.

a = 1 makes the value of a, 1
a == 1 , checks to see if a is equal to 1

---

Thank you, now I can finally work on my stupid Database thing lol. Thanks for everyone else for explaining the compiler issues.