Thread: yes or no help

Can you post a little bit more of code, particulary the declaration and assigmnet of Y and N, and the reading or the input?

--
Mats

Right, "cin >> Y,N" doesn't do even remotely what [I think] you expect it to do. N is never set a value here. Y is set to whatever you input, e.g. 'y' or 'a' or something.

Later when you do "if (Y)" you are essentially saying "if (Y != 0)", which if you didn't happen to press CTRL-@ [1], will be true.

My proposal would be to have a single char varable, (call it ch for example), and then compare that with the constant 'y' and 'n' for the respective cases.


[1] And assuming that the input functions allow this character to be passed through - which may or may not be the case.

--
Mats

No, the usage of chars here is wrong. You have the wrong idea with regard to variables.

To simplify this, think of a char in C++ as space in computer memory to store any character. Memory locations are handled by an address. This could get quite messy if you had to remember memory location 1,435,742 for the place where your char is located at. So this is why we have variables. You name the variable, and the compiler/linker/runtime (depending on a bunch of things) will handle how the addressing is handled.

In your case, you have two variables named Y and N. They do not correspond to the characters 'Y' or 'N'. They are just named Y and N. They each can be used independently to store any character.

Code:

cin >> Y;

This will read one character, and store the result in Y. From there, you can test upon what character it is.

Code:

if(Y == 'Y')
{
    /* do something here */
}

This is why your choice of a variable name of Y and N is not good in this context. It can get kind of confusing.

Instead, as your condition you have this:

Code:

if(Y)

This is wrong because, in C++, boolean expressions are resolved nunerically based upon the following rules: Any non-zero result in C++ is true; zero is false. Therefore your condition is still true unless Y happens to hold a character numerical value of 0 (not to be confused with a character representation of 0, which is written in C++ as '0'. We're talking more about '\0'.).

BTW, <iostream.h> should be <iostream> unless you're using an ancient compiler, in which case, you need to update. Also, you still have name as an int. I'm pretty sure you were told it should be std::string. If you do change that, you should include <string>.

Hope this helps.

Also

>#include <iostream.h> // decepricated header. use <iostreeam>

>int password; // try to always avoid global variables. Make them local

>main() // main returns an int. Use int main() or int main ( void )

Originally Posted by Matt51723

Code:

     if(Y)
     {
          cout << "blah.\n";
          }
          else
          {
              if(N)
              cout << "blah.\n";
              }

You need to learn how to indent properly. Each } must be on the same level as the {, and you should NOT just include an additional tab (or a sets of spaces) where you feel like it. They should be reserved for new blocks.
And in a block, the following lines should NOT be the same level as the block element itself, as can be seen from if (N). cout << "blah.\n"; under if (N) should be indented further.
Here's how it should look like:

Code:

	if(Y)
	{
		cout << "blah.\n";
	}
	else
	{
		if(N)
			cout << "blah.\n";
	}

That looks much better, doesn't it?
It also lets me easier see that you can just as well do an if else:

Code:

	if(Y)
	{
		cout << "blah.\n";
	}
	else if (N)
	{
		cout << "blah.\n";
	}

OF course, the code is flawed, but the logic behind the indentation fixes and if/else is sound and true.

Originally Posted by swgh

int main ( void )

Not necessary in C++...