Thread: classes and functions

Code:

class zombie {
};

See there ^ Class zombie is missing ; at the bracket at the end, I added it in red.

Code:

user.takedamage (attackpower);//'user' undeclared (first use this function)

There's no such thing as "user" in your class - what's it supposed to be? You must declare (or define) something that's used!

Same thing here with class player - all classes must begin with { and end with }; (notice the ; at the end).

Code:

bob.takedamage (attackpower);//'bob' undeclared (first use this function)

Same thing there - you must define bob.

Code:

zombie bob;//no matching function call for 'zombie::zombie()' //candidates are zombie::zombie (const zombie&), and 'zombie::zombie(int)'
player user;//same as above only 'player::player()'

For both classes, you have but one constructor - and that constructor takes an int as argument. Here you don't pass any argument and the compiler can't find a constructor that takes no arguments, so it complains.
Declare a constructor that takes no arguments or simply pass in the appropriate argument to the constructor.

Code:

while (bob.life() == 1 and user.life() == 1) {

and is not a keyword; what you're looking for is probably && (basically and in C++).

Code:

    int life () {
        if ( hp > 0 ) {
            return 1;
        }
        if (hp <= 0 ) {
            return 0;
        }
    }

Suggest you do do just

Code:

    int life () {
        if ( hp > 0 ) return 1;
        return 0;
        }
    }

The compiler can't know with your IFs that you're actually returning a value at all control paths - this will fix the warning.
Same goes for player::life.

Code:

        if (attacktype = 1) {
            gnaw();
        }
        if (attacktype = 2) {
            bite();
        }
        if (attacktype = 3) {
            moan();
        }

= is assignment, not comparison. What you're looking for is ==.

And really start using tabs instead of spaces. I really recommend it - it's much better.
Also remember from before, when they said big names for your classes? Try that. Do Zombie/CZombie or Player/CPlayer. It's better that way.

Firstly, class declarations end with a semicolon:

Code:

class Zombie
{
    ...
};

And then user and bob are indeed undeclared in the member functions of zombie and player. user and bob only exist in the function battle. If you wish the member functions to know about them, you'll need to pass them into those functions.

Alternatively each attack method might return the amount of damage, and you call takedamage for user and bob in the function battle, using this return value.

In battle you fail to construct the objects because the only constructor takes an int (initial hp). It might help if you implemented these constructors and then created your objects, calling the existing constructor:

Code:

Zombie bob(500);
Player user(100);

Just out of curiosity, is there a way to easily transfer all the variables of a class from one function to another. Because I want the user to be able to have stats such as defence and attack that can be improved and carry over without having to use another variable to transfer it from battle to battle.

I think that it is good to have to pass your player object by reference to the functions that need to access the player stats. You could make it a singleton or even use global variables, but I suggest not doing so at this point.

And finally, I just want to see if I get this, each function has its own separately defined variables, classes, and structures, so you have to carry them over in the function arguments. But what if I make it an inline function?

We say that a function may have local variables. Declaring a function as inline does not change that (inline cannot change how a function functions), and in fact the compiler is free to ignore the inline keyword as it sees fit.

I believe you should slow down a tad and start learning basic syntax since at this point you've done a lot of silly, simple mistakes. Start thinking about how you want it all to work and create a simple class that is correct - where the syntax matches what it should before moving on more advanced things.
And keep all stats within the class itself.
As for inline, whether or not it's inline, it's a function. And for functions, there are rules. The compiler will make sure your code properly if it inlines and that's IF. You don't have to worry about it.