String Input & Output

Code:

// Stopping input with an empty string
#include <iostream>
#include <cstring>
using namespace std;

int main()
{
    int i = 1;
    char temp[80];
	char string[80]; // room for 255 strings
	

    cout << "\n\nEnter some strings - (blank to exit)"
         << " \nfirst string: ";
    cin.getline(temp, 80);
    while (temp[0] != '\0')
    {
        cout << "String " << i << " : " << temp << "\nnext string: ";
        cin.getline(temp, 80);
        string == strcat(string," ");
		string == strcat(string,temp);
		i++;

    }

    cout << "\n\n";
    
	//for (int index = 0; index < i; index++)
    cout << string ;

}

i updated the code

input: bill loves to eat
output: $ loves to eat

$ is a weird character that show up. i don't know what it is.

Don't use char arrays unless you want to get into dynamic memory (At this level, I don't think you want to). Use std::string instead.

Currently you have an array named array of char *'s. That means each element of the array isn't a char, but a pointer to a char. This could be fine, except your char *'s aren't pointing anywhere significant and it's amazing it works as well as it does. You have to allocate memory and then copy. Otherwise, you need a two dimensional char array to hold everything (and even that might not work). As I said earlier, std::string is probably the best way to go about it.

Don't use void main(). Use int main().

Originally Posted by MacGyver

Don't use char arrays unless you want to get into dynamic memory (At this level, I don't think you want to). Use std::string instead.

Currently you have an array named array of char *'s. That means each element of the array isn't a char, but a pointer to a char. This could be fine, except your char *'s aren't pointing anywhere significant and it's amazing it works as well as it does. You have to allocate memory and then copy. Otherwise, you need a two dimensional char array to hold everything (and even that might not work). As I said earlier, std::string is probably the best way to go about it.

Don't use void main(). Use int main().

not sure what you by the std::string, can you give a example.

i updated the code.

i notice that i can change both line 20 and 21 to
strcat_s(string, " ");
and
strcat_s(string, temp);
that will get rid of all the warnings.

and the result is the same.
but my "bill" is still not showing up, why?

Chapter 59. Don't write namespace usings in a header file or before an #include

ok i put the namespace after the #include.

Originally Posted by nicz888

not sure what you by the std::string, can you give a example.

http://www.cprogramming.com/tutorial/string.html

Originally Posted by MacGyver

http://www.cprogramming.com/tutorial/string.html

i kind of fix the concat string issue i had, now can you help me on the "bill" issue?

Code:

        string == strcat(string," ");
		string == strcat(string,temp);

What's this supposed to do?
== is comparison and not assignment. Plus strcat appends to the string for you; you don't have to assign.
And it's still better if you change to std::string; this is C++, after all.