Pointer in Function problem

im trying to make my badguy pointer work. but i have no idea where the problem lies

this is the function code

Code:

int Monsters::DistanceToPlayerX(int curX,int PlayerX,Monsters& pBadGuy){
     *pBadGuy->GetX() = curX;
     ASCIIMan.GetX() = PlayerX;
     return (X+PlayerX);
     };

the error is
character.h: In member function `int Monsters:istanceToPlayerX(int, int, Monsters&)':
character.h:37: error: base operand of `->' has non-pointer type `Monsters'

becase pBadGuy is declared as reference - you are asked not to use dereference operator ->
Use
pBadGuy.GetX()

oh i always thought that i had to use -> evertime i use a pointer and try to use a method

Originally Posted by lilhawk2892

oh i always thought that i had to use -> evertime i use a pointer and try to use a method

It is correct. But you do not use a pointer

On the other hand, the very fact that a "getter function" can be an lvalue probably means you have a very poor design; your getter function should be const, and returning a copy, not a reference to the actual data (if you DO need a reference, at least return a const reference).

Indeed, and since it is not a pointer, you may wish to change the naming of the parameter.

ya i do have poor design. its not my specialty.. for example. heres my entire character.h file

Code:

#ifndef CHARACTER_
#define CHARACTER_
#include "headers.h"
#include <string>

class Character
{
      public:
      //methods:
                void Init(int NewX, int NewY, char NewChar);
                void Draw();
                int Walk(int newX, int newY);

                void Attack(Character);
                int  GetHealth();
                int  GetX();
                int  GetY();
                char GetName();
                
private:
      //attributes
                char name;
                int  Health;
                int  X;
                int  Y;
                char ASCIICharacter;
};
class Monsters : public Character {
      public:
             void MonsterAI();
             int DistanceToPlayerX(int curX, int PlayerX);
             int DistanceToPlayerY(int curY, int PlayerY,Monsters *pBadGuy);
             void MoveTowardsPlayer(int curX, int curY,Monsters *pBadGuy);
             private:
             Monsters * pBadGuy;
};
int Monsters::DistanceToPlayerX(int curX,int PlayerX){
     *pBadGuy->GetX() = curX;
     ASCIIMan.GetX() = PlayerX;
     return (X+PlayerX);
     };

int Monsters::DistanceToPlayerY(int curY,int PlayerY,Monsters *pBadGuy){
     Y = curY;
     ASCIIMan.GetY() = PlayerY;
     return (Y+PlayerY);
     
void Monsters::MoveTowardsPlayer(int curX, int curY, Monsters *pBadGuy){\
//movement code
};

void Monsters::MonsterAI(){
      if (DistanceToPlayer() < 1){
                           MoveTowardsPlayer();
                           };
      };
#endif

//ignore distancetoplayerY, im waiting till i have a working distancetoplayerX and then just changing what i need.

does anybody have any tips on what i should do with this code to help debug it and properly design it?

DistanceToPlayerX is missing pBadGuy parameter.
DistanceToPlayerY is never using pBadGuy parameter.
MoveTowardsPlayer has a syntax error with that "\" at the end.
And remember to use const on all functions that does not modify any class data. And add const to any and all references which you are not changing.
Those are a few.