My script slows down how do I fix this??

I’ve been working on this script all day and I finely got it working but has some problems still
What the script does is searches for a pixel inside of x1 y1 x2 y2 bye its color.
Ok here’s my problem I wonted to see how fast it worked so I had the mouse fallow each pixel it was checking. And I realized that it starts off searching really fast but slows way way way way down if you have it searching inside of a 100 by 100 pixel area.

Why is this slowing down and how can I fix it? Also if you guys have any suggestions on making it faster besides the problem I’m having let me know : ) thanks

Code:

#include <iostream>
#include <stdlib.h>
#include <windows.h>



int main()
{
cout << "pick a color" << endl;
system("pause");
POINT pt;
GetCursorPos(&pt);
HDC hdc = GetDC(NULL);
         DWORD color = GetPixel(hdc, pt.x, pt.y);
         unsigned int r = GetRValue(color);
         unsigned int g = GetGValue(color);
         unsigned int b = GetBValue(color);
         cout << "red: " << r << endl;
         cout << "green: " << g << endl;
         cout << "blue: " << b << endl;

int XL, YL, xcount, ycount, TLXBackup;
cout << "Top Left" << endl;
system("pause");
POINT TL;
GetCursorPos(&TL);
cout << "Bottem Right" << endl;
system("pause");
POINT BR;
GetCursorPos(&BR);
TLXBackup = TL.x;
XL = BR.x - TL.x;    // x2  x1
YL = BR.y - TL.y;    // y2  y1
xcount = 0;
ycount = 0;
POINT TR;
Loop:
HDC hdc2 = GetDC(NULL);
         DWORD color2 = GetPixel(hdc2, TL.x, TL.y);
         unsigned int R = GetRValue(color2);
         unsigned int G = GetGValue(color2);
         unsigned int B = GetBValue(color2);
         //cout << "RED: " << R << endl;
         //cout << "GREEN: " << G << endl;
         //cout << "BLUE: " << B << endl;
         //cout << " xcount " << xcount << endl;
         //cout << " ycount " << ycount << endl;
         //cout << "x " << TL.x <<endl;
         //cout << "y " << TL.y <<endl;
         SetCursorPos(TL.x,TL.y);
         if (( r == 255) && ( g == 255 ) && ( b == 255 ))
         system("pause");

         if (( r == R) && ( g == G ) && ( b == B ))
         {
         ending:
         cout << TL.x << endl;
         cout << TL.y << endl;
         SetCursorPos(TL.x,TL.y);
         cout << "color found" << endl;
         cout << "RED: " << R << endl;
         cout << "GREEN: " << G << endl;
         cout << "BLUE: " << B << endl;
cin.get();
cin.ignore();
return 0;
         }
         if ( xcount == XL)
            {
            TL.y++;
            TL.x = TLXBackup;
            ycount++;
            xcount = 0;
            }
         if ( ycount == YL )
         {
         goto ending;
         }
         xcount++;
         TL.x++;
         goto Loop;
}

It seems you are leaking resources:

Remarks

The application must call the ReleaseDC function for each call to the GetWindowDC function and for each call to the GetDC function that retrieves a common device context.

You have some pretty nasty goto's there. Consider structuring your code better.

- full of goto's
- no indentation
- no functions

And that's code, not script. Probably a semantics thing.

Originally Posted by Bubba

And that's code, not script. Probably a semantics thing.

Technically yes but with the unstructured, hard to read way it is written, it could easily be mistaken for one.

Sorry guy’s lol this is only my 4th day of C++ and that’s my 1st actual program so I haven’t really developed a style yet.
Thank vary much anon that helped a lot I had the GetDC in one of the loops and that’s why it was slowing down but as you can see I can still vary well improve it. Also I couldn’t get
“If not” statement to work for this code that’s y its kind of backwards so could some one help me put this into a if not statement? This is how my book was telling me to do it

Code:

if (( r != R) && ( g != G ) && ( b != B ))

Also I couldn’t get
“If not” statement to work for this code that’s y its kind of backwards so could some one help me put this into a if not statement?

What do you intend it to do?

just switching around the statement in my code make it look neater and easer to under stand. if you look at it. It kind of ends in the center of the loop.

Well...

Code:

( r != R) && ( g != G ) && ( b != B )

is equivalent to:

Code:

!(r == R) && !(g == G) && !(b == B)

which is equivalent to:

Code:

!!(!(r == R) && !(g == G) && !(b == B))

which can be simplified to:

Code:

!(r == R || g == G || b == B)

ok got it working thank you : )

I might be inclined to help you out if your signature was worded a little less offensively