Thread: Need feedback on code

Seriously consider using better indentation. It really does help others view your code and get a real feel for what it does at a glance.

As far as optimizing it.... not sure you really could worry about optimiziation at this level. With that said, I don't think you need two different ints for this. Consider something like this:

Code:

#include <iostream>

int main()
{
	int i, j, num = 5;
	char star = '*';
	
	for(i=num;i>0;i--)
	{
		std::cout << i;
		for(j=0;j<i-1;j++)
		{
			std::cout << star << i;
		}
		std::cout << std::endl;
	}
	
	return 0;
}

Very similar, so there's not that much room to really improve it.

Yeah, there is a minimum amount of work that needs to be done to solve any problem, and it looks like you have done it. Any optimisation would just be a side-effect of refactoring, methinks.

I would write something like:

Code:

#include<iostream>

using namespace std;

int main()
{
    for (int i = 5; i > 0; --i)
    {
        for (int j = 1; j < i; ++j)
        {
            cout << i << '*';
        }
        cout << i << endl;
    }
}