Hello World V 03 02 02

Code:

// Hello World! V 3_02_02
// Use of functions and variables
// by SRS & the assistance of the
// fine people at cprogramming.com

#include <iostream>
#include <string>
using namespace std;

string get_name()
{
  string firstName;
  string lastName;
  string fullName;
  for(;;)
  {
    cout << "Please Enter Your First Name:" << endl;
    cin >> firstName;
    cout << "Please Enter Your Last Name:" << endl;
    cin >> lastName;
    fullName = firstName + " " + lastName;
    char yn;
    for(;;)
    {
      cout << "Please verify your correct name is " <<  fullName << endl;
      cout << "By entering \"Y\" or \"Yes\" if it is correct" << endl;
      cout << "or \"N\" or \"No\" if it is incorrect:" << endl;
      string verify;
      cin >> verify;
      int verifySize = verify.size();
      if(verifySize <= 0)
      {
        cout << "Please enter \"Y\" or \"N\":" << endl;
        continue;
      }
      else
      {
        yn = verify[0];
        break;
      }
    }
    if(tolower(yn) == 'y')
    {
      cout << "Hello World, from " << fullName << "!!"<< endl;
      break;  //  Exit the loop upon verification
    }
    else
    {
      cout << "Please try again:\n" << endl;
      continue;  //  Repeat the loop for any other answer
    }
  }
  return fullName;
}
int main()
{
  string newUser = get_name();  //  Get & Verify User's First & Last Name
  /*
  |Actions -----|
  |to ----------|
  |be ----------|
  |performed ---|
  |on ----------|
  |new ---------|
  |user --------|
  */
  cout << newUser << ", this is the end of the road!" << endl;
  system ("PAUSE");
}

Ok many versions into this and that is what it looks like. Please feel free to suggest improvements, changes, possible errors, or any other comment you like before I move on to something else. Thanks to all of you who have helped me getting started with this.

Since you're only saving one name, you can use getline to get the entire line. That will also allow somebody with three (or more) names (e.g. John Paul De La Salle). The getline function will read until the end of the line, rather than stopping at a space like cin >> does.

Originally Posted by Daved

Since you're only saving one name, you can use getline to get the entire line. ...

getline is new to me but I will look into it now.

This "thing" I am writing is odd as it's only purpose is to contain working samples of code structure for my learning... I have never used an object oriented language before and I think where I am going with this next is to construct something like personnel records so I actually will end up saving more than just a name. I want to use this to get into the abilities of classes. Any suggestions on that would be greatly appreciated.

Till then checking out getline...

Example of getline:

Code:

std::string myName;

std::cout << "Enter your full name: ";
getline ( std::cin, myName );

std::cout << "\nHello " << myName << std::endl;

Also, you should include <cctype>, which is where tolower() resides.

Originally Posted by dwks

Also, you should include <cctype>, which is where tolower() resides.

Code:

#include <iostream>
#include <string>
using namespace std;

Right now this is what I have, yet it works with caps or lower input. Is it necessary? or is the compiler searching for it even though I did not instruct include? other reason it works without including <cctype>? Thanks for the help!

Yes, always add the appropriate #include even if it works without it. In some cases you will try something else that will suddenly not work, or if you change to a different compiler or give your code to someone else it also might not work.

I agree with Daved. If you enable warnings in the compile, it should tell you that you have "function called without a prototype". This is often not a problem, but sometimes it is:
On 68K family processors, the return of a pointer is in register A0, but numbers are returned in D0. So guess what happens if you mess up your prototype and the compiler gets it wrong? It uses the wrong register to pick the result from, and your code doesn't work right!

Other such things exist too - calling printf() in x86_64 Linux will not work right without the compiler knowing that printf is a "varargs" function - but only when you use floating point arguments, so most of the time it works fine without the right header, then all of a sudden it fails when you change the code.

--
Mats

Originally Posted by matsp

I agree with Daved. If you enable warnings in the compile, it should tell you that you have "function called without a prototype".

I agree also, as this I am nearing my first 24 hours in C++ lol...
However, warnings are enabled, and it did not produce one. (I have included it now anyway)
Using Dev-C++ V 4.9.9.2

Anyway, thanks for all the advice. I am soaking it up as much as I can.

It doesn't have to give a warning (and rarely will... usually you will get an error or nothing). It might work 100&#37; perfectly because one of your other includes might include the header that declares that function. The standard allows the compiler to be flexible with these things, it's just up to you to be vigilant.

Originally Posted by Daved

one of your other includes might include the header that declares that function.

That is the reason I posted my current includes... This is probably a question most know the answer to but... where could I look these up? Know of a good site or anything?

ty again

I usually look them up in a book (TC++PL by Stroustrup or The C++ Standard Library by Josuttis). You can also use reference sites of standard libraries, but it's not always easy to find them in there. dinkumware.com, sgi.com, or msdn or possible options that I've used myself.

to construct something like personnel records so I actually will end up saving more than just a name. I want to use this to get into the abilities of classes.

Perfect! You can make an employee class with member variables like FirstName, LastName, Title, Salary, etc. And, you can have member functions like GetLastName(), IncreaseSalary(), etc. The object-name might be an employee number.

But, take it one step at a time... You'll probably want to learn more about the basics, including functions and reading/writing to the disk before you start working on an object oriented "database".

Originally Posted by DougDbug

Perfect! You can make an employee class with member variables like FirstName, LastName, Title, Salary, etc. And, you can have member functions like GetLastName(), IncreaseSalary(), etc. The object-name might be an employee number.

But, take it one step at a time... You'll probably want to learn more about the basics, including functions and reading/writing to the disk before you start working on an object oriented "database".

I am already familiar with functions and variables and the other basics similiar to an event driven language, its the object oriented stuff that is new. struct - class ... Here is where I am so far in my latest learning tool...

Code:

// Hello World! V 5_00_00
// struct and class
// by SRS & the assistance of the
// fine people at cprogramming.com
* --------------------------------------------------------------------INCLUDE*/
#include <iostream>  //  cin/cout
//#include<iomanip>
//#include<fstream>
#include <string>  //  string
#include <cctype>  // tolower
using namespace std;
/* ---------------------------------------------------------------------STRUCT*/
struct contacts
{
    string firstName;
    string lastName;
    string companyName;
    string homeAddress;
    int id_number;
    int age;
};
/* --------------------------------------------------------------------DECLARE*/
void add_someone();  //  required to compile
/* ------------------------------------------------------------------FUNCTIONS*/
int yes_no()  //  Return 1(yes) or 2(no) or re-enter invalid answers
{
    char yn;
    for(;;)
    {
        cout << "Please enter \"Y\" or \"N\"" << endl;
        string verify;
        getline(cin, verify);
        int verifySize = verify.size();
        if((verifySize <= 0) || (verifySize >= 2))  //  next line:
        //  User enters other than single character reply, re-enter
        {
            cout << "ERROR: YOUR ANSWER IS INVALID..." << endl;
            cout << "Please try again..." << endl;
            continue;
        }
        else  //  User enters a single character reply
        {
            yn = verify[0];  //  Should not be necessary
            yn = tolower(yn);  //  Force lower input
            if(yn == 'y')  //  User enters Y or y only
            {
                return 1;
                break;
            }
            else if(yn == 'n')  //  User enters N or n only
            {
                return 0;
                break;
            }
            else  //  User enters any other reply, re-enter
            {
                cout << "ERROR: YOUR ANSWER IS INVALID..." << endl;
                cout << "Please try again..." << endl;
                continue;
            }
        }
    }
}
void get_name()  //  Get & Verify the first and last name, offer repeat
{
    string fullName;
    for(;;)
    {
        contacts person;
        cout << "Please Enter Your First Name:" << endl;
        getline(cin, person.firstName);
        cout << "Please Enter Your Last Name:" << endl;
        getline(cin, person.lastName);
        fullName = person.firstName + " " + person.lastName;
        cout << "Please verify your name is correct: " << fullName << endl;
        int reply = yes_no();
        if(reply)
        {
            cout << "Hello World, from " << fullName << "!!"<< endl;
            break;  //  Exit the loop upon verification
        }
        else
        {
            cout << "Please try again:\n" << endl;
            continue;  //  Repeat the loop for any other answer
        }
    }
    add_someone();
}
void add_someone()  //  Add a user or exit program
{
    cout << "Do you wish to add a new contact now?" << endl;
    int reply = yes_no();
    if(reply)
    {
        get_name();
    }
    else
    {
        cout << "Very well, have a nice day!" << endl;
    }
}
/* -----------------------------------------------------------------------MAIN*/
int main()
{
    add_someone();
    system ("PAUSE");
}

PLEASE ANYONE/EVERYONE with any suggestions, ideas, alternatives, improvements, post it... my feelings will not be hurt, I am eager to learn and willing to do what ever it takes...

THANK YOU ALL who have helped me learn so far, your time is GREATLY appreciated!

Use bool instead of int for true/false situations (like the reply variable or the yes_no() return value).

Instead of calling add_someone from inside get_name(), just make a loop inside add_someone(). Otherwise, if you keep adding people then the stack will overflow because the functions will keep calling each other over and over created a deeper and deeper stack that never unwinds.