Thread: Returning A Value From a Seperate Function

I just tried getItemPrice in another program and it did work, I tried every order of negative, non-multiples of 5, and other numbers that I could and it worked every time.

As for the other things, thanks a bunch, it makes sense now.

It says there's a parse error if I don't put the semi-colon there, which I know is strange, but it shuts the compiler up. I took it out and still had the same problems, so that's not what's affecting it. Also, I need the semi-colon after int main() and the extra } at the end of the code or else the compiler will complain about that too.

Alright, so I've gotten my code to this, everything is perfect (or would be if I could get this problem worked out)

Code:

#include <iostream>

using namespace std;

int getItemPrice()
{
	int price;
	// making sure cost is not negative
		do
		{
			cout << "Enter cost of item (in cents) :" << endl;
			cin >> price;
		} while (price <= 0);

		// making sure cost is a multiple of 5

		while ((price&#37;5)!=0)
		{
			cout << "Price of item must be multiple of 5 cents." << endl;
			cout << "Enter cost of item (in cents) :" << endl;
			cin >> price;

		// again making sure cost is not negative
		while (price <= 0)
		{
			cout << "Enter cost of item (in cents) :" << endl;
			cin >> price;
		}

		}
	return price;
}

int getCoins(int price)
{
	int coin = 0;
	int balance = 0;

	// start entering coins
	while (balance < price)
	{
	cout << "Current Balance: " << balance << endl;
	cout << "Enter coin value (200, 100, 25, 10, 5) :" << endl;
	cin >> coin;

	// for invalid coins
		if ( coin != 200 && coin != 100 && coin != 25 && coin != 10 && coin != 5)
		{
			cout << "Invalid coin." << endl;
		}
		else
		{
			balance += coin;
		}
	cout << "You paid " << balance << " cents for something that cost " << price << " cents." << endl;

	return balance;
}

int dispenseChange(int change);
{
		// obtain number of quarters given out

	line 70 ----> int quarter = change/25;
		int changeafterq = change % 25;

		// using the remaining money owed try find number of dimes required

		int dime = changeafterq/10;
		int changeafterd = changeafterq % 10;

		// same thing with nickels

		int nickel = changeafterd/5;


		cout << "Giving " << change << " cents in change." << endl;

		// Finally, enter integer values of each coin being given back.

		cout << "Quarters: " << quarter << endl;
		cout << "Dimes: " << dime << endl;
		cout << "Nickels: " << nickel << endl;
}


int main();
{
	int price;
	int	paid;
	int	change;

	price = getItemPrice();
	paid = getCoins(price);

	change = paid - price;

	dispenseChange(change);
}
}

The compiler warns me about:
70: 'change' undeclared (I marked line 70 in the code, but it's not in my actual program)

For some reason I guess change isn't being brought up to the function dispenseChange from main.

If I can get this to work then I think I'll finally be done.

Thanks again.

Originally Posted by Adrian

It says there's a parse error if I don't put the semi-colon there, which I know is strange, but it shuts the compiler up. I took it out and still had the same problems, so that's not what's affecting it. Also, I need the semi-colon after int main() and the extra } at the end of the code or else the compiler will complain about that too.

Okay. You've successfully determined that your car runs better after you've bolted a large plastic banana to it. Next up, installation of the gyroscopes.

Originally Posted by brewbuck

Okay. You've successfully determined that your car runs better after you've bolted a large plastic banana to it. Next up, installation of the gyroscopes.

If you're suggesting that it's not necessary to have these in the code, then I get your point, but I'm just going with what the compiler says. I get 0 on the assignment if it doesn't compile properly, so I'm not going to go with what's "theoretically correct" if it's not working in this situation.

Originally Posted by Adrian

If you're suggesting that it's not necessary to have these in the code, then I get your point, but I'm just going with what the compiler says. I get 0 on the assignment if it doesn't compile properly, so I'm not going to go with what's "theoretically correct" if it's not working in this situation.

Randomly adding semicolons until it compiles is hardly a better choice. Exactly what compiler errors do you get if you don't use them? There is no reason why you need a semicolon after main().

You've obviously got an extra '{' somewhere in your code, probably far from the site of the actual warning/error.

Code:

int getCoins(int price)
{
	int coin = 0;
	int balance = 0;

	// start entering coins
	while (balance < price)
	{
	cout << "Current Balance: " << balance << endl;
	cout << "Enter coin value (200, 100, 25, 10, 5) :" << endl;
	cin >> coin;

	// for invalid coins
		if ( coin != 200 && coin != 100 && coin != 25 && coin != 10 && coin != 5)
		{
			cout << "Invalid coin." << endl;
		}
		else
		{
			balance += coin;
		}
        }
	cout << "You paid " << balance << " cents for something that cost " << price << " cents." << endl;

	return balance;
}