Thread: Cin newline space problem... or something

For my first C++ program, I made a little text editor for the sake of understanding the whole fopen stuff. With my background knowledge of PHP this is going rather well, but I have encountered a problem.

Code:

#include<iostream.h>
#include<cstdio>
#include<string>

void main () {
 cout<<"Welcome to FedEdit...\n";
 char filename[255];
 cout<<"Please enter the file path to open. \nNote that it will be interpreted as a textfile\nKeep it small, yes?\n";
 cin>>filename;
 cout<<"You chose "<<filename<<"\n\n";
 FILE * filePointer;
 filePointer = fopen(filename,"r+");
 if(filePointer) {
  cout<<"File Contents:\n\n";
  char line[81];
  char *return_code;

  while(!feof(filePointer)) {
   return_code = fgets(line, 80, filePointer);
   cout<<line;
  }
  cout<<"\n\n--------------------------\nOkay, now enter new file content:\n";
  cout<<"a line only containing a period will end the writing mode.";
  cout<<"please do not enter more than 80 characters per line. thank you.\n\n--------------------\n";
  char newline[81];
  rewind(filePointer);
  while(strcmp(newline,".")) {
   cin>>newline;
   if(strcmp(newline,".")) {
    fputs(newline,filePointer);
    fputs("\r\n",filePointer);
   }
  }
  fclose(filePointer);
 } else cout<<"ERRORZ";
 
}

this is the source. Basicially, you open a file of choice, it echoes it, and then you re-write it. The problem?

Well, it interprets spaces as newlines. Actually, it doesn't.

Code:

  while(strcmp(newline,".")) {
   cin>>newline;
   if(strcmp(newline,".")) {
    fputs(newline,filePointer);
    fputs("\r\n",filePointer);
   }
  }

see that part?

well that's the problem. Apparently, when encountering a space, the loop re-loops with the next word, causing

Code:

    fputs("\r\n",filePointer);

to render it as new line.


Now, why is this happening, how do I fix this?

Any other suggestions for a better way of coding are appreaciated as well!
I'm a beginner, sorry.

Well, wow. Thanks for that, I guess.

I know about the int main(), but it would return an error when I tried doing that originally.

same goes for the iostream without the .h


I originally used <string.h> but this guy told me to use <string> instead.

Well, I'll get right on to fixing everything as you said, and you also put light on my problem. Thanks for that! I'll probably edit this post, or make a new post after I'm done.

Thanks a lot!

Visual C++ 6. Oddly enough, it worked this time. I guess I misspelled it or something, I have no idea.

However, I have yet another problem

Code:

#include <iostream>
#include <string>
#include <fstream>
using namespace std;

int main () {


 cout<<"Welcome to FedEdit...\n";
 string filename;
 cout<<"Please enter the file path to open. \nNote that it will be interpreted as a textfile\nKeep it small, yes?\n";
 getline (cin,filename);
 cout<<"You chose "<<filename<<"\n\n";

 ifstream myfile;

 myfile.open (filename);
 if(!myfile.fail()) {

  cout<<"File Contents:\n\n";
 /*
  string line;

  while(!feof(filePointer)) {
   fgets(line, 80, filePointer);
   cout<<line;
  }
  cout<<"\n\n--------------------------\nOkay, now enter new file content:\n";
  cout<<"a line only containing a period will end the writing mode.";
  cout<<"please do not enter more than 80 characters per line. thank you.\n\n--------------------\n";
  char newline[81];
  rewind(filePointer);
  while(strcmp(newline,".")) {
   cin>>newline;
   if(strcmp(newline,".")) {
    fputs(newline,filePointer);
	fputs("\r\n",filePointer);
   }
  }
  fclose(filePointer);
	 */
 } else cout<<"ERRORZ";
 

}

// getline with strings

this is how far I got converting the code to proper code, but at this point it gives me the error:

C:\Program Files\Microsoft Visual Studio\MyProjects\jkhjk\asfd.cpp(18) : error C2664: 'void __thiscall std::basic_ifstream<char,struct std::char_traits<char> >:pen(const char *,int)' : cannot convert parameter 1 from 'class std::basic_string<char,
struct std::char_traits<char>,class std::allocator<char> >' to 'const char *'
No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called

as well as the warning (here we go again...)

C:\Program Files\Microsoft Visual Studio\MyProjects\jkhjk\asfd.cpp(46) : warning C4508: 'main' : function should return a value; 'void' return type assumed
Error executing cl.exe.

but is main() really supposed to return anything?

And more importantly, what's up with the first thing?

I had some more errors, but I was able to fix those myself...

To my knowledge you can not use fopen with std::string as it is a c-style function and expects a cstring.

As far as your warning goes, as it says you need to return something in main.

Code:

int main()
{
        ...
        return 0;    // Instead of 0 use EXIT_SUCCESS if you #include <windows.h>
}

A friend gave it to me... Well, if it's free, then I'll look into it. Good thing somebody tells me that before I get used to the compiler.

Thanks once again, CornedBee!