Array Question

I know this seems like a dumb question but it's been some time since I've worked with programming and I had a simple array question. I was wondering how I can fill this empty array with squared numbers corresponding to the original num_List array.

Is this right at all?

Also do the square and cubed functions not work with arrays?

Code:

// ***************************************
//Doug Miller
//Programming Assignment 1, Program 1
//Square and cube examples
//****************************************

#include <iostream>
#include <iomanip>
#include <math.h>
using namespace std;

#define MAX 10

int num_List [MAX] = 
{1, 2, 3, 4, 5, 6, 7, 8, 9, 10};

int square_Nums[MAX] = {0};

int cubed_Nums[MAX] = {0};

using namespace std;

int main()
{
    //Declarations
	
	int i =0;
	int squared_Term = 0;

	for (i = 0; i < MAX;)
	{
		square_Nums[i] = (num_List[i] * num_List[i]); 
		i++;
	}

	//Gather input

	//Make calcuations

	//Display output
	
	/* int p =0;

	for (i = 0; i < MAX;)
	{
        cout << square_Nums[p] << std::endl;
		p++;
	}
	*/

    return 0;

	std::cin.get();

}//END OF MAIN

The std::cin.get() is useless after the return statment, because it will never be executed. Your compiler would likely warn you about "unreachable code" if you enabled its warnings.

There's no need to use global variables. Variables local to main() would work as well.

Code:

	for (i = 0; i < MAX;)
	{
		square_Nums[i] = (num_List[i] * num_List[i]); 
		i++;
	}

Why not this?

Code:

	for (i = 0; i < MAX; i++)
	{
		square_Nums[i] = (num_List[i] * num_List[i]); 
	}

In C++, this

Code:

int square_Nums[MAX] = {0};

is the same as

Code:

int square_Nums[MAX] = {};

Your comments don't really make sense. The values are hard-coded into the program . . .

I made the changes you suggested and now when I run the program I get a bunch of non sense for the output, and then the program eventually crashes! lol

Code:

// ***************************************
//Doug Miller
//Programming Assignment 1, Program 1
//Square and cube examples
//****************************************

#include <iostream>
#include <iomanip>
#include <math.h>
using namespace std;

#define MAX 10

using namespace std;

int main()
{
	int num_List [MAX] = 
	{1, 2, 3, 4, 5, 6, 7, 8, 9, 10};

	int square_Nums[MAX] = {};

	int cubed_Nums[MAX] = {};

	int i =0;
	int squared_Term = 0;

	for (i = 0; i < MAX; i++)
	{
		square_Nums[i] = (num_List[i] * num_List[i]); 
	}

	//Display output
	
	int p =0;
	for (i = 0; i < MAX; p++)
	{
        cout << square_Nums[p] << std::endl;
	}

    std::cin.get();
    
     return 0;

}//END OF MAIN

Well, you're bound to get garbage if you do this:

Code:

	int p =0;
	for (i = 0; i < MAX; p++)
	{
        cout << square_Nums[p] << std::endl;
	}

You're using i here, p there. Stick with one variable!

Code:

	for (i = 0; i < MAX; i++)
	{
        cout << square_Nums[i] << std::endl;
	}

Thanks got it! Appreciate it!

Oh, and one other thing I forgot to mention: you're not using anything from math.h, so unless you plan on using pow() or something, you can get rid of it.

Yeah I took it out for the final run; it was in there because I was trying to use the sqrt and cubed functions but they didn't seem to be working with arrays.

That's right, they only work with one number. But you can call them on your arrays, element by element.

Code:

	for (i = 0; i < MAX; i++)
	{
		square_Nums[i] = pow(num_List[i], 2.0); 
	}