"expected primary-expression before 'else'"

This is a discussion on "expected primary-expression before 'else'" within the C++ Programming forums, part of the General Programming Boards category; -------------------------------------------------------------------------------- I am tyring to write a simple program to display distance traveled. here are my instructions: Write a program ...

  1. #1
    Registered User
    Join Date
    Sep 2007
    Posts
    36

    "expected primary-expression before 'else'"

    --------------------------------------------------------------------------------

    I am tyring to write a simple program to display distance traveled. here are my instructions:

    Write a program that asks the user for the speed of a vehicle (In miles per hour) and how many hours it has traveled. It should then use a loop to display the distance the vehicle has traveled for each hour of that time period. Her is an example of the output


    What is the speed of the vehicle in mph? 40
    How many hours has it traveled? 3

    Hour Distance Traveled
    --------------------------------------------------
    1 40
    2 80
    3 120

    Input validation:
    Do not accept any negative number for speed and do not accept any value
    less than one for time traveled.


    The output should be formatted and aligned according to the above.

    Here is my code so far:
    Code:
    CPP / C++ / C Code:
    #include <cstdio>
    #include <iostream>
    #include <cmath>
    using namespace std;
    
    int main ()
    {
    int speed, distance, time, a, b;
    a=1;
    b=a*speed;
    
    cout << "Distance Program";                                         
    cout << "\n\n\nWhat is the speed of the vehicle in mph?\n";         
    cin >> speed;                                                       
    cout << "\nHow many hours has it traveled?\n";       
    cin >> time; 
    
    if (time >1 && speed >0)
      
           cout << "\n\nHour                  Distance Traveled"; 
           cout << "\n--------------------------------------\n";
            
            while (a<= time)
                    {
                      a++;
                      cout << "\n";
                      cout << a;                    
                      printf("                      ");
                      cout << b;
                      cout << "\n";
                      
                      }      
                 return 0;
    
    else   
        
          {
           cout << "\n\nYou have entered invalid data\n\n";
           system("pause");
           }
    }
    I keep getting the "expected primary-expression before 'else'" error and the "expected ";" before 'else'" error. Am I missing something very simple? Imay not know much about programming, but I thought this was straight-forward

  2. #2
    Deathray Engineer MacGyver's Avatar
    Join Date
    Mar 2007
    Posts
    3,211
    Include braces for the if statement. You're missing them.

    And incidentally, if you use system(), include cstdlib.

  3. #3
    Registered User
    Join Date
    Oct 2006
    Location
    Canada
    Posts
    1,243
    first, you should use either C or C++ code. the majority youve used here looks like C++, so remove your 'printf' and use cout like you have been doing. also, the only header you need for the code to run is iostream, so you can remove the other two unless you explicitly require them.

    it looks like your missing a pair of braces in your if block. your else block is fine, but you need them around your first if block too.

    also, at the start of main, why do you do 'b = a*speed'? speed isnt even initialized so you dont know what value speed will have anyways. and whatever its value is, it wont change if you multiply it by 'a' which is 1 in this case.

    also, if you set 'a' to 1, then in your while loop you check if a<= time. you know time > 1 because of the if statement. the only thing you do to a is increase it, so it starts at 1, then 2, etc. i think you need to rethink that.

    hope it helps.

  4. #4
    Registered User
    Join Date
    Sep 2007
    Posts
    36
    Thanks for the quick replies. I always forget something simple like braces.

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. expected primary expression
    By lilhawk2892 in forum C++ Programming
    Replies: 10
    Last Post: 11-22-2007, 07:50 PM
  2. expected primary expression before "." token
    By melodious in forum C++ Programming
    Replies: 4
    Last Post: 07-11-2007, 05:39 AM
  3. Screwy Linker Error - VC2005
    By Tonto in forum C++ Programming
    Replies: 5
    Last Post: 06-19-2007, 03:39 PM
  4. recursion error
    By cchallenged in forum C Programming
    Replies: 2
    Last Post: 12-18-2006, 09:15 AM
  5. Please Help - Problem with Compilers
    By toonlover in forum C++ Programming
    Replies: 5
    Last Post: 07-23-2005, 11:03 AM

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21