std::string getline() weirdness

I'm having issues with the getline() function.

The code is on a different computer so to save typing time variable names and cout'ed strings are not excact except for the placement of the \n. The code goes something like this:

Code:

#include <string>
#include <otherNeededheader(s)>
using std::string;
using std::cout;
using std::cin or endl or what other crap you see here; //not exact ;-)
...

string s1;
string s2;
string s3;

cout<<"\n Please enter something: ";
getline(cin, s1);
cout<<"\n\n Please enter something else: ";
getline(cin, s2);
cout<<"\n Please enter something else: ";
getline(cin, s3);

cout<<"\nSomething else!!!\n\n";

cout<< "s1: " << s1 <<endl;
cout<< "s2: " << s2 <<endl;
cout<< "s3: " << s3 <<endl;

but the output looks like this:

Code:

Please enter something:

Please enter something else: why does user input start here???

Please enter something else: wtf??? wtf???

Something else!!!

s1:
s2: why does user input start here???
s3: wtf??? wtf???

btw 'wtf' stands for 'what the fudge'... in case you were curious

Can anyone tell me why the program is skipping the first getline command?
Thank you for being patient with me.
(I'm using Dev c++ 4.9.9.2)

Put your newline at the END of what you print, not before it. And you should be using std::endl, not an actual '\n' character.

I made the changes you said brewbuck

Code:

#include <string>
#include <otherNeededheader(s)>
using std::string;
using std::cout;
using std::cin or endl or what other crap you see here; //not exact ;-)
...

string s1;
string s2;
string s3;

cout<<"Please enter something: " <<endl;
getline(cin, s1);
cout<<"Please enter something else: "<<endl;
getline(cin, s2);
cout<<"Please enter something else: "<<endl;
getline(cin, s3);

cout<<"Something else!!!"<<endl;

cout<< "s1: " << s1 <<endl;
cout<< "s2: " << s2 <<endl;
cout<< "s3: " << s3 <<endl;

but the output looks and works exactly the same :-(

Code:

Please enter something:
Please enter something else: why does user input STILL start here???
Please enter something else: wtf??? wtf???
Something else!!!

s1:
s2: why does user input STILL start here???
s3: wtf??? wtf???

any other ideas?

Originally Posted by A10

any other ideas?

The error is in the code you decided wasn't important.

While trying to find what was causeing the bug i desided to add cin.ignore(1024, '\n'); to see if something was still in the buffer.

Code:

#include <string>
#include <otherNeededheader(s)>
using std::string;
using std::cout;
using std::cin or endl or what other crap you see here; //not exact ;-)
...

string s1;
string s2;
string s3;

cin.ignore(1024,'\n')
cout<<"\n Please enter something: ";
getline(cin, s1);
cout<<"\n\n Please enter something else: ";
getline(cin, s2);
cout<<"\n Please enter something else: ";
getline(cin, s3);

cout<<"\nSomething else!!!\n\n";

cout<< "s1: " << s1 <<endl;
cout<< "s2: " << s2 <<endl;
cout<< "s3: " << s3 <<endl;

It works but It's only a temporary fix. I'll follow the code during execution to try and find where something's not being completely read or something of that nature.

Thank you Brewbuck

p.s.(The reason you don't see the changes from my previous post is because I copied and pasted from the first post.)

Are you by chance doing a:

Code:

	cin >> variable;

prior to the getline()'s? Because this would leave a newline in the input buffer.

>> It works but It's only a temporary fix.
Adding ignore() is the right way to fix it.

When you get input from cin >>, it leaves a newline in the input buffer as swoopy said. Calling ignore() ignores that newline. If you don't ignore the newline, then getline reads in the newline and stops; that's what getline is supposed to do. So it reads the newline from the previous input and the string is empty unti lthe next time you call getline.

A generic solution is to call cin.ignore() after each call to cin >>, but not after each call to getline.

>> And you should be using std::endl, not an actual '\n' character.
'\n' is often considered better because it doesn't do an unnecessary flush like endl.

Yes I am as a matter of fact. I hadn't thought of that. I know cin.getline(someNumber, variable); Will throw away the remaining newline char but would it just be smarter to cin.ignore(1,'\n'); after getting the input?

Thank you btw


EDIT: posted before reading Daveds post. Thank You daved for answering my question before I asked it (*twilight zone music*)

but would it just be smarter to cin.ignore(1,'\n'); after getting the input?

If you use cin >> in your code, it is quite possible that there will be more than just a newline in the input stream. The user may have typed several whitespace delimited items, of which only the first is read and the rest left in the stream.

If you want to force your user to hit enter after each entry (and not separate entries by space), then you should ignore a larger number than 1:

Code:

cin.ignore(1024, '\n'); // or, to maximize the number of characters ignored, use:
cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n'); // #include <limits> and <ios>?

In some cases you might read in a whitespace separated list of items with cin >> or prefer not to force the user to hit enter after each input. In those cases, you obviously don't want to ignore more than one character, because you could end up ignoring actual user input. You would then want to use cin.ignore() which ignores a single character. These cases are probably rarer, however.

With cin.ignore() you can never accidentally ignore part of the user's input. With cin.ignore(BIG_NUMBER, '\n') you don't have to worry about extraneous input screwing up your later input. Which you use depends on what you need for your program.