C++ Strings with spaces

Ok, i found this that works with spaces on the FAQ:

Code:

#include <iostream>
#include <string>

int main()
{
  std::string line;

  std::cout<<"Enter a string: ";

  if ( getline ( std::cin, line ) )
    std::cout<<"You entered \""<< line <<"\""<<std::endl;
}

and it works fine, but, i wanted to use it without the std:: for this program
(Simple i know):

Code:

#include <iostream>
#include <string>
using namespace std;

string pass;
string user;

int main()
{
    cout<<"What is your username?(12 characters max): ";
    cin.getline ( user, 12, '\n' );
    cin.ignore();
    cout<<"What is your password?(12 characters max): ";
    cin.getline ( pass, 12, '\n' );
    cin.ignore();
    if (user == "The Master" && pass == "I am master")
    {
             cout<<"Access is granted.\n";
             cout<<"Press enter to end user authentication.";
             cin.get();
    }
    else
    {
    cout<<"Access denied";
    cin.get();
}
}

however when i do that, i get the following error from my compiler(Dev-C++):
11 C:\Dev-Cpp\Tutorial\Inproved user authentication.cpp no matching function for call to `std::basic_istream<char, std::char_traits<char> >::getline(std::string&, int, char)'

Along with a similar error for line 14, (The 11 is the line number).
Both these errors seem to pertain to cin.getline which of course works fine if i use C strings instead. Ok, please tell me if there is a shorter code for the strings with spaces code, and if so how to use it. Thanks

Notice that in your first example, you call std::getline() but in your second example, you call std::cin.getline(). The former is for std::string the latter for null terminated strings.

I think to save it to a string vs a char* you want to use

Code:

getline(cin,pass,'\n');

vs

Code:

cin.getline()

Ok, thanks this works perfectly:

Code:

#include <iostream>
#include <string>
using namespace std;

string pass;
string user;
std::string line;
int main()
{
    cout<<"What is your username?: ";
    getline ( cin, user, '\n' );
    cout<<"What is your password?: ";
    getline ( cin, pass, '\n' );
    if (user == "The Master" && pass == "I am master")
    {
             cout<<"Access is granted.\n";
             cout<<"Press enter to end user authentication.";
             cin.get();
    }
    else
    {
    cout<<"Access denied";
    cin.get();
}

}

Thanks alot, i'm new to programming or i probably would have figured that out by myself... well back to the tutorials lol

As in your first code example, std::getline() does not need the third argument if it is to be the newline character. Also, I recommend avoiding global variables. I might write the code as:

Code:

#include <iostream>
#include <string>
using namespace std;

int main()
{
    string pass;
    string user;

    cout << "What is your username?: ";
    getline(cin, user);

    cout << "What is your password?: ";
    getline(cin, pass);

    if (user == "The Master" && pass == "I am master")
    {
        cout << "Access is granted.\n"
                "Press enter to end user authentication.";
    }
    else
    {
        cout << "Access denied";
    }
    cin.get();
}

I'd also put the std:: back in.

It's a bad habit to have "using namespace std;", that's more of a throwback to a time when pre-standard code was in wide use and it was necessary to quickly make older code compile on standard compilers. If you're writing new code, use std::string, std::cin, etc.

Namespaces are a key benefit of the language, don't throw them away.

Originally Posted by Mordacai

Ok, i found this that works with spaces on the FAQ:

Code:

#include <iostream>
#include <string>

int main()
{
  std::string line;

  std::cout<<"Enter a string: ";

  if ( getline ( std::cin, line ) )
    std::cout<<"You entered \""<< line <<"\""<<std::endl;
}

To be a stickler, that first example you posted would require a std:: in front of the getline to actually "work" as you put it.