Issues with using CHAR with IF/ELSE conditions.

Hey, sorry if this is already posted somewhere, I did a cursory glance over and saw nothing, so here I am.

I'm writing the second draft of a program I'm trying to make to keep a tally of sales my company's had over the last two months, and I think I'm doing alright so far, but I'm running into a complication with IF/ELSE statements in reference to CHAR inputs.

It debugs fine, but whenever I go to enter the month(June or July)it runs the "else" condition to terminate the program.

Here's the code:

Code:

/* First Draft Program for June/July Sales */

#include <iostream>
using namespace std;


int julydeliveries = 5463;
int julycpus = 1212;
int julyrepairs = 768;
int julytotals = julydeliveries + julycpus + julyrepairs;
int junedeliveries = 2352;
int junecpus = 1256;
int junerepairs = 247;
int junetotals = junedeliveries + junecpus + junerepairs;


int main()
{
    char month [5];
    cout << "Totals for: ";
    cin >> month;
    if (month == "june")
    {
         
    cout << "Deliveries: " << junedeliveries << "\n\n";
    system("pause");
    cout << "\n\nCustomer Pick-ups: " << junecpus << "\n\n";
    system("pause");
    cout << "\n\nRepairs: " << junerepairs << "\n\n";
    system("pause");
    cout << "\n\nTotal Sales: " << junetotals;
    cout << "\n\n";
    
}
    else if (month == "july")
    {
         cout << "Deliveries: " << julydeliveries <<"\n\n";
         system("pause");
         cout << "\n\nCustomer Pick-ups: " << julycpus << "\n\n";
         system("pause");
         cout << "\n\nRepairs: " << julyrepairs << "\n\n";
         system("pause");
         cout <<"\n\nTotal Sales: " << julytotals;
         cout << "\n\n";
}
    else
    {
        cout << "You must enter either June or July! Terminating Program!\n\n";
        }
        
        
    system("pause");
    
    return 0;
}

And, here's the outcome:

Code:

Totals for: June
You must enter either June or July! Terminating Program!

Press any key to continue . . .

Thanks, in advance!

If you want to compare such C-style null terminated strings, then you should use std::strcmp() from <cstring>. At the moment, you are comparing pointers, not strings.

A likely better fix would be to use std::string from <string>, and thus be able to write (month == "june") since std::string has overloaded operator== for string comparison.

By the way, this code really should go into the main() function:

Code:

int julydeliveries = 5463;
int julycpus = 1212;
int julyrepairs = 768;
int julytotals = julydeliveries + julycpus + julyrepairs;
int junedeliveries = 2352;
int junecpus = 1256;
int junerepairs = 247;
int junetotals = junedeliveries + junecpus + junerepairs;

You also should try and indent your code more clearly so that things like braces match properly. It is good that you used code tags though

Wow, okay. You'll have to forgive me, laserlight, I haven't done any coding since my introductory class a year ago. =P

Uhm, when you say "stdstring::" and so on... What? :P

I'm clueless as to all that. Sorry!

If you could be so kind as to tell me where to put the stdstring stuff and how to use it, like what context/where in the program, that'd be great.

Sorry for any inconvenience!

You could read the tutorial on C++ strings and also read cppreference.com's entries on C++ strings.

Ah, thanks a bunch! Those'll help immensely. =)

Wound up using something from the tutorial you posted, laserlight -- thank you, again. I had found that site earlier, but not found that tutorial.

Here's what I did:

Code:

    cout << "Totals for: ";
    string month;
    getline(cin, month, '\n');
    
        if (month == "june")
    {
         
         cout << "\n\nDeliveries: " << junedeliveries << "\n\n";
         
         cout << "\n\nCustomer Pick-ups: " << junecpus << "\n\n";
         
         cout << "\n\nRepairs: " << junerepairs << "\n\n";
         
         cout << "\n\nTotal Sales: " << junetotals;
         cout << "\n\n";
    
    }
    
        else if (month == "july")
    {
         cout << "\n\nDeliveries: " << julydeliveries <<"\n\n";
         
         cout << "\n\nCustomer Pick-ups: " << julycpus << "\n\n";
         
         cout << "\n\nRepairs: " << julyrepairs << "\n\n";
         
         cout <<"\n\nTotal Sales: " << julytotals;
         cout << "\n\n";
    }

Works perfectly, so far. Now to put in the real data. =P