Thread: Reg Function Pointers

Try using a proper typedef, by reading this -> http://www.newty.de/fpt/index.html
As opposed to casting everything to void* and hoping for the best.

Originally Posted by indigo0086

uh oh.

That's a great way *not* to get answers =)

Originally Posted by Desolation

That's a great way *not* to get answers =)

Or to get sarcastic replies about deathrays.....

Heh, that's a new one...an attempt at code tags in the attached file.

Here is the attachment as a regular post with code tags (I've fixed the indentation as well):

command.h

Code:

#define FUNCPTR  void *
#define MAX_NUM_COMMANDS 3

typedef struct
{
   char command[LINELEN];                           /* name of the command */
   char parm1[LINELEN];                             /*parameter 1 */
   char parm2[LINELEN];                             /*parameter 2 */
                                      
} ExeCmd_s;
class FunctionEntry
{

public:
    char* commandString;
    FUNCPTR pFun;   
    int SearchCommand(char* command);
};
FunctionEntry funArr[MAX_NUM_COMMANDS]=
{
	    {"aaa",(FUNCPTR)aaa},
            {"bbb", (FUNCPTR)bbb},
   	    {"ccc",(FUNCPTR)ccc}

};
enum commandName
{
	aaa = 0,
	bbb
};

command.c

Code:

void void Execute ()
{
    .........
    .........
    Execmd execmd;
    FunctionEntry command;
    int rc;
    if(0 != SearchCommand(exeCmd.command))
    {
        command = FunctionEntry.SearchCommand(exeCmd.command);
        switch((int)command.numOfArguements)
        {
        case Zero:
            rc = ((command.pFun)();
            break;
        case one:
            rc = ((command.pFun),exeCmd.parm1);
            break;
        }
    }
    else
    {
        printf("No match");
    }

}

//Function to search and returns the index of the command
int FunctionEntry :: SearchCommand(char* command)
{
     
    ExeCmd_s exeCmd;  //already had a Structure where I am extracting the commandname..
    int index = 0;     
    while(index < MAX_NUM_COMMANDS)
    {
        if(strcmp(exeCmd.command,funArr[index]) == 0)
        {
            return &funArr[index];
        }
        index++;	
    }
    return NULL;
}

Also,

Code:

FunctionEntry funArr[MAX_NUM_COMMANDS]=
{
	    {"aaa",(FUNCPTR)aaa},
            {"bbb", (FUNCPTR)bbb},
   	    {"ccc",(FUNCPTR)ccc}

};
enum commandName
{
	aaa = 0,
	bbb
};

aaa and bbb are declared after you use them, and ccc is not declared at all.

Code:

         case Zero :
         case one :

Use persistent capitalization! It will save you many headaches.

Code:

int FunctionEntry :: SearchCommand(char* command)
{
     /* ... */
     return NULL;
}

NULL isn't an int. It's something you put into a pointer. Return 0 or change the return type.