Searching Problem

In my other subroutine, I am inputting a person's first and last name. Here, I am merely searching for the last name. Whenever I input Snum that is supposed to be someone's last name, it gives me the "This person does not have this last name."

I have tried re-editing and fixing, but to no prevail, can anyone tell me what the problem is?

Code:

void searchlast()
{
	int I, found,f;
	char Snum[25][25];

	clrscr();
	do{ 
	cout<<"Last Name You Are Searching For: ";
	cin>>Snum[I];
	found=0;

	for(I=1; I<=u; I++)
	{
		if(namel[I]==Snum[I])
			{    cout<<"The Last Name " <<Snum<<" Was Found ";
				cout<<"In: "; cout<<""<<namef[I]; cout<<" "<<namel[I];cout<<"\n";
				cout<<"This person has an Average Score of: "<<avg[I];cout<<"\n";
				found=1;
				
				}

		if(namel[I]!=Snum[I])
		{ cout<<"No Student has this Last Name. \n";
		  }


	}
	cout<<"Search a new #? 1=Yes | 2=No: ";
	cin>>f;
	clrscr();		 
        }while(f!=2);

First of all, arrays start at index 0, not 1. Also, strings, especially C-style strings are not compared using ==. If you're using C-style strings, use strcmp().

In reality, you should be using C++ strings.

> char Snum[25][25];
Make this:

Code:

	std::string Snum;

And include <string>.
> cin>>Snum[i];
Make this:

Code:

	cin>>Snum;

> if(namel[i]==Snum[i])
Make this:

Code:

		if (namel[i]==Snum)

swoopy isnt the better way to compare

Code:

if (name1[i].compare(Snum) == 0)

return values for compare()
0 == exact match
1 == same length, but other differences may apply (case, spelling)
-1 == not the same at all
Not trying to argue, but someone flamed me for it a while back.
Then again I guess == and compare() are probably the same thing.

std::string::compare returns 0 if the strings are equal... and since 0 == false, your suggestion actually compares if the strings are not equal. In this case, I think that it is better to just use operator ==

Fixed:

Code:

void searchlast()
{
	int I, found,f,ptr;
	char Sname[25];
	ptr=0;

	clrscr();
	do{ 
	cout<<"Last Name You Are Searching For: ";
	gets (Sname);
	cout<<"\n";
	found=0;
	
	for(I=1; I<=u; I++)
	{       ptr=strcmpi(Sname, MyArr[I].namel);
		if (ptr==0)
		{
			    cout<<"The Last Name " <<Sname<<" Was Found ";
				cout<<"In: "; cout<<""<<MyArr[I].namef; cout<<" "<<MyArr[I].namel;cout<<"\n";

				found++;

		}



	}
        	if (found==0)
                { cout<<"No one has this last name.\n\n";}
	
	cout<<"Search a new #? 1=Yes | 2=No: ";
	cin>>f;
	clrscr();		 
        }while(f!=2);


}