I have problem with for(loop)

Hi all

my teacher asked me two things

first thing

he wants from me write program allow the user to enter 4 a digits numbers
and output will be like this

Quote:

---

Enter a 4 digits numbers
9876
6
7
8
9
Press any key to continue

---

and this code for program is correct100%

Code:

---

#include <iostream>
using namespace std;
int main()
{
    int n , d , i;

    cout << "Enter a 4 digits numbers\n";
    cin >> n;

    for(i=1; i<=4; i++)
    {
        d= n % 10;
        n = n / 10;
        cout << d <<endl;
    }
    return 0;
}

---

but where the problem ?

the problem in second question he wants write other program allow the user to enter any number he wants for example if he entered 987654 out will be like this

Quote:

---

4
5
6
7
8
9
Press any key to continue

---

not just 4 digits but every digits the user wants it

I tried more than 20 times but all my tries failed.

Well, the only thing that changes compared to the code you posted, is that instead of "4" in your loop condition you would have "x", where x is the number of digits in your number.

Now, the only thing you need to do is find the number of digits in a number...

Quote:

---

and this code for program is correct100%
but where the problem ?

---

If it's 100% correct, what makes you think there's a problem?

Quote:

---

the problem in second question he wants write other program allow the user to enter any number

---

Instead of looping a set number of times, just stop when n is 0. Something like 'while ( n != 0 )'. :)

Quote:

---

and this code for program is correct100%
...
but where the problem ?

---

Well if it's correct there is no problem, right? It must not be correct. :) It looks okay to me.

Well, to support more than four digits, obviously you need to change this.

Code:

---

for(i=1; i<=4; i++)

---

You may have noticed that when you run out of digits n is zero . . .

[edit] Great minds think alike, though you gave the game away, Noir. :) [/edit]

Quote:

---

Originally Posted by KONI

Well, the only thing that changes compared to the code you posted, is that instead of "4" in your loop condition you would have "x", where x is the number of digits in your number.

Now, the only thing you need to do is find the number of digits in a number...

---

thnx very much KONY You solved my problem in 3 minutes.


Noir,Dwks, thanx for sharing.

Quote:

---

though you gave the game away, Noir.

---

Not much I can do when it comes to easy problems. Any useful answer gives it away. :)