error C2084

Hi, I am building a program in Visual C++ and I get following error:

..\..\basic.cpp(5) : error C2084: function 'int Log(char [])' already has a body
c:\visualcpp\myprogram\basic.h(15) : see previous definition of 'Log'

The main file includes basic.h.


basic.h:

Code:

#ifndef BASIC_H
#define BASIC_H
#pragma once

#define WIN32_LEAN_AND_MEAN

#include <stdio.h>

int Log(char message[]);
#endif

basic.cpp:

Code:

#include "basic.h"


int Log(char message[])   {

    char log_name []= "log.txt";
    FILE *fp;
    
    fp=fopen(log_name,"a");
    fprintf(fp,"%s\n",message);
    fclose(fp);


	return 0;
}

hmm... basic.h only has 10 lines? The error is reported as being on line 15.

Originally Posted by laserlight

hmm... basic.h only has 10 lines? The error is reported as being on line 15.

That's weird. Are they really lines? I checked and there were really only 10 lines in basic.h. There are actually a bit more lines in basic.cpp. There are a few comments.

The original basic.cpp is here:

Code:

#include "basic.h"


int Log(char message[])   {
//
//comments
//
//

    char log_name []= "log.txt";
    FILE *fp;
    
    fp=fopen(log_name,"a");
    fprintf(fp,"%s\n",message);
    fclose(fp);


	return 0;
}

Are you using precompiled headers?
maybe clean and rebuild all will help?

I tried, that doesn't help.

I figured out, where that line 15 comes. It counts lines in basic.h until the line "int Log(char message[]);" and then counts lines forward from file basic.cpp function Log until the line
"int Log(char message[]); {"

"int Log(char message[]); {"

get rid of the semi colon in that line and you should be okay.

Originally Posted by stinkipete

"int Log(char message[]); {"

get rid of the semi colon in that line and you should be okay.

Sorry, I have written wrong. Where is no semi-colon.

You need to copy / paste exactly what is in those two files without any editing to make it "pretty" or "short" for the board.

And make sure the error messages you post are consistent with the code you post.

Also, try a different name. It could be that Log is already defined in a standard header. It is after all a pretty common name used for both "logging" and "mathematics".