Life sim C++programming tips

I created a program that is completely pointless. I'm still learning c++ so i wrote this program to see if i could do it and learn a little along the way. It's a life simulator, a small life simulator

Tell me what i can do better, thanks.

It's attached to this thread.

Why do you use C-style strings and not C++ strings?
Why don't you check the variable limits in your set functions?
Can Hunger be set below 0? Shouldn't you check it? What are the set function for anyway?
And of cource making User a global variable - I don't like it

You can put all your activities functions in some class Game
make person a member of this class
In this case you don't need to access the global variable User - just a member...

One more thing. Split the program into a number of files. Working with a single file can get really annpying when it comes to debug time , especialy when you are writing such a large program.

Your class definition could be placed into one header file, and then create a seperate .cpp file with the class implementation. Also, dont use global pointers. I think vart touched on this.

Quote:

---

Originally Posted by vart

Why do you use C-style strings and not C++ strings?
Why don't you check the variable limits in your set functions?
Can Hunger be set below 0? Shouldn't you check it? What are the set function for anyway?
And of cource making User a global variable - I don't like it

You can put all your activities functions in some class Game
make person a member of this class
In this case you don't need to access the global variable User - just a member...

---

what's the difference between a c-style string and a c++ style string?

i guess i could check the limits in my set functions instead of the check functions that'd probably save on space.

i do check hunger, it's in this function:

Code:

---

void hungerCheck(int transferHunger) //checks if your fat or skinny
{
    int hCheck;
    hCheck = User.GetHunger();
    hCheck += transferHunger;
    if( hCheck> 15)
    {
                death(1);
    }
    else if(hCheck < 0)
    {
                death(9);
    }
   
    else
    {
                User.ChangeHunger(transferHunger);
    }
}

---

that means if hunger goes below zero then death(9) (gluttony) is called

and i get what your saying with the class game thing, i'll go work on that.

C style string:

Code:

---

char name[30];

---

A C style string is a char array. The problem is it is limited to the amount
of space allocated by the programmer ( you ) in the brackets.

C++ string:

Code:

---

string name;

---

A C++ string has no character amount limits. Thus, making it much more
flexable than the C array style version. If you want to write a line with a space
you can use the getline() function of that.
Remember to #include <string> when you use C++ strings.

I think I would put the check of bounds inside the SetHunger function and return state
state will be enum like

Code:

---

enum LifeState
{
  helthy =0,
  death_of_hunger,
...
  death_of_overwight
}

---

in this case function hungerCheck
can be made like:

Code:

---



LifeState state = SetHunger (value);
if(state != helthy ) death(state);

---

All other set function will return other values of this state enum
And other checks could be made in the same way

nice work though, for a beginner

Also you should use <cstring> instead of <string.h> in C++ programs.